Skip to content

Commit 9b6ce41

Browse files
committed
toil(front): update SA specs to use new API definitions
1 parent 0c21e1d commit 9b6ce41

File tree

3 files changed

+174
-97
lines changed

3 files changed

+174
-97
lines changed

front/lib/front/models/service_account.ex

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,12 @@ defmodule Front.Models.ServiceAccount do
5353
member_ids <- Enum.map(members, & &1.id),
5454
{:ok, service_accounts} <-
5555
Front.ServiceAccount.describe_many(member_ids),
56-
service_accounts <- asssign_service_accounts_to_members(members, service_accounts) do
56+
service_accounts <- assign_service_accounts_to_members(members, service_accounts) do
5757
{:ok, {service_accounts, total_pages}}
58+
else
59+
error ->
60+
Logger.error("Failed to list service accounts: #{inspect(error)}")
61+
{:error, "Failed to list service accounts"}
5862
end
5963
end
6064

@@ -64,7 +68,8 @@ defmodule Front.Models.ServiceAccount do
6468
{:ok, _} <- assign_role(org_id, user_id, service_account, role_id) do
6569
{:ok, {from_proto(service_account), token}}
6670
else
67-
_ ->
71+
error ->
72+
Logger.error("Failed to create service account or assign role: #{inspect(error)}")
6873
{:error, "Failed to create service account or assign role"}
6974
end
7075
end
@@ -81,7 +86,9 @@ defmodule Front.Models.ServiceAccount do
8186
) do
8287
{:ok, from_proto(service_account)}
8388
else
84-
_ -> {:error, "Failed to update service account or assign role"}
89+
error ->
90+
Logger.error("Failed to update service account or assign role: #{inspect(error)}")
91+
{:error, "Failed to update service account or assign role"}
8592
end
8693
end
8794

@@ -90,7 +97,9 @@ defmodule Front.Models.ServiceAccount do
9097
:ok <- Front.ServiceAccount.delete(service_account_id) do
9198
{:ok, from_proto(service_account)}
9299
else
93-
_ -> {:error, "Failed to delete service account"}
100+
error ->
101+
Logger.error("Failed to delete service account: #{inspect(error)}")
102+
{:error, "Failed to delete service account"}
94103
end
95104
end
96105

@@ -99,7 +108,9 @@ defmodule Front.Models.ServiceAccount do
99108
{:ok, api_token} <- Front.ServiceAccount.regenerate_token(service_account_id) do
100109
{:ok, {from_proto(service_account), api_token}}
101110
else
102-
_ -> {:error, "Failed to regenerate service account token"}
111+
error ->
112+
Logger.error("Failed to regenerate service account token: #{inspect(error)}")
113+
{:error, "Failed to regenerate service account token"}
103114
end
104115
end
105116

@@ -127,7 +138,7 @@ defmodule Front.Models.ServiceAccount do
127138

128139
defp timestamp_to_datetime(_), do: DateTime.utc_now()
129140

130-
defp asssign_service_accounts_to_members(members, service_accounts) do
141+
defp assign_service_accounts_to_members(members, service_accounts) do
131142
members
132143
|> Enum.map(fn member ->
133144
{member, Enum.find(service_accounts, &(&1.id == member.id))}

0 commit comments

Comments
 (0)