feat(notifications): Support for tags (#591)

## 📝 Description
Feature branch for: #369

#### `notifications`
- refresh protos
- implement the updated API semaphoreci/api#39
(this API is also used by `front`)
- adds the filtering by tag rule if `git_ref_type == :TAG` so both
branch and tag rules can be defined in same notification

#### `front`
- refreshes protos
- adds tag field in notifications form

<img width="416" height="164" alt="image"
src="https://github.com/user-attachments/assets/8d892f05-936b-4a32-9d62-716d81f32c13"
/>

#### `public-api-gateway`
Refreshes protos in to add support for tags in notifications.

## ✅ Checklist
- [x] I have tested this change
- [x] This change requires documentation update

Author: hamir-suspect

front/assets/js/edit_notification.js

@@ -45,6 +45,17 @@ export var EditNotification = {
               <p class="f6 mt1 mb0 nb1">Comma separated, regular expressions allowed</p>
             </div>
 
+            <div class="pl4 mb3">
+              <label for="tags" class="db b mb1">
+                Tags
+                <span class="f6 normal gray"> · optional</span>
+              </label>
+              <input id="tags" name="rule_${rule_hash}[tags]" type="text"
+                     class="form-control w-100"
+                     placeholder="e.g. v1.0.0, /^v\\\\d+\\\\.\\\\d+\\\\.\\\\d+$/, release-*" >
+              <p class="f6 mt1 mb0 nb1">Comma separated, regular expressions allowed</p>
+            </div>
+
             <div class="pl4 mb3">
               <label for="pipelines" class="db b mb1">
                 Pipelines

front/lib/front/models/notification.ex

@@ -128,7 +128,8 @@ defmodule Front.Models.Notification do
           pipelines: data.pipelines,
           projects: data.projects,
           branches: data.branches,
-          results: data.results
+          results: data.results,
+          tags: data.tags || []
         ),
       name: data.rule_name,
       notify:

front/lib/front_web/controllers/notifications_controller.ex

@@ -342,6 +342,7 @@ defmodule FrontWeb.NotificationsController do
       blocks: params["blocks"] |> parse_entry,
       pipelines: params["pipelines"] |> parse_entry,
       results: params["results"] |> parse_entry,
+      tags: params["tags"] |> parse_entry,
       rule_name: params["name"],
       slack_channels: params["slack_channels"] |> parse_entry,
       slack_endpoint: params["slack_endpoint"],
@@ -373,7 +374,8 @@ defmodule FrontWeb.NotificationsController do
               pipelines: [],
               projects: [],
               results: [],
-              states: []
+              states: [],
+              tags: []
             },
             name: "",
             notify: %Notification.Spec.Rule.Notify{

front/lib/front_web/templates/notifications/_notifications.html.eex

@@ -20,6 +20,10 @@
                       <td class="pr3">Branches</td>
                       <td><%= rule.filter.branches |> Enum.join(", ") %></td>
                     </tr>
+                    <tr class="v-top">
+                      <td class="pr3">Tags</td>
+                      <td><%= rule.filter.tags |> Enum.join(", ") %></td>
+                    </tr>
                     <tr class="v-top">
                       <td class="pr3">Pipelines</td>
                       <td><%= rule.filter.pipelines |> Enum.join(", ") %></td>

front/lib/front_web/templates/notifications/form.html.eex

@@ -66,6 +66,18 @@
                   placeholder: "e.g. master, /prod-*/, /.*/" %>
               <p class="f6 mt1 mb0 nb1">Comma separated, regular expressions allowed</p>
             </div>
+            <div class="mb3 pl4">
+              <label class="db b mb1">
+                Tags
+                <span class="f6 normal gray"> · optional</span>
+              </label>
+              <%= text_input f, :tags,
+                  name: "rule_#{rule_hash}[tags]",
+                  value: rule.filter.tags |> Enum.join(", "),
+                  class: "form-control w-100",
+                  placeholder: "e.g. v1.0.0, /^v\\d+\\.\\d+\\.\\d+$/, release-*" %>
+              <p class="f6 mt1 mb0 nb1">Comma separated, regular expressions allowed</p>
+            </div>
             <div class="mb3 pl4">
               <label class="db b mb1">
                 Pipelines

front/lib/public_api/semaphore/notifications.v1alpha.pb.ex

@@ -72,9 +72,10 @@ defmodule Semaphore.Notifications.V1alpha.Notification.Spec.Rule.Filter do
           pipelines: [String.t()],
           blocks: [String.t()],
           states: [integer],
-          results: [String.t()]
+          results: [String.t()],
+          tags: [String.t()]
         }
-  defstruct [:projects, :branches, :pipelines, :blocks, :states, :results]
+  defstruct [:projects, :branches, :pipelines, :blocks, :states, :results, :tags]
 
   field(:projects, 1, repeated: true, type: :string)
   field(:branches, 2, repeated: true, type: :string)
@@ -88,6 +89,7 @@ defmodule Semaphore.Notifications.V1alpha.Notification.Spec.Rule.Filter do
   )
 
   field(:results, 6, repeated: true, type: :string)
+  field(:tags, 7, repeated: true, type: :string)
 end
 
 defmodule Semaphore.Notifications.V1alpha.Notification.Spec.Rule.Filter.State do

front/test/support/stubs/notification.ex

@@ -133,6 +133,15 @@ defmodule Support.Stubs.Notification do
     def create_notification(notification, call) do
       {org_id, _} = call |> extract_headers
 
+      notification =
+        if notification.metadata.id == "" do
+          id = UUID.gen()
+          metadata = %{notification.metadata | id: id}
+          %{notification | metadata: metadata}
+        else
+          notification
+        end
+
       DB.insert(:notifications, %{
         id: notification.metadata.id,
         org_id: org_id,
@@ -146,10 +155,19 @@ defmodule Support.Stubs.Notification do
     def update_notification(req, call) do
       case find(req, call) do
         {:ok, notification} ->
+          # Ensure the notification has the correct ID in metadata
+          updated_notification =
+            if req.notification.metadata.id == "" do
+              metadata = %{req.notification.metadata | id: notification.id}
+              %{req.notification | metadata: metadata}
+            else
+              req.notification
+            end
+
           new_notification = %{
-            id: req.notification.metadata.id,
-            name: req.notification.metadata.name,
-            api_model: req.notification,
+            id: notification.id,
+            name: updated_notification.metadata.name,
+            api_model: updated_notification,
             org_id: notification.org_id
           }
 

notifications/Makefile

@@ -4,7 +4,7 @@ include ../Makefile
 
 APP_NAME=$(shell grep 'app:' mix.exs | cut -d ':' -f3 | cut -d ',' -f1)
 PROTOC_TAG=1.12.1-3.17.3-0.7.1
-TMP_REPO_DIR=/tmp/internal_api
+TMP_REPO_DIR ?= /tmp/internal_api
 
 INTERNAL_API_BRANCH ?= master
 PUBLIC_API_BRANCH ?= master

notifications/lib/internal_api/notifications.pb.ex

@@ -65,10 +65,11 @@ defmodule InternalApi.Notifications.Notification.Rule.Filter do
           pipelines: [String.t()],
           blocks: [String.t()],
           states: [[InternalApi.Notifications.Notification.Rule.Filter.State.t()]],
-          results: [[InternalApi.Notifications.Notification.Rule.Filter.Results.t()]]
+          results: [[InternalApi.Notifications.Notification.Rule.Filter.Results.t()]],
+          tags: [String.t()]
         }
 
-  defstruct [:projects, :branches, :pipelines, :blocks, :states, :results]
+  defstruct [:projects, :branches, :pipelines, :blocks, :states, :results, :tags]
 
   field(:projects, 1, repeated: true, type: :string)
   field(:branches, 2, repeated: true, type: :string)
@@ -86,6 +87,8 @@ defmodule InternalApi.Notifications.Notification.Rule.Filter do
     type: InternalApi.Notifications.Notification.Rule.Filter.Results,
     enum: true
   )
+
+  field(:tags, 7, repeated: true, type: :string)
 end
 
 defmodule InternalApi.Notifications.Notification.Rule.Notify.Slack do
@@ -224,10 +227,11 @@ defmodule InternalApi.Notifications.Notification do
           update_time: Google.Protobuf.Timestamp.t() | nil,
           rules: [InternalApi.Notifications.Notification.Rule.t()],
           status: InternalApi.Notifications.Notification.Status.t() | nil,
-          org_id: String.t()
+          org_id: String.t(),
+          creator_id: String.t()
         }
 
-  defstruct [:name, :id, :create_time, :update_time, :rules, :status, :org_id]
+  defstruct [:name, :id, :create_time, :update_time, :rules, :status, :org_id, :creator_id]
 
   field(:name, 1, type: :string)
   field(:id, 2, type: :string)
@@ -236,6 +240,7 @@ defmodule InternalApi.Notifications.Notification do
   field(:rules, 5, repeated: true, type: InternalApi.Notifications.Notification.Rule)
   field(:status, 6, type: InternalApi.Notifications.Notification.Status)
   field(:org_id, 7, type: :string)
+  field(:creator_id, 8, type: :string)
 end
 
 defmodule InternalApi.Notifications.ListRequest do