toil(front): Refactor all the front lint suggestions (#318)

## 📝 Description

While working on
renderedtext/project-tasks#2405, I could not
get a green build due to linting errors. This PR fixes credo lint
errors.

## ✅ Checklist
- [x] I have tested this change
- [ ] This change requires documentation update

Author: VeljkoMaksimovic

front/lib/front/branch_page/model.ex

@@ -47,11 +47,9 @@ defmodule Front.BranchPage.Model do
 
   @spec get(LoadParams.t()) :: {:ok, __MODULE__.t()} | {:error, String.t()}
   def get(params, opts \\ []) do
-    with true <- first_page?(params) do
-      fetch_from_cache(params, opts[:force_cold_boot])
-    else
-      false ->
-        load_from_api(params)
+    case first_page?(params) do
+      true -> fetch_from_cache(params, opts[:force_cold_boot])
+      false -> load_from_api(params)
     end
   end
 

front/lib/front/models/secret_updater.ex

@@ -16,9 +16,11 @@ defmodule Front.Models.SecretUpdater do
       processed: [],
       new_by_old_key:
         new_ones
-        |> Enum.filter(&valid_string?(&1[old_key_as_string(type)]))
-        |> Enum.filter(&valid_string?(&1[key_as_string(type)]))
-        |> Enum.filter(&(valid_string?(&1["md5"]) || valid_string?(&1[value_as_string(type)])))
+        |> Enum.filter(fn item ->
+          valid_string?(item[old_key_as_string(type)]) &&
+            valid_string?(item[key_as_string(type)]) &&
+            (valid_string?(item["md5"]) || valid_string?(item[value_as_string(type)]))
+        end)
         |> Map.new(&{&1[old_key_as_string(type)], &1})
     }
 

front/lib/front/models/support_request.ex

@@ -38,11 +38,9 @@ defmodule Front.Models.SupportRequest do
     changeset = changeset(input)
 
     if changeset.valid? do
-      with {:ok, response} <- Support.submit_request(changeset.changes) do
-        {:ok, response}
-      else
-        {:error, "failed-to-submit"} ->
-          {:error, "failed-to-submit", changeset}
+      case Support.submit_request(changeset.changes) do
+        {:ok, response} -> {:ok, response}
+        {:error, "failed-to-submit"} -> {:error, "failed-to-submit", changeset}
       end
     else
       {:error, changeset}

front/lib/front/project_settings/deletion_validator.ex

@@ -42,11 +42,9 @@ defmodule Front.ProjectSettings.DeletionValidator do
   end
 
   defp set_feedback_if_missing(changeset) do
-    with nil <- get_field(changeset, :feedback) do
-      put_change(changeset, :feedback, "N/A")
-    else
-      _e ->
-        changeset
+    case get_field(changeset, :feedback) do
+      nil -> put_change(changeset, :feedback, "N/A")
+      _e -> changeset
     end
   end
 

front/lib/front_web/controllers/artifacts_controller.ex

@@ -166,10 +166,11 @@ defmodule FrontWeb.ArtifactsController do
       |> Audit.metadata(source_kind: source_kind, source_id: source_id, project_id: project_id)
       |> Audit.log()
 
-      with {:ok, url} <- Artifacthub.signed_url(project_id, source_kind, source_id, artifact_path) do
-        conn
-        |> redirect(external: url)
-      else
+      case Artifacthub.signed_url(project_id, source_kind, source_id, artifact_path) do
+        {:ok, url} ->
+          conn
+          |> redirect(external: url)
+
         _ ->
           conn
           |> put_flash(:alert, "Failed to fetch requested artifact.")
@@ -200,12 +201,12 @@ defmodule FrontWeb.ArtifactsController do
       |> Audit.metadata(source_kind: source_kind, source_id: source.id, project_id: project_id)
       |> Audit.log()
 
-      with {:ok, _response} <-
-             Artifacthub.destroy(project_id, source_kind, source.id, artifact_path) do
-        conn
-        |> put_flash(:notice, "Artifact resource deleted.")
-        |> redirect(to: redirect_path(conn, action, source))
-      else
+      case Artifacthub.destroy(project_id, source_kind, source.id, artifact_path) do
+        {:ok, _response} ->
+          conn
+          |> put_flash(:notice, "Artifact resource deleted.")
+          |> redirect(to: redirect_path(conn, action, source))
+
         _ ->
           conn
           |> put_flash(:alert, "Failed to delete the artifact.")

front/lib/front_web/controllers/notifications_controller.ex

@@ -222,26 +222,27 @@ defmodule FrontWeb.NotificationsController do
       org_id = conn.assigns.organization_id
       user_id = conn.assigns.user_id
 
-      with {:ok, notification} <- Notification.find(id, user_id, org_id) do
-        organization = Organization.find(org_id)
-
-        render(
-          conn,
-          "form.html",
-          form_title: "Edit Notification",
-          js: "notification",
-          action: notifications_path(conn, :update, id),
-          method: :put,
-          notification: notification,
-          title: "Editing #{notification.metadata.name}・#{organization.name}",
-          cancel_path: notifications_path(conn, :index),
-          errors: %{},
-          organization: organization,
-          org_restricted: organization.restricted,
-          permissions: conn.assigns.permissions,
-          can_view_settings: true
-        )
-      else
+      case Notification.find(id, user_id, org_id) do
+        {:ok, notification} ->
+          organization = Organization.find(org_id)
+
+          render(
+            conn,
+            "form.html",
+            form_title: "Edit Notification",
+            js: "notification",
+            action: notifications_path(conn, :update, id),
+            method: :put,
+            notification: notification,
+            title: "Editing #{notification.metadata.name}・#{organization.name}",
+            cancel_path: notifications_path(conn, :index),
+            errors: %{},
+            organization: organization,
+            org_restricted: organization.restricted,
+            permissions: conn.assigns.permissions,
+            can_view_settings: true
+          )
+
         {:error, %{status: 5}} ->
           conn
           |> render_404
@@ -260,11 +261,12 @@ defmodule FrontWeb.NotificationsController do
       org_id = conn.assigns.organization_id
 
       if conn.assigns.permissions["organization.notifications.manage"] || false do
-        with {:ok, _} <- Notification.delete(id, user_id, org_id) do
-          conn
-          |> put_flash(:notice, "Notification deleted.")
-          |> redirect(to: notifications_path(conn, :index))
-        else
+        case Notification.delete(id, user_id, org_id) do
+          {:ok, _} ->
+            conn
+            |> put_flash(:notice, "Notification deleted.")
+            |> redirect(to: notifications_path(conn, :index))
+
           {:error, %{status: 5}} ->
             conn
             |> render_404

front/lib/front_web/controllers/organization_okta_controller.ex

@@ -16,21 +16,22 @@ defmodule FrontWeb.OrganizationOktaController do
     Watchman.benchmark(watchman_name(:show, :duration), fn ->
       organization_id = conn.assigns.organization_id
 
-      with {:ok, params} <- fetch_params(organization_id) do
-        case OktaIntegration.find_for_org(organization_id) do
-          {:ok, integration} ->
-            Watchman.increment(watchman_name(:show, :success))
-            render_show(conn, integration, params)
-
-          {:error, :not_found} ->
-            Watchman.increment(watchman_name(:show, :success))
-            render_show(conn, nil, params)
+      case fetch_params(organization_id) do
+        {:ok, params} ->
+          case OktaIntegration.find_for_org(organization_id) do
+            {:ok, integration} ->
+              Watchman.increment(watchman_name(:show, :success))
+              render_show(conn, integration, params)
+
+            {:error, :not_found} ->
+              Watchman.increment(watchman_name(:show, :success))
+              render_show(conn, nil, params)
+
+            e ->
+              Watchman.increment(watchman_name(:show, :failure))
+              raise e
+          end
 
-          e ->
-            Watchman.increment(watchman_name(:show, :failure))
-            raise e
-        end
-      else
         {:error, reason} ->
           Watchman.increment(watchman_name(:show, :failure))
           {:error, reason}
@@ -57,11 +58,11 @@ defmodule FrontWeb.OrganizationOktaController do
             integration |> OktaIntegration.changeset()
         end
 
-      with {:ok, params} <- fetch_params(organization_id) do
-        Watchman.increment(watchman_name(:form, :success))
+      case fetch_params(organization_id) do
+        {:ok, params} ->
+          Watchman.increment(watchman_name(:form, :success))
+          render_form(conn, changeset, params)
 
-        render_form(conn, changeset, params)
-      else
         {:error, reason} ->
           Watchman.increment(watchman_name(:form, :failure))
           {:error, reason}
@@ -182,9 +183,10 @@ defmodule FrontWeb.OrganizationOktaController do
 
     organization_id = conn.assigns.organization_id
 
-    with {:ok, params} <- fetch_params(organization_id) do
-      render_discnonnect_notice(conn, integration_id, params)
-    else
+    case fetch_params(organization_id) do
+      {:ok, params} ->
+        render_discnonnect_notice(conn, integration_id, params)
+
       {:error, reason} ->
         Watchman.increment(watchman_name(:discnonnect_notice, :failure))
         {:error, reason}

front/lib/front_web/controllers/project_pfc_controller.ex

@@ -100,13 +100,14 @@ defmodule FrontWeb.ProjectPFCController do
       log_data = log_data_closure(organization_id, project_id, user_id, :delete)
       audit_log(conn)
 
-      with :ok <- ProjectPFC.destroy(project_id, user_id) do
-        Watchman.increment(watchman_name(:delete, :success))
+      case ProjectPFC.destroy(project_id, user_id) do
+        :ok ->
+          Watchman.increment(watchman_name(:delete, :success))
+
+          conn
+          |> put_flash(:notice, "Success: pre-flight checks deleted")
+          |> redirect(to: project_pfc_path(conn, :show, project_name_or_id))
 
-        conn
-        |> put_flash(:notice, "Success: pre-flight checks deleted")
-        |> redirect(to: project_pfc_path(conn, :show, project_name_or_id))
-      else
         {:error, reason} ->
           Watchman.increment(watchman_name(:delete, :failure))
           Logger.error(log_data.(reason))

front/lib/front_web/controllers/project_settings/secrets_controller.ex

@@ -133,23 +133,23 @@ defmodule FrontWeb.ProjectSettings.SecretsController do
         |> Audit.metadata(project_name: conn.assigns.project.name)
         |> Audit.log()
 
-      with {:ok, secret} <-
-             Models.Secret.create(
-               params["name"],
-               Params.parse_params(params),
-               %{project_id: project_id},
-               :PROJECT,
-               user_id,
-               org_id
-             ) do
-        audit
-        |> Audit.add(:resource_id, secret.id)
-        |> Audit.log()
+      case Models.Secret.create(
+             params["name"],
+             Params.parse_params(params),
+             %{project_id: project_id},
+             :PROJECT,
+             user_id,
+             org_id
+           ) do
+        {:ok, secret} ->
+          audit
+          |> Audit.add(:resource_id, secret.id)
+          |> Audit.log()
+
+          conn
+          |> put_flash(:notice, "Secret created.")
+          |> redirect(to: secrets_path(conn, :index, conn.params["name_or_id"]))
 
-        conn
-        |> put_flash(:notice, "Secret created.")
-        |> redirect(to: secrets_path(conn, :index, conn.params["name_or_id"]))
-      else
         {:error, validation_errors} ->
           maybe_permissions =
             Async.run(fn ->
@@ -235,31 +235,33 @@ defmodule FrontWeb.ProjectSettings.SecretsController do
       org_id = conn.assigns.organization_id
       project = conn.assigns.project
 
-      with {:ok, _secret} <-
-             Models.Secret.update(
-               secret_id,
-               params["name"],
-               params["description"],
-               Params.parse_env_vars(params),
-               Params.parse_files(params),
-               user_id,
-               org_id,
-               secret_level: :PROJECT,
-               project_config: %{project_id: project.id},
-               project_id: project.id
-             ) do
-        conn
-        |> Audit.new(:Secret, :Modified)
-        |> Audit.add(description: "Updated secret #{params["name"]} in the project #{project.id}")
-        |> Audit.add(resource_name: params["name"])
-        |> Audit.metadata(project_id: project.id)
-        |> Audit.metadata(project_name: project.name)
-        |> Audit.log()
+      case Models.Secret.update(
+             secret_id,
+             params["name"],
+             params["description"],
+             Params.parse_env_vars(params),
+             Params.parse_files(params),
+             user_id,
+             org_id,
+             secret_level: :PROJECT,
+             project_config: %{project_id: project.id},
+             project_id: project.id
+           ) do
+        {:ok, _secret} ->
+          conn
+          |> Audit.new(:Secret, :Modified)
+          |> Audit.add(
+            description: "Updated secret #{params["name"]} in the project #{project.id}"
+          )
+          |> Audit.add(resource_name: params["name"])
+          |> Audit.metadata(project_id: project.id)
+          |> Audit.metadata(project_name: project.name)
+          |> Audit.log()
+
+          conn
+          |> put_flash(:notice, "Secret updated.")
+          |> redirect(to: secrets_path(conn, :index, project.name))
 
-        conn
-        |> put_flash(:notice, "Secret updated.")
-        |> redirect(to: secrets_path(conn, :index, project.name))
-      else
         {:error, :not_found} ->
           conn
           |> render_404

front/lib/front_web/controllers/secrets_controller.ex

@@ -204,25 +204,25 @@ defmodule FrontWeb.SecretsController do
       |> Audit.log()
 
       if conn.assigns.permissions["organization.secrets.manage"] || false do
-        with {:ok, _secret} <-
-               Models.Secret.update(
-                 secret_id,
-                 params["name"],
-                 params["description"],
-                 Params.parse_env_vars(params),
-                 Params.parse_files(params),
-                 user_id,
-                 org_id,
-                 org_config:
-                   Params.parse_org_config(
-                     params,
-                     conn.assigns.permissions["organization.secrets_policy_settings.manage"]
-                   )
-               ) do
-          conn
-          |> put_flash(:notice, "Secret updated.")
-          |> redirect(to: secrets_path(conn, :index))
-        else
+        case Models.Secret.update(
+               secret_id,
+               params["name"],
+               params["description"],
+               Params.parse_env_vars(params),
+               Params.parse_files(params),
+               user_id,
+               org_id,
+               org_config:
+                 Params.parse_org_config(
+                   params,
+                   conn.assigns.permissions["organization.secrets_policy_settings.manage"]
+                 )
+             ) do
+          {:ok, _secret} ->
+            conn
+            |> put_flash(:notice, "Secret updated.")
+            |> redirect(to: secrets_path(conn, :index))
+
           {:error, :not_found} ->
             conn
             |> render_404