toil: normalize eslint rules

Author: skipi

front/assets/.eslintrc.js

@@ -26,7 +26,7 @@ module.exports = {
   },
   ignorePatterns: ["*.js", "*.json"],
   rules: {},
- overrides: [
+  overrides: [
     {
       files: ["js/**/*.spec.js"],
       env: {
@@ -86,7 +86,8 @@ module.exports = {
             },
           },
         ],
-        "no-console": 1,
+        "no-console": ["error", { allow: ["warn", "error"] }],
+        "max-len": ["error", {"code": 140, "ignoreComments": true, "ignoreStrings": true, "ignoreTemplateLiterals": true}],
         "no-multi-spaces": "error",
         "@typescript-eslint/member-delimiter-style": [
           "warn",
@@ -97,13 +98,14 @@ module.exports = {
             },
             singleline: {
               delimiter: "comma",
-              requireLast: true,
+              requireLast: false,
             },
           },
         ],
         "semi-spacing": ["error", {"before": false, "after": true}],
         "react/jsx-uses-react": "off",
         "react/react-in-jsx-scope": "off",
+        // "react/jsx-one-expression-per-line": ["error", { "allow": "single-child" }],
         "react/display-name": "off",
         "react/jsx-tag-spacing": [
           "error",
@@ -114,6 +116,12 @@ module.exports = {
             beforeClosing: "never",
           },
         ],
+        "@typescript-eslint/no-misused-promises": [
+          "error",
+          {
+            "checksVoidReturn": false
+          }
+        ]
       },
     },
   ],

front/assets/js/agents/index.tsx

@@ -5,7 +5,7 @@ import { BrowserRouter, Routes, Route, Navigate } from "react-router-dom";
 import * as stores from "js/agents/stores";
 import * as pages from "js/agents/pages";
 
-export default function ({ dom, config }: { dom: HTMLElement, config: any, }) {
+export default function ({ dom, config }: { dom: HTMLElement, config: any }) {
   const configState = stores.Config.State.fromJSON(config);
   render(
     <BrowserRouter basename={config.baseUrl}>

front/assets/js/agents/stores/activity.tsx

@@ -125,13 +125,13 @@ export class Item {
 }
 
 export type Action =
-  | { type: `SET_WAITING_ITEMS`, value: Item[], }
-  | { type: `SET_RUNNING_ITEMS`, value: Item[], }
-  | { type: `SET_LOBBY_ITEMS`, value: Item[], }
-  | { type: `SET_HOSTED_AGENTS`, value: Agent[], }
-  | { type: `SET_SELF_HOSTED_AGENTS`, value: Agent[], }
-  | { type: `DELETE_SELF_HOSTED_AGENT`, value: string, }
-  | { type: `SET_INVISIBLE_JOBS_COUNT`, value: number, };
+  | { type: `SET_WAITING_ITEMS`, value: Item[] }
+  | { type: `SET_RUNNING_ITEMS`, value: Item[] }
+  | { type: `SET_LOBBY_ITEMS`, value: Item[] }
+  | { type: `SET_HOSTED_AGENTS`, value: Agent[] }
+  | { type: `SET_SELF_HOSTED_AGENTS`, value: Agent[] }
+  | { type: `DELETE_SELF_HOSTED_AGENT`, value: string }
+  | { type: `SET_INVISIBLE_JOBS_COUNT`, value: number };
 
 export interface State {
   hostedAgents: Agent[];

front/assets/js/agents/stores/self_hosted_agent.tsx

@@ -2,13 +2,13 @@ import { createContext } from "preact";
 import * as types from "../types";
 
 export type Action =
-  | { type: `SET_AGENT_TYPE`, value: types.SelfHosted.AgentType, }
-  | { type: `SET_AGENTS`, value: types.SelfHosted.Agent[], }
-  | { type: `SET_TOKEN`, value: string, }
-  | { type: `REVEAL_TOKEN`, }
-  | { type: `HIDE_TOKEN`, }
-  | { type: `JUST_CREATED`, }
-  | { type: `JUST_RESET`, };
+  | { type: `SET_AGENT_TYPE`, value: types.SelfHosted.AgentType }
+  | { type: `SET_AGENTS`, value: types.SelfHosted.Agent[] }
+  | { type: `SET_TOKEN`, value: string }
+  | { type: `REVEAL_TOKEN` }
+  | { type: `HIDE_TOKEN` }
+  | { type: `JUST_CREATED` }
+  | { type: `JUST_RESET` };
 
 export interface State {
   token: string;

front/assets/js/billing/components/charts.tsx

@@ -21,7 +21,7 @@ const DefaultPlotState: PlotState = {
   width: 0,
 };
 
-const PlotContext = createContext<{ plotState: PlotState, plotData: PlotData[], }>({
+const PlotContext = createContext<{ plotState: PlotState, plotData: PlotData[] }>({
   plotState: DefaultPlotState,
   plotData: [],
 });

front/assets/js/billing/components/group_tooltip.tsx

@@ -14,7 +14,7 @@ export const GroupTooltip = (props: GroupTooltipProps) => {
   />;
 };
 
-const GroupDescription = ({ group }: { group: types.Spendings.Group, }) => {
+const GroupDescription = ({ group }: { group: types.Spendings.Group }) => {
   switch (group.type) {
     case types.Spendings.GroupType.MachineCapacity:
       return (

front/assets/js/billing/components/invoice_list.tsx

@@ -61,7 +61,7 @@ export const InvoiceList = () => {
   );
 };
 
-const Invoice = ({ invoice, lastItem }: { invoice: types.Spendings.Invoice, lastItem?: boolean, }) => {
+const Invoice = ({ invoice, lastItem }: { invoice: types.Spendings.Invoice, lastItem?: boolean }) => {
   return (
     <div className={ lastItem ? `` : `b--black-075 bb`}>
       <div className="ph3 pv2">

front/assets/js/billing/components/loader.tsx

@@ -22,14 +22,14 @@ export const Container = (props: Props) => {
   }
 };
 
-export const LoadingSpinner = ({ text }: { text: string, }) => {
+export const LoadingSpinner = ({ text }: { text: string }) => {
   return (<div className="pv2 flex items-center justify-center">
     <toolbox.Asset path="images/spinner-2.svg" width="20" height="20"/>
     <div className="ml1 gray">{text}</div>
   </div>);
 };
 
-export const LoadingFailed = ({ text, retry }: { text: string, retry?: boolean, }) => {
+export const LoadingFailed = ({ text, retry }: { text: string, retry?: boolean }) => {
 
   const { dispatch: dispatchRequest } = useContext(stores.Request.Context);
   if(retry) {

front/assets/js/billing/components/navigation.tsx

@@ -14,7 +14,7 @@ export const Navigation = () => {
   const displayProjects = config.projectSpendings;
   const hasPlans = config.availablePlans.length > 0;
 
-  const className = ({ isActive }: { isActive: boolean, }) => {
+  const className = ({ isActive }: { isActive: boolean }) => {
     return (
       `link db pv1 ph2 br3 ` +
       (isActive ? `white active bg-green` : `dark-gray hover-bg-lightest-gray`)

front/assets/js/billing/components/plan_flags.tsx

@@ -16,7 +16,7 @@ export const PlanFlags = () => {
   );
 };
 
-const SuspensionFlag = ({ plan }: { plan: types.Spendings.Plan, }) => {
+const SuspensionFlag = ({ plan }: { plan: types.Spendings.Plan }) => {
   if (plan.didCreditsRunOut()) {
     return <CreditsRunOut plan={plan}/>;
   }
@@ -30,7 +30,7 @@ const SuspensionFlag = ({ plan }: { plan: types.Spendings.Plan, }) => {
   }
 };
 
-const NoPaymentMethod = ({ plan }: { plan: types.Spendings.Plan, }) => {
+const NoPaymentMethod = ({ plan }: { plan: types.Spendings.Plan }) => {
   return (
     <div className="flex items-center justify-between bb b--black-075 w-100-l mb3 br3 bg-red bg-pattern-wave pa3">
       <div className="white f3">Payment method not set.</div>
@@ -39,7 +39,7 @@ const NoPaymentMethod = ({ plan }: { plan: types.Spendings.Plan, }) => {
   );
 };
 
-const PaymentFailed = ({ plan }: { plan: types.Spendings.Plan, }) => {
+const PaymentFailed = ({ plan }: { plan: types.Spendings.Plan }) => {
   return (
     <div className="flex items-center justify-between bb b--black-075 w-100-l mb3 br3 bg-red bg-pattern-wave pa3">
       <div className="white f3">Your last payment failed.</div>
@@ -48,7 +48,7 @@ const PaymentFailed = ({ plan }: { plan: types.Spendings.Plan, }) => {
   );
 };
 
-const CreditsRunOut = ({ plan }: { plan: types.Spendings.Plan, }) => {
+const CreditsRunOut = ({ plan }: { plan: types.Spendings.Plan }) => {
   let content = `You ran out of credits.`;
   if (plan.isFree()) {
     content = `You used up your free credit quota.`;