Fix linting warnings

Author: VeljkoMaksimovic

ee/ephemeral_environments/lib/ephemeral_environments/grpc/ephemeral_environments_server.ex

@@ -1,36 +1,15 @@
 defmodule EphemeralEnvironments.Grpc.EphemeralEnvironmentsServer do
   use GRPC.Server, service: InternalApi.EphemeralEnvironments.EphemeralEnvironments.Service
 
-  alias InternalApi.EphemeralEnvironments.{
-    ListRequest,
-    ListResponse,
-    DescribeRequest,
-    DescribeResponse,
-    CreateRequest,
-    CreateResponse,
-    UpdateRequest,
-    UpdateResponse,
-    DeleteRequest,
-    DeleteResponse,
-    CordonRequest,
-    CordonResponse
-  }
+  alias EphemeralEnvironments.Service.EphemeralEnvironmentType
 
   def list(request, _stream) do
-    case EphemeralEnvironments.Service.EphemeralEnvironmentType.list(request.org_id) do
-      {:ok, environment_types} ->
-        %{environment_types: environment_types}
-
-      {:error, error_message} ->
-        raise GRPC.RPCError, status: :unknown, message: error_message
-    end
+    {:ok, environment_types} = EphemeralEnvironmentType.list(request.org_id)
+    %{environment_types: environment_types}
   end
 
   def describe(request, _stream) do
-    case EphemeralEnvironments.Service.EphemeralEnvironmentType.describe(
-           request.id,
-           request.org_id
-         ) do
+    case EphemeralEnvironmentType.describe(request.id, request.org_id) do
       {:ok, environment_type} ->
         # Note: instances field will be added once we implement instance management
         %{environment_type: environment_type, instances: []}
@@ -44,7 +23,7 @@ defmodule EphemeralEnvironments.Grpc.EphemeralEnvironmentsServer do
   end
 
   def create(request, _stream) do
-    case EphemeralEnvironments.Service.EphemeralEnvironmentType.create(request.environment_type) do
+    case EphemeralEnvironmentType.create(request.environment_type) do
       {:ok, ret} ->
         %{environment_type: ret}
 
@@ -54,7 +33,7 @@ defmodule EphemeralEnvironments.Grpc.EphemeralEnvironmentsServer do
   end
 
   def update(request, _stream) do
-    case EphemeralEnvironments.Service.EphemeralEnvironmentType.update(request.environment_type) do
+    case EphemeralEnvironmentType.update(request.environment_type) do
       {:ok, environment_type} ->
         %{environment_type: environment_type}
 
@@ -67,10 +46,8 @@ defmodule EphemeralEnvironments.Grpc.EphemeralEnvironmentsServer do
   end
 
   def delete(_request, _stream) do
-    %DeleteResponse{}
   end
 
   def cordon(_request, _stream) do
-    %CordonResponse{}
   end
 end

ee/ephemeral_environments/lib/ephemeral_environments/service/ephemeral_environment_type.ex

@@ -159,10 +159,9 @@ defmodule EphemeralEnvironments.Service.EphemeralEnvironmentType do
         String.replace(acc, "%{#{key}}", safe_to_string(value))
       end)
     end)
-    |> Enum.map(fn {field, errors} ->
+    |> Enum.map_join("; ", fn {field, errors} ->
       "#{field}: #{Enum.join(errors, ", ")}"
     end)
-    |> Enum.join("; ")
   end
 
   # Safely convert values to strings, handling complex types

ee/ephemeral_environments/lib/ephemeral_environments/utils/proto.ex

@@ -54,8 +54,8 @@ defmodule EphemeralEnvironments.Utils.Proto do
   end
 
   def to_map(value), do: value
-  defp convert_value(value, module, field) when is_list(value), do: Enum.map(value, &to_map/1)
-  defp convert_value(value, module, field) when is_struct(value), do: to_map(value)
+  defp convert_value(value, _module, _field) when is_list(value), do: Enum.map(value, &to_map/1)
+  defp convert_value(value, _module, _field) when is_struct(value), do: to_map(value)
 
   defp convert_value(value, module, field) when is_integer(value) do
     # Check if this field is an enum by looking at the field definition
@@ -78,37 +78,33 @@ defmodule EphemeralEnvironments.Utils.Proto do
   # If given field is of type enum inside the parent module, the name of the enum module
   # will be returned. Otherwise it will return nil.
   defp get_enum_module(module, field) do
-    try do
-      field_props =
-        module.__message_props__().field_props |> Enum.map(fn {_num, props} -> props end)
+    field_props =
+      module.__message_props__().field_props |> Enum.map(fn {_num, props} -> props end)
 
-      field_info = find_field_info(field_props, field)
+    field_info = find_field_info(field_props, field)
 
-      if field_info && field_info.enum? do
-        case field_info.type do
-          {:enum, enum_module} -> enum_module
-          _ -> nil
-        end
-      else
-        nil
+    if field_info && field_info.enum? do
+      case field_info.type do
+        {:enum, enum_module} -> enum_module
+        _ -> nil
       end
-    rescue
-      _ -> nil
+    else
+      nil
     end
+  rescue
+    _ -> nil
   end
 
   defp integer_to_atom(enum_module, value) do
-    try do
-      enum_module.__message_props__()
-      |> Map.get(:field_props, %{})
-      |> Enum.find(fn {_name, props} -> props[:enum_value] == value end)
-      |> case do
-        {name, _} -> normalize_enum_name(name, enum_module)
-        nil -> value
-      end
-    rescue
-      _ -> value
+    enum_module.__message_props__()
+    |> Map.get(:field_props, %{})
+    |> Enum.find(fn {_name, props} -> props[:enum_value] == value end)
+    |> case do
+      {name, _} -> normalize_enum_name(name, enum_module)
+      nil -> value
     end
+  rescue
+    _ -> value
   end
 
   # Normalize enum names by removing prefix and lowercasing

ee/ephemeral_environments/lib/internal_api/include/google/protobuf/timestamp.pb.ex

@@ -1,5 +1,4 @@
 list='
-include/google/protobuf/timestamp
 ephemeral_environments
 rbac
 '

ee/ephemeral_environments/scripts/internal_protos.sh

@@ -16,7 +16,7 @@ defmodule EphemeralEnvironments.Grpc.EphemeralEnvironmentsServerTest do
 
   @org_id Ecto.UUID.generate()
   @user_id Ecto.UUID.generate()
-  @grpc_port 50051
+  @grpc_port 50_051
 
   setup do
     :ok = Ecto.Adapters.SQL.Sandbox.checkout(Repo)