fix(front): remove redundant checks from add people button visibility check #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skipi
force-pushed
the
mk/ee-fix-adding-members
branch
3 times, most recently
from
4c45660 to
3beae9f
Compare
hamir-suspect
force-pushed
the
mk/ee-fix-adding-members
branch
5 times, most recently
from
4b88553 to
57fb191
Compare
hamir-suspect
force-pushed
the
mk/ee-fix-adding-members
branch
from
70bc944 to
4108ee5
Compare
hamir-suspect
requested review from
lucaspin,
DamjanBecirovic,
hamir-suspect,
VeljkoMaksimovic and
forestileao
as code owners
hamir-suspect
previously approved these changes
Aug 27, 2025
hamir-suspect
force-pushed
the
mk/ee-fix-adding-members
branch
from
bd232c0 to
b66b635
Compare
hamir-suspect
force-pushed
the
mk/ee-fix-adding-members
branch
4 times, most recently
from
b564d8f to
ebb3441
Compare
hamir-suspect
force-pushed
the
mk/ee-fix-adding-members
branch
from
ebb3441 to
4042579
Compare
hamir-suspect
previously approved these changes
Aug 27, 2025
…r proper functionality
hamir-suspect
approved these changes
Aug 27, 2025
dexyk
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
_add_people_button partial already performs required checks. We only need to check if we're on the
on_premenvironment.Introduces
github_user_provider,gitlab_user_providerandbitbucket_user_providerfeature flags so OS installations can enable user authentication integration with git providers.Introduces
user_repos_accessfeature flag for specific setups that need to restrict users from connecting their git provider account to semaphore account.✅ Checklist