fix(tasks): summary scanner

Author: fiftin

services/tasks/stage_parsers/ansible_play.go

@@ -3,6 +3,7 @@ package stage_parsers
 import (
 	"github.com/semaphoreui/semaphore/db"
 	"github.com/semaphoreui/semaphore/util"
+	"regexp"
 	"strings"
 )
 
@@ -48,6 +49,9 @@ func (p AnsibleRunningStageParser) IsEnd(currentStage *db.TaskStage, output db.T
 const ansibleTaskMaker = "TASK ["
 const failedTaskMaker = "fatal: ["
 
+var newTaskMakerRE = regexp.MustCompile(`^\w+: \[`)
+var fatalTaskRE = regexp.MustCompile(`^fatal: \[([^]]+)]: FAILED! => (.*)$`)
+
 func (p AnsibleRunningStageParser) Parse(currentStage *db.TaskStage, output db.TaskOutput, store db.Store, projectID int) (ok bool, err error) {
 
 	if currentStage == nil {
@@ -64,6 +68,7 @@ func (p AnsibleRunningStageParser) Parse(currentStage *db.TaskStage, output db.T
 
 	if strings.HasPrefix(line, ansibleTaskMaker) {
 		p.state.Tasks++
+
 		if p.state.CurrentFailedHost != "" {
 			err = store.CreateAnsibleTaskError(db.AnsibleTaskError{
 				TaskID:    currentStage.TaskID,
@@ -82,13 +87,40 @@ func (p AnsibleRunningStageParser) Parse(currentStage *db.TaskStage, output db.T
 		p.state.CurrentTask = line[len(ansibleTaskMaker):end]
 		p.state.CurrentFailedHost = ""
 		p.state.CurrentHostAnswer = ""
+
 	} else if strings.HasPrefix(line, failedTaskMaker) {
-		end := strings.Index(line, "]")
-		start := len(failedTaskMaker)
-		p.state.CurrentFailedHost = line[start:end]
-		p.state.CurrentHostAnswer = ""
+
+		if p.state.CurrentFailedHost != "" {
+			err = store.CreateAnsibleTaskError(db.AnsibleTaskError{
+				TaskID:    currentStage.TaskID,
+				ProjectID: projectID,
+				Host:      p.state.CurrentFailedHost,
+				Task:      p.state.CurrentTask,
+				Error:     p.state.CurrentHostAnswer,
+			})
+
+			if err != nil {
+				return
+			}
+		}
+
+		m := fatalTaskRE.FindStringSubmatch(line)
+		if len(m) > 0 {
+			host := strings.TrimSpace(m[1])
+			msg := strings.TrimSpace(m[2])
+			p.state.CurrentFailedHost = host
+			p.state.CurrentHostAnswer = msg
+		} else {
+			end := strings.Index(line, "]")
+			start := len(failedTaskMaker)
+			p.state.CurrentFailedHost = line[start:end]
+			p.state.CurrentHostAnswer = ""
+		}
+
 	} else if p.state.CurrentFailedHost != "" {
-		if line == "" {
+		m := newTaskMakerRE.FindStringSubmatch(line)
+		if line == "" || len(m) > 0 {
+
 			if p.state.CurrentFailedHost != "" {
 				err = store.CreateAnsibleTaskError(db.AnsibleTaskError{
 					TaskID:    currentStage.TaskID,
@@ -104,6 +136,7 @@ func (p AnsibleRunningStageParser) Parse(currentStage *db.TaskStage, output db.T
 			}
 			p.state.CurrentFailedHost = ""
 			p.state.CurrentHostAnswer = ""
+
 		} else {
 			p.state.CurrentHostAnswer += "\n" + line
 		}

web/src/components/AnsibleStageView.vue

@@ -50,6 +50,7 @@
       :headers="notOkServersHeaders"
       :items="failedTasks"
       :items-per-page="Number.MAX_VALUE"
+      class="w-100"
     >
       <template v-slot:item.error="{ item }">
         <div
@@ -61,15 +62,16 @@
         <td
           :colspan="headers.length"
         >
-          <pre style="overflow: auto;
-                            background: gray;
-                            font-size: 14px;
-                            color: white;
-                            border-radius: 10px;
-                            margin-top: 5px; margin-bottom: 5px;"
+            <pre style="overflow: auto;
+                  background: gray;
+                  font-size: 14px;
+                  color: white;
+                  border-radius: 10px;
+                  white-space: wrap;
+                  margin-top: 5px; margin-bottom: 5px;"
 
-               class="pa-2"
-          >{{ item.error.trim() }}</pre>
+                 class="pa-2"
+            >{{ item.error.trim() }}</pre>
         </td>
       </template>
     </v-data-table>