Skip to content

Commit 487ed51

Browse files
committed
fix(tf): use alias instead of id
1 parent 8180c00 commit 487ed51

File tree

5 files changed

+40
-10
lines changed

5 files changed

+40
-10
lines changed

db/TerraformInventoryAlias.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package db
33
import "reflect"
44

55
type TerraformInventoryAlias struct {
6-
ID int `db:"id" json:"id"`
76
ProjectID int `db:"project_id" json:"project_id"`
87
InventoryID int `db:"inventory_id" json:"inventory_id"`
98
AuthKeyID int `db:"auth_key_id" json:"auth_key_id"`
@@ -14,12 +13,12 @@ type TerraformInventoryAlias struct {
1413
var TerraformInventoryAliasProps = ObjectProps{
1514
TableName: "project__terraform_inventory_alias",
1615
Type: reflect.TypeOf(TerraformInventoryAlias{}),
17-
PrimaryColumnName: "id",
16+
PrimaryColumnName: "alias",
1817
}
1918

2019
func (alias TerraformInventoryAlias) ToAlias() Alias {
2120
return Alias{
22-
ID: alias.ID,
21+
//ID: alias.ID,
2322
Alias: alias.Alias,
2423
ProjectID: alias.ProjectID,
2524
}

db/TerraformInventoryStore_pro.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ package db
33
type TerraformStore interface {
44
CreateTerraformInventoryAlias(alias TerraformInventoryAlias) (TerraformInventoryAlias, error)
55
GetTerraformInventoryAliasByAlias(alias string) (TerraformInventoryAlias, error)
6-
GetTerraformInventoryAlias(projectID int, inventoryID int, aliasID int) (TerraformInventoryAlias, error)
6+
GetTerraformInventoryAlias(projectID int, inventoryID int, aliasID string) (TerraformInventoryAlias, error)
77
GetTerraformInventoryAliases(projectID, inventoryID int) ([]TerraformInventoryAlias, error)
88
UpdateTerraformInventoryAlias(alias TerraformInventoryAlias) error
9-
DeleteTerraformInventoryAlias(projectID int, inventoryID int, aliasID int) error
9+
DeleteTerraformInventoryAlias(projectID int, inventoryID int, aliasID string) error
1010

1111
CreateTerraformInventoryState(State TerraformInventoryState) (TerraformInventoryState, error)
1212
GetTerraformInventoryState(projectID int, inventoryId int, stateID int) (TerraformInventoryState, error)

db/sql/SqlDb.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,12 @@ func (d *SqlDbConnection) SelectAll(i any, query string, args ...any) ([]any, er
235235
}
236236

237237
func (d *SqlDbConnection) DeleteObject(projectID int, props db.ObjectProps, objectID any) error {
238+
primaryColumnName := "id"
239+
240+
if props.PrimaryColumnName != "" {
241+
primaryColumnName = props.PrimaryColumnName
242+
}
243+
238244
if props.IsGlobal {
239245
return validateMutationResult(
240246
d.Exec(
@@ -243,7 +249,7 @@ func (d *SqlDbConnection) DeleteObject(projectID int, props db.ObjectProps, obje
243249
} else {
244250
return validateMutationResult(
245251
d.Exec(
246-
"delete from "+props.TableName+" where project_id=? and id=?",
252+
"delete from "+props.TableName+" where project_id=? and "+primaryColumnName+"=?",
247253
projectID,
248254
objectID))
249255
}

pro/db/sql/terraform_inventory.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ func (d *TerraformStoreImpl) GetTerraformInventoryAliasByAlias(alias string) (re
1919
return
2020
}
2121

22-
func (d *TerraformStoreImpl) GetTerraformInventoryAlias(projectID, inventoryID int, aliasID int) (res db.TerraformInventoryAlias, err error) {
22+
func (d *TerraformStoreImpl) GetTerraformInventoryAlias(projectID, inventoryID int, aliasID string) (res db.TerraformInventoryAlias, err error) {
2323
return
2424
}
2525

2626
func (d *TerraformStoreImpl) GetTerraformInventoryAliases(projectID, inventoryID int) (res []db.TerraformInventoryAlias, err error) {
2727
return
2828
}
2929

30-
func (d *TerraformStoreImpl) DeleteTerraformInventoryAlias(projectID int, inventoryID int, aliasID int) (err error) {
30+
func (d *TerraformStoreImpl) DeleteTerraformInventoryAlias(projectID int, inventoryID int, aliasID string) (err error) {
3131
return
3232
}
3333

web/src/views/project/template/TemplateTerraformState.vue

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,9 @@
210210
</v-btn>
211211
</v-alert>
212212

213+
<h3>Aliases</h3>
214+
<div class="mb-6">Alieases allows you to use state externally</div>
215+
213216
<div class="mb-3 pl-1" v-if="(aliases || []).length === 0">There is no aliases.</div>
214217

215218
<div v-else v-for="alias of (aliases || [])" :key="alias.id">
@@ -230,19 +233,27 @@
230233
color="primary"
231234
@click="addAlias()"
232235
:disabled="!premiumFeatures.terraform_backend"
236+
class="mb-8"
233237
>
234238
{{ aliases == null ? $t('LoadAlias') : $t('AddAlias') }}
235239
</v-btn>
236240

241+
<v-divider class="mb-4" />
242+
243+
<h3>State history</h3>
244+
<div class="mb-6">Alieases allows you to use state externally</div>
245+
237246
<v-data-table
238-
style="max-width: 1000px; margin: auto; background: transparent;"
247+
style="
248+
background: transparent;
249+
"
239250
v-if="premiumFeatures.terraform_backend"
240251
:headers="headers"
241252
:items="states"
242253
:footer-props="{ itemsPerPageOptions: [20] }"
243254
single-expand
244255
show-expand
245-
class="mt-4 TaskListTable"
256+
class="mt-4 TaskListTable TaskListTable TerraformStateTable"
246257
>
247258
<template v-slot:item.id="{ item }">
248259
#{{ item.id }}
@@ -291,6 +302,20 @@
291302

292303
</div>
293304
</template>
305+
<style lang="scss">
306+
.TerraformStateTable {
307+
308+
.v-data-table__wrapper {
309+
padding-left: 0 !important;
310+
padding-right: 0 !important;
311+
}
312+
313+
.v-data-footer {
314+
margin-left: 0 !important;
315+
margin-right: 0 !important;
316+
}
317+
}
318+
</style>
294319
<script>
295320
296321
import axios from 'axios';

0 commit comments

Comments
 (0)