Skip to content

Commit 8a58a58

Browse files
committed
fix(logging): do not write error for killed process
1 parent 9a2c994 commit 8a58a58

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

services/tasks/TaskRunner_logging.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,9 @@ func (t *TaskRunner) logPipe(reader io.Reader) {
153153
}()
154154

155155
scanner := bufio.NewScanner(reader)
156-
//const maxCapacity = 10 * 1024 * 1024 // 10 MB
157-
//buf := make([]byte, maxCapacity)
158-
//scanner.Buffer(buf, maxCapacity)
156+
const maxCapacity = 10 * 1024 * 1024 // 10 MB
157+
buf := make([]byte, maxCapacity)
158+
scanner.Buffer(buf, maxCapacity)
159159

160160
for scanner.Scan() {
161161
line := scanner.Text()
@@ -172,7 +172,7 @@ func (t *TaskRunner) logPipe(reader io.Reader) {
172172
msg := "Failed to read TaskRunner output"
173173

174174
switch scanner.Err().Error() {
175-
case "EOF":
175+
case "EOF", "os: process already finished":
176176
return // it is ok
177177
case "bufio.Scanner: token too long":
178178
msg = "TaskRunner output exceeds the maximum allowed size of 10MB"

0 commit comments

Comments
 (0)