chore(golangci-lint): refactor all code with golangci-lint

use `golangci-lint run --fix` to autofix explict lint error

Author: efficacy38

api/apps.go

@@ -14,8 +14,8 @@ import (
 	"strings"
 )
 
-func structToFlatMap(obj interface{}) map[string]interface{} {
-	result := make(map[string]interface{})
+func structToFlatMap(obj any) map[string]any {
+	result := make(map[string]any)
 	val := reflect.ValueOf(obj)
 	typ := reflect.TypeOf(obj)
 
@@ -137,7 +137,7 @@ func deleteApp(w http.ResponseWriter, r *http.Request) {
 	w.WriteHeader(http.StatusNoContent)
 }
 
-func setAppOption(store db.Store, appID string, field string, val interface{}) error {
+func setAppOption(store db.Store, appID string, field string, val any) error {
 	key := "apps." + appID + "." + field
 
 	if val == nil {

api/auth.go

@@ -22,7 +22,7 @@ func getSession(r *http.Request) (*db.Session, bool) {
 		return nil, false
 	}
 
-	value := make(map[string]interface{})
+	value := make(map[string]any)
 	if err = util.Cookie.Decode("semaphore", cookie.Value, &value); err != nil {
 		//w.WriteHeader(http.StatusUnauthorized)
 		return nil, false

api/helpers/context.go

@@ -3,8 +3,8 @@ package helpers
 import (
 	"net/http"
 
-	"github.com/semaphoreui/semaphore/db"
 	"github.com/gorilla/context"
+	"github.com/semaphoreui/semaphore/db"
 )
 
 func UserFromContext(r *http.Request) *db.User {

api/helpers/helpers.go

@@ -71,10 +71,10 @@ func GetIntParam(name string, w http.ResponseWriter, r *http.Request) (int, erro
 }
 
 // H just a string-to-anything map
-type H map[string]interface{}
+type H map[string]any
 
 // Bind decodes json into object
-func Bind(w http.ResponseWriter, r *http.Request, out interface{}) bool {
+func Bind(w http.ResponseWriter, r *http.Request, out any) bool {
 	err := json.NewDecoder(r.Body).Decode(out)
 	if err != nil {
 		w.WriteHeader(http.StatusBadRequest)
@@ -84,7 +84,7 @@ func Bind(w http.ResponseWriter, r *http.Request, out interface{}) bool {
 }
 
 // WriteJSON writes object as JSON
-func WriteJSON(w http.ResponseWriter, code int, out interface{}) {
+func WriteJSON(w http.ResponseWriter, code int, out any) {
 	w.Header().Set("content-type", "application/json")
 	w.WriteHeader(code)
 

api/integration.go

@@ -217,7 +217,7 @@ func Match(matcher db.IntegrationMatcher, header http.Header, bodyBytes []byte)
 	return false
 }
 
-func MatchCompare(value interface{}, method db.IntegrationMatchMethodType, expected string) bool {
+func MatchCompare(value any, method db.IntegrationMatchMethodType, expected string) bool {
 
 	if intValue, ok := conv.ConvertFloatToIntIfPossible(value); ok {
 		value = intValue

api/login.go

@@ -177,7 +177,7 @@ func createSession(w http.ResponseWriter, r *http.Request, user db.User) {
 		return
 	}
 
-	encoded, err := util.Cookie.Encode("semaphore", map[string]interface{}{
+	encoded, err := util.Cookie.Encode("semaphore", map[string]any{
 		"user":    user.ID,
 		"session": newSession.ID,
 	})
@@ -542,17 +542,17 @@ func parseClaim(str string, claims map[string]any) (string, bool) {
 	return "", false
 }
 
-func prepareClaims(claims map[string]interface{}) {
+func prepareClaims(claims map[string]any) {
 	for k, v := range claims {
-		switch v.(type) {
+		switch v := v.(type) {
 		case float64:
-			f := v.(float64)
+			f := v
 			i := int64(f)
 			if float64(i) == f {
 				claims[k] = i
 			}
 		case float32:
-			f := v.(float32)
+			f := v
 			i := int64(f)
 			if float32(i) == f {
 				claims[k] = i
@@ -584,7 +584,7 @@ func parseClaims(claims map[string]any, provider util.ClaimsProvider) (res claim
 }
 
 func claimOidcUserInfo(userInfo *oidc.UserInfo, provider util.OidcProvider) (res claimResult, err error) {
-	claims := make(map[string]interface{})
+	claims := make(map[string]any)
 	if err = userInfo.Claims(&claims); err != nil {
 		return
 	}
@@ -595,7 +595,7 @@ func claimOidcUserInfo(userInfo *oidc.UserInfo, provider util.OidcProvider) (res
 }
 
 func claimOidcToken(idToken *oidc.IDToken, provider util.OidcProvider) (res claimResult, err error) {
-	claims := make(map[string]interface{})
+	claims := make(map[string]any)
 	if err = idToken.Claims(&claims); err != nil {
 		return
 	}

api/login_test.go

@@ -5,7 +5,7 @@ import (
 )
 
 func TestParseClaim(t *testing.T) {
-	claims := map[string]interface{}{
+	claims := map[string]any{
 		"username": "fiftin",
 		"email":    "",
 		"id":       1234567,
@@ -23,7 +23,7 @@ func TestParseClaim(t *testing.T) {
 }
 
 func TestParseClaim2(t *testing.T) {
-	claims := map[string]interface{}{
+	claims := map[string]any{
 		"username": "fiftin",
 		"email":    "",
 		"id":       1234567,
@@ -41,7 +41,7 @@ func TestParseClaim2(t *testing.T) {
 }
 
 func TestParseClaim3(t *testing.T) {
-	claims := map[string]interface{}{
+	claims := map[string]any{
 		"username": "fiftin",
 		"email":    "",
 		"id":       1234567,
@@ -55,7 +55,7 @@ func TestParseClaim3(t *testing.T) {
 }
 
 func TestParseClaim4(t *testing.T) {
-	claims := map[string]interface{}{
+	claims := map[string]any{
 		"username": "fiftin",
 		"email":    "",
 		"id":       1234567,
@@ -69,7 +69,7 @@ func TestParseClaim4(t *testing.T) {
 }
 
 func TestParseClaim5(t *testing.T) {
-	claims := map[string]interface{}{
+	claims := map[string]any{
 		"username": "fiftin",
 		"email":    "",
 		"id":       123456757343.0,

api/options.go

@@ -1,9 +1,9 @@
 package api
 
 import (
+	"github.com/gorilla/context"
 	"github.com/semaphoreui/semaphore/api/helpers"
 	"github.com/semaphoreui/semaphore/db"
-	"github.com/gorilla/context"
 	"net/http"
 )
 

api/projects/backup_restore.go

@@ -5,10 +5,10 @@ import (
 	"net/http"
 	"strings"
 
+	"github.com/gorilla/context"
 	"github.com/semaphoreui/semaphore/api/helpers"
 	"github.com/semaphoreui/semaphore/db"
 	projectService "github.com/semaphoreui/semaphore/services/project"
-	"github.com/gorilla/context"
 	log "github.com/sirupsen/logrus"
 )
 

api/projects/environment.go

@@ -222,7 +222,7 @@ func RemoveEnvironment(w http.ResponseWriter, r *http.Request) {
 
 	err := helpers.Store(r).DeleteEnvironment(env.ProjectID, env.ID)
 	if err == db.ErrInvalidOperation {
-		helpers.WriteJSON(w, http.StatusBadRequest, map[string]interface{}{
+		helpers.WriteJSON(w, http.StatusBadRequest, map[string]any{
 			"error": "Environment is in use by one or more templates",
 			"inUse": true,
 		})