Fix missing return statement in appMiddleware and function call args in setup.go

Co-authored-by: fiftin <[email protected]>

Author: Copilot

api/apps.go

@@ -22,6 +22,7 @@ func appMiddleware(next http.Handler) http.Handler {
 		appID, err := helpers.GetStrParam("app_id", w, r)
 		if err != nil {
 			helpers.WriteErrorStatus(w, err.Error(), http.StatusBadRequest)
+			return
 		}
 
 		if err := validateAppID(appID); err != nil {

api/public/.gitkeep

@@ -296,7 +296,8 @@ func askValue(prompt string, defaultValue string, item any) {
 
 	_, _ = fmt.Sscanln(defaultValue, item)
 
-	scanErrorChecker(fmt.Scanln(item))
+	n, err := fmt.Scanln(item)
+	scanErrorChecker(n, err)
 
 	// Empty line after prompt
 	fmt.Println("")
@@ -312,7 +313,8 @@ func askConfirmation(prompt string, defaultValue bool, item *bool) {
 
 	var answer string
 
-	scanErrorChecker(fmt.Scanln(&answer))
+	n, err := fmt.Scanln(&answer)
+	scanErrorChecker(n, err)
 
 	switch strings.ToLower(answer) {
 	case "y", "yes":

cli/setup/setup.go

@@ -24,4 +24,6 @@ func CreateStore() db.Store {
 	default:
 		panic("Unsupported database dialect: " + config.Dialect)
 	}
+	// This line should never be reached due to panic above, but satisfies linter
+	return nil
 }