chore(golangci-lint): stop handle error on Close()

most Close() is not so critical, add `//nolint:errcheck` to ignore them

Author: efficacy38

api/login.go

@@ -9,7 +9,6 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
-	"github.com/semaphoreui/semaphore/pkg/tz"
 	"net/http"
 	"net/url"
 	"os"
@@ -18,6 +17,8 @@ import (
 	"text/template"
 	"time"
 
+	"github.com/semaphoreui/semaphore/pkg/tz"
+
 	"github.com/coreos/go-oidc/v3/oidc"
 	"github.com/go-ldap/ldap/v3"
 	"github.com/gorilla/mux"
@@ -60,7 +61,7 @@ func tryFindLDAPUser(username, password string) (*db.User, error) {
 	if err != nil {
 		return nil, err
 	}
-	defer l.Close()
+	defer l.Close() //nolint:errcheck
 
 	// First bind with a read only user
 	if err = l.Bind(util.Config.LdapBindDN, util.Config.LdapBindPassword); err != nil {
@@ -137,7 +138,6 @@ func tryFindLDAPUser(username, password string) (*db.User, error) {
 	}
 
 	err = db.ValidateUser(ldapUser)
-
 	if err != nil {
 		jsonBytes, _ := json.Marshal(ldapUser)
 		log.Error("LDAP returned incorrect user data: " + string(jsonBytes))
@@ -171,7 +171,6 @@ func createSession(w http.ResponseWriter, r *http.Request, user db.User) {
 		VerificationMethod: verificationMethod,
 		Verified:           verified,
 	})
-
 	if err != nil {
 		log.Error(err)
 		helpers.WriteErrorStatus(w, "Failed to create session", http.StatusInternalServerError)
@@ -196,7 +195,6 @@ func createSession(w http.ResponseWriter, r *http.Request, user db.User) {
 
 func loginByPassword(store db.Store, login string, password string) (user db.User, err error) {
 	user, err = store.GetUserByLoginOrEmail(login, login)
-
 	if err != nil {
 		return
 	}
@@ -207,7 +205,6 @@ func loginByPassword(store db.Store, login string, password string) (user db.Use
 	}
 
 	err = bcrypt.CompareHashAndPassword([]byte(user.Password), []byte(password))
-
 	if err != nil {
 		err = db.ErrNotFound
 		return
@@ -364,7 +361,6 @@ func login(w http.ResponseWriter, r *http.Request) {
 // - 204 No Content: Logout successful.
 // - 500 Internal Server Error: An error occurred while expiring the session.
 func logout(w http.ResponseWriter, r *http.Request) {
-
 	if session, ok := getSession(r); ok {
 		err := helpers.Store(r).ExpireSession(session.UserID, session.ID)
 		if err != nil {
@@ -512,8 +508,7 @@ type claimResult struct {
 	email    string
 }
 
-func parseClaim(str string, claims map[string]interface{}) (string, bool) {
-
+func parseClaim(str string, claims map[string]any) (string, bool) {
 	for _, s := range strings.Split(str, "|") {
 		s = strings.TrimSpace(s)
 
@@ -523,7 +518,6 @@ func parseClaim(str string, claims map[string]interface{}) (string, bool) {
 
 		if strings.Contains(s, "{{") {
 			tpl, err := template.New("").Parse(s)
-
 			if err != nil {
 				return "", false
 			}
@@ -567,8 +561,7 @@ func prepareClaims(claims map[string]interface{}) {
 	}
 }
 
-func parseClaims(claims map[string]interface{}, provider util.ClaimsProvider) (res claimResult, err error) {
-
+func parseClaims(claims map[string]any, provider util.ClaimsProvider) (res claimResult, err error) {
 	var ok bool
 	res.email, ok = parseClaim(provider.GetEmailClaim(), claims)
 
@@ -622,7 +615,6 @@ func getRandomProfileName() string {
 
 func getSecretFromFile(source string) (string, error) {
 	content, err := os.ReadFile(source)
-
 	if err != nil {
 		return "", err
 	}
@@ -691,7 +683,6 @@ func oidcRedirect(w http.ResponseWriter, r *http.Request) {
 		userInfo, err = _oidc.UserInfo(ctx, oauth2.StaticTokenSource(oauth2Token))
 
 		if err == nil {
-
 			if userInfo.Email == "" {
 				claims, err = claimOidcUserInfo(userInfo, provider)
 			} else {

db/sql/SqlDb.go

@@ -5,6 +5,11 @@ import (
 	"embed"
 	"errors"
 	"fmt"
+	"reflect"
+	"regexp"
+	"strconv"
+	"strings"
+
 	"github.com/Masterminds/squirrel"
 	"github.com/go-gorp/gorp/v3"
 	_ "github.com/go-sql-driver/mysql" // imports mysql driver
@@ -13,10 +18,6 @@ import (
 	"github.com/semaphoreui/semaphore/pkg/task_logger"
 	"github.com/semaphoreui/semaphore/util"
 	log "github.com/sirupsen/logrus"
-	"reflect"
-	"regexp"
-	"strconv"
-	"strings"
 )
 
 type SqlDb struct {
@@ -35,7 +36,6 @@ create table ` + "`migrations`" + ` (
 var dbAssets embed.FS
 
 func getQueryForParams(q squirrel.SelectBuilder, prefix string, props db.ObjectProps, params db.RetrieveQueryParams) (res squirrel.SelectBuilder, err error) {
-
 	pp, err := params.Validate(props)
 	if err != nil {
 		return
@@ -78,9 +78,7 @@ func handleRollbackError(err error) {
 	}
 }
 
-var (
-	identifierQuoteRE = regexp.MustCompile("`")
-)
+var identifierQuoteRE = regexp.MustCompile("`")
 
 // validateMutationResult checks the success of the update query
 func validateMutationResult(res sql.Result, err error) error {
@@ -137,13 +135,11 @@ func (d *SqlDb) insert(primaryKeyColumnName string, query string, args ...interf
 		}
 	default:
 		res, err := d.exec(query, args...)
-
 		if err != nil {
 			return 0, err
 		}
 
 		insertId, err = res.LastInsertId()
-
 		if err != nil {
 			return 0, err
 		}
@@ -212,10 +208,9 @@ func createDb() error {
 		return err
 	}
 
-	defer conn.Close()
+	defer conn.Close() //nolint:errcheck
 
 	_, err = conn.Exec("create database " + cfg.GetDbName())
-
 	if err != nil {
 		log.Warn(err.Error())
 	}
@@ -235,7 +230,6 @@ func (d *SqlDb) getObject(projectID int, props db.ObjectProps, objectID int, obj
 	}
 
 	query, args, err := q.ToSql()
-
 	if err != nil {
 		return
 	}
@@ -246,7 +240,6 @@ func (d *SqlDb) getObject(projectID int, props db.ObjectProps, objectID int, obj
 }
 
 func (d *SqlDb) makeObjectsQuery(projectID int, props db.ObjectProps, params db.RetrieveQueryParams) (q squirrel.SelectBuilder, err error) {
-
 	columns := []string{"*"}
 	if len(props.SelectColumns) > 0 {
 		columns = props.SortableColumns
@@ -296,7 +289,6 @@ func (d *SqlDb) getObjects(
 	objects interface{},
 ) (err error) {
 	q, err := d.makeObjectsQuery(projectID, props, params)
-
 	if err != nil {
 		return
 	}
@@ -306,7 +298,6 @@ func (d *SqlDb) getObjects(
 	}
 
 	query, args, err := q.ToSql()
-
 	if err != nil {
 		return
 	}
@@ -349,7 +340,6 @@ func (d *SqlDb) Connect(_ string) {
 	}
 
 	err = sqlDb.Ping()
-
 	if err != nil {
 		if err = sqlDb.Close(); err != nil {
 			log.Warn("Cannot close database connection: " + err.Error())
@@ -459,7 +449,6 @@ func (d *SqlDb) getObjectRefsFrom(
 	if referringObjectProps.Type == db.ScheduleProps.Type {
 		var referringSchedules []db.Schedule
 		_, err = d.selectAll(&referringSchedules, "select template_id id from project__schedule where project_id = ? and ("+cond+")", vals...)
-
 		if err != nil {
 			return
 		}
@@ -512,7 +501,6 @@ func (d *SqlDb) getObjectByReferrer(referrerID int, referringObjectProps db.Obje
 		Where("id=?", objectID).
 		Where(referringObjectProps.ReferringColumnSuffix+"=?", referrerID).
 		ToSql()
-
 	if err != nil {
 		return
 	}
@@ -529,7 +517,7 @@ func (d *SqlDb) getObjectsByReferrer(
 	params db.RetrieveQueryParams,
 	objects interface{},
 ) (err error) {
-	var referringColumn = referringObjectProps.ReferringColumnSuffix
+	referringColumn := referringObjectProps.ReferringColumnSuffix
 
 	columns := []string{"*"}
 	if len(props.SelectColumns) > 0 {
@@ -545,13 +533,11 @@ func (d *SqlDb) getObjectsByReferrer(
 	}
 
 	q, err = getQueryForParams(q, "pe.", props, params)
-
 	if err != nil {
 		return
 	}
 
 	query, args, err := q.ToSql()
-
 	if err != nil {
 		return
 	}
@@ -562,7 +548,7 @@ func (d *SqlDb) getObjectsByReferrer(
 }
 
 func (d *SqlDb) deleteByReferrer(referrerID int, referringObjectProps db.ObjectProps, props db.ObjectProps, objectID int) error {
-	var referringColumn = referringObjectProps.ReferringColumnSuffix
+	referringColumn := referringObjectProps.ReferringColumnSuffix
 
 	return validateMutationResult(
 		d.exec(
@@ -622,7 +608,6 @@ func (d *SqlDb) GetObject(props db.ObjectProps, ID int) (object interface{}, err
 		Where(squirrel.Eq{"t.id": ID}).
 		OrderBy("t.id").
 		ToSql()
-
 	if err != nil {
 		return
 	}
@@ -631,8 +616,8 @@ func (d *SqlDb) GetObject(props db.ObjectProps, ID int) (object interface{}, err
 	return
 }
 
-func (d *SqlDb) CreateObject(props db.ObjectProps, object interface{}) (newObject interface{}, err error) {
-	//err = newObject.Validate()
+func (d *SqlDb) CreateObject(props db.ObjectProps, object any) (newObject any, err error) {
+	// err = newObject.Validate()
 
 	if err != nil {
 		return
@@ -642,7 +627,6 @@ func (d *SqlDb) CreateObject(props db.ObjectProps, object interface{}) (newObjec
 	insertID, err := d.insert(
 		"id",
 		"insert into "+props.TableName+" "+template, args...)
-
 	if err != nil {
 		return
 	}
@@ -662,15 +646,13 @@ func (d *SqlDb) GetObjectsByForeignKeyQuery(props db.ObjectProps, foreignID int,
 		Where(foreignProps.ReferringColumnSuffix+"=?", foreignID)
 
 	q, err = getQueryForParams(q, "t.", props, params)
-
 	if err != nil {
 		return
 	}
 
 	query, args, err := q.
 		OrderBy("t.id").
 		ToSql()
-
 	if err != nil {
 		return
 	}
@@ -685,7 +667,6 @@ func (d *SqlDb) GetAllObjectsByForeignKey(props db.ObjectProps, foreignID int, f
 		Where(foreignProps.ReferringColumnSuffix+"=?", foreignID).
 		OrderBy("t.id").
 		ToSql()
-
 	if err != nil {
 		return
 	}
@@ -700,15 +681,13 @@ func (d *SqlDb) GetAllObjects(props db.ObjectProps) (objects interface{}, err er
 		From(props.TableName + " as t").
 		OrderBy("t.id").
 		ToSql()
-
 	if err != nil {
 		return
 	}
 	var results []interface{}
 	results, err = d.selectAll(&objects, query, args...)
 
 	return results, err
-
 }
 
 // Retrieve the Matchers & Values referencing `id' from WebhookExtractor
@@ -730,10 +709,9 @@ func (d *SqlDb) GetAllObjects(props db.ObjectProps) (objects interface{}, err er
 //	  "Matchers": db.WebhookMatcherProps,
 //	  "Values": db.WebhookExtractValueProps
 //	}, &referrerCollection)
-func (d *SqlDb) GetReferencesForForeignKey(objectProps db.ObjectProps, objectID int, referrerMapping map[string]db.ObjectProps, referrerCollection *interface{}) (err error) {
-
+func (d *SqlDb) GetReferencesForForeignKey(objectProps db.ObjectProps, objectID int, referrerMapping map[string]db.ObjectProps, referrerCollection *any) (err error) {
 	for key, value := range referrerMapping {
-		//v := reflect.ValueOf(referrerCollection)
+		// v := reflect.ValueOf(referrerCollection)
 		referrers, errRef := d.GetObjectReferences(objectProps, value, objectID)
 
 		if errRef != nil {
@@ -775,7 +753,6 @@ func (d *SqlDb) GetObjectReferences(objectProps db.ObjectProps, referringObjectP
 		referringObjects.Interface(),
 		"select id, name from "+referringObjectProps.TableName+" where "+objectProps.ReferringColumnSuffix+" = ? and "+cond,
 		vals...)
-
 	if err != nil {
 		return
 	}
@@ -790,7 +767,6 @@ func (d *SqlDb) GetObjectReferences(objectProps db.ObjectProps, referringObjectP
 }
 
 func (d *SqlDb) GetTaskStats(projectID int, templateID *int, unit db.TaskStatUnit, filter db.TaskFilter) (stats []db.TaskStat, err error) {
-
 	stats = make([]db.TaskStat, 0)
 
 	if unit != db.TaskStatUnitDay {
@@ -827,7 +803,6 @@ func (d *SqlDb) GetTaskStats(projectID int, templateID *int, unit db.TaskStatUni
 	}
 
 	query, args, err := q.ToSql()
-
 	if err != nil {
 		return
 	}

db_lib/AnsibleApp.go

@@ -16,7 +16,7 @@ func getMD5Hash(filepath string) (string, error) {
 	if err != nil {
 		return "", err
 	}
-	defer file.Close()
+	defer file.Close() //nolint:errcheck
 
 	hash := md5.New()
 	if _, err := io.Copy(hash, file); err != nil {
@@ -45,7 +45,7 @@ func writeMD5Hash(requirementsFile string, requirementsHashFile string) error {
 		return err
 	}
 
-	return os.WriteFile(requirementsHashFile, []byte(newFileMD5Hash), 0644)
+	return os.WriteFile(requirementsHashFile, []byte(newFileMD5Hash), 0o644)
 }
 
 type AnsibleApp struct {
@@ -91,7 +91,6 @@ func (t *AnsibleApp) getRepoPath() string {
 }
 
 func (t *AnsibleApp) installGalaxyRequirementsFile(requirementsType GalaxyRequirementsType, requirementsFilePath string) error {
-
 	requirementsHashFilePath := fmt.Sprintf("%s_%s.md5", requirementsFilePath, requirementsType)
 
 	if _, err := os.Stat(requirementsFilePath); err != nil {