fix: simplify issue closure on success

Author: tom-sapletta-com

.github/workflows/pyqual-ci.yml

@@ -363,8 +363,6 @@ jobs:
         python3 << 'EOF'
         import os
         import sys
-        import json
-        import re
         from pathlib import Path
         sys.path.insert(0, '.')
         
@@ -399,76 +397,51 @@ jobs:
             print(f"Could not calculate completion percentage: {e}")
             completion_pct = None
         
-        # Parse pyqual output for metrics and gates
+        # Parse pyqual output for a simple success signal.
         log_file = Path(".pyqual/pyqual_output.log")
         pyqual_output = log_file.read_text() if log_file.exists() else ""
-        
-        # Check if all gates passed
+
+        # Check if all gates passed.
         all_gates_passed = "all_gates_passed: true" in pyqual_output or "result: all_gates_passed" in pyqual_output
-        
-        # Extract metrics from output
-        coverage_match = re.search(r'coverage:\s*(\d+)', pyqual_output)
-        cc_match = re.search(r'cc:\s*(\d+\.?\d*)', pyqual_output)
-        vallm_match = re.search(r'vallm_pass:\s*(\d+\.?\d*)', pyqual_output)
-        
-        coverage = float(coverage_match.group(1)) if coverage_match else None
-        cc = float(cc_match.group(1)) if cc_match else None
-        vallm = float(vallm_match.group(1)) if vallm_match else None
-        
-        # Check test results from log
-        tests_passed = "failed: 0" in pyqual_output or "passed:" in pyqual_output and "failed:" not in pyqual_output
-        
-        # Check pyqual.yaml thresholds
-        coverage_ok = coverage >= 55 if coverage else False
-        cc_ok = cc <= 15 if cc else False
-        vallm_ok = vallm >= 90 if vallm else False
-        
-        # Determine if we can close the issue
-        can_close = all_gates_passed and coverage_ok and cc_ok and vallm_ok and tests_passed
-        
-        print(f"Quality Gates Check:")
+
+        # The workflow only reaches this step when `pyqual run` exited 0.
+        # Use the successful pipeline result as the close signal.
+        can_close = all_gates_passed
+
+        print("Quality Gates Check:")
         print(f"  all_gates_passed: {all_gates_passed}")
-        print(f"  coverage: {coverage}% (threshold: 55%) - {'✓' if coverage_ok else '✗'}")
-        print(f"  cc: {cc} (threshold: 15) - {'✓' if cc_ok else '✗'}")
-        print(f"  vallm_pass: {vallm}% (threshold: 90%) - {'✓' if vallm_ok else '✗'}")
-        print(f"  tests_passed: {tests_passed}")
         print(f"  can_close_issue: {can_close}")
-        
-        # Check if changes were made
+
+        # Check if changes were made.
         import subprocess
         result = subprocess.run(["git", "status", "--porcelain"], capture_output=True, text=True)
         changes = result.stdout.strip()
-        
+
         if can_close:
+            sha = os.environ.get('GITHUB_SHA', 'unknown')[:8]
+            pct_str = f"{completion_pct:.1f}%" if completion_pct else "N/A"
+
             if changes:
-                sha = os.environ.get('GITHUB_SHA', 'unknown')[:8]
-                pct_str = f"{completion_pct:.1f}%" if completion_pct else "N/A"
                 body = "## ✅ Task completed successfully\n\n"
                 body += f"**Completion: {pct_str}**\n\n"
-                body += "All quality gates passed:\n"
-                body += f"- **Test coverage:** {coverage}% (≥55%)\n"
-                body += f"- **Cyclomatic complexity:** {cc} (≤15)\n"
-                body += f"- **VALLM pass rate:** {vallm}% (≥90%)\n"
-                body += f"- **All tests:** passed\n\n"
+                body += "All quality gates passed and changes have been made.\n\n"
                 body += "Changes have been made and pushed to the repository.\n\n"
                 body += "### Files Modified\n<details>\n<summary>Click to see changes</summary>\n\n```\n"
                 body += changes[:2000]
                 body += f"\n```\n</details>\n\n"
                 body += "---\n"
                 body += "_Closing this issue as all requirements are met ✓_"
             else:
-                body = "## ℹ️ No changes required\n\n"
-                body += "The pipeline ran successfully. All quality gates passed:\n"
-                body += f"- **Test coverage:** {coverage}% (≥55%)\n"
-                body += f"- **Cyclomatic complexity:** {cc} (≤15)\n"
-                body += f"- **VALLM pass rate:** {vallm}% (≥90%)\n\n"
+                body = "## ✅ Task completed successfully\n\n"
+                body += f"**Completion: {pct_str}**\n\n"
+                body += "The pipeline ran successfully and all quality gates passed.\n\n"
                 body += "---\n"
                 body += "_Closing this issue as requirements are already met ✓_"
-            
-            # Post success comment
+
+            # Post success comment.
             reporter.post_issue_comment(body, int(issue_number))
-            
-            # Close the issue
+
+            # Close the issue.
             if reporter.token and reporter.repo:
                 import subprocess
                 close_cmd = [
@@ -486,19 +459,16 @@ jobs:
                 else:
                     print(f"✗ Failed to close issue: {result.stderr[:200]}")
         else:
-            # Don't close - post status update with completion percentage
+            # Don't close - post status update with completion percentage.
             sha = os.environ.get('GITHUB_SHA', 'unknown')[:8]
             pct_str = f"{completion_pct:.1f}%" if completion_pct else "N/A"
             body = f"## 📊 Quality Gates Status - {pct_str} Complete\n\n"
             body += "Pipeline completed but not all requirements met:\n\n"
             body += f"- **all_gates_passed:** {'✓' if all_gates_passed else '✗'}\n"
-            body += f"- **coverage:** {coverage}% {'✓' if coverage_ok else '✗ (need ≥55%)'}\n"
-            body += f"- **cc:** {cc} {'✓' if cc_ok else '✗ (need ≤15)'}\n" 
-            body += f"- **vallm_pass:** {vallm}% {'✓' if vallm_ok else '✗ (need ≥90%)'}\n"
-            body += f"- **tests:** {'✓ passed' if tests_passed else '✗ failed'}\n\n"
+            body += "- **pipeline:** completed, but manual review required\n\n"
             body += "Issue remains open - manual review required.\n\n"
             body += f"---\n_Processed at: {sha}_"
-            
+
             reporter.post_issue_comment(body, int(issue_number))
             print(f"✗ Issue #{issue_number} remains open - quality gates not fully met")