update docs for finding details v2 GA (#2200)

Author: khorne3

docs/contributing/contributing-rules.md

@@ -519,7 +519,7 @@ technology:
 
 #### Vulnerability class
 
-The vulnerability class defines the category to which a rule and its resulting findings belong. The categories are used to group rules in Semgrep AppSec Platform's **Policies** page to help find similar rules. The category is also displayed on the **Findings Details** pages.
+The vulnerability class defines the category to which a rule and its resulting findings belong. The categories are used to group rules in Semgrep AppSec Platform's **Policies** page to help find similar rules. The category is also displayed on the **Finding Details** pages.
 
 You can provide custom values. Sample values include:
 

docs/secure-guardrails/overview.md

@@ -123,7 +123,7 @@ Semgrep provides customizability through:
 - Custom rules - You can create custom rules and deploy them as guardrails. Learn more about Semgrep rule structure in [the next section](#remediation-guidance).
 - Assistant Memories - this feature allows you to add and save additional context when Semgrep Assistant provides remediation. For example, you can provide organization-specific public keys, which Semgrep Assistant remembers.
 
-![Assistant Memories form within a finding's details page](/img/guardrails-memories.png#md-width-centered)
+![Assistant Memories form within a finding's details page](/img/memories-2.png#md-width-centered)
 _**Figure**. A form on a finding's details page where you can enter additional instructions or context._
 
 ### Remediation guidance

docs/semgrep-appsec-platform/findings-details.md

@@ -1,7 +1,8 @@
 ---
 displayed_sidebar: scanSidebar
 slug: details-page
-title: Details page v2
+id: details-page
+title: Finding details page v2
 hide_title: true
 description: Each finding in Semgrep has its own details page which provides you with the information and tools to analyze and triage the finding.
 tags:
@@ -11,7 +12,7 @@ tags:
 # Details page for findings v2
 
 :::info
-This document describes the **findings details page v2**, a feature which is in **private beta**. This feature supercedes the current findings details page, hereafter referred to as v1.
+This document describes the **findings details page v2**, a feature generally available as of 20 June 2025. This feature supercedes the earlier finding details page, hereafter referred to as v1.
 
 Refer to this document to understand changes between the two versions. 
 :::

docs/semgrep-appsec-platform/jira.md

@@ -80,7 +80,7 @@ The Jira integration automatically detects other Jira projects in your subdomain
 - Those projects have the same **Issue type** as the default project. [When you triage a finding](#code), you can choose which project to create the tickets in.
 
 :::caution Same name, different ID
-Issue types may have the same name, but a different Issue type ID. When creating tickets, only company-managed Jira projects with the same issue type ID as the default project selected in the integration will appear. If you can't select other Jira projects when creating tickets, check that the Issue type ID is the same across Jira projects. See the [<i class="fas fa-external-link fa-xs"></i> Jira documentation](https://confluence.atlassian.com/jirasoftwarecloud/finding-the-issue-type-id-in-jira-cloud-1333825937.html) for details.
+Issue types may have the same name, but a different Issue type ID. When creating tickets, only company-managed Jira projects with the same issue type ID as the default project selected in the integration will appear. If you can't select other Jira projects when creating tickets, check that the Issue type ID is the same across Jira projects. See the [<i class="fas fa-external-link fa-xs"></i> How to identify the Jira Issue ID in Cloud](https://support.atlassian.com/jira/kb/how-to-identify-the-jira-issue-id-in-cloud/) for details.
 :::
 
 ### Create mappings
@@ -220,7 +220,10 @@ _**Figure.** Code triage flow._
 Once a ticket has been created, a link appears on the **Findings** page and along the top of an individual finding's details page.
 
 ![Jira ticket created - Code](/img/jira-code-ticketed.png#md-width)
-_**Figure.** Code ticket created._
+_**Figure.** Ticket created and its ID shown on the finding listed on the Code page._
+
+![Jira ticket created - Finding Details](/img/jira-ticket-finding-details.png#md-width)
+_**Figure.** Ticket created and its ID shown on the finding details page._
 
 ### Supply Chain
 
@@ -279,11 +282,11 @@ Semgrep provides an API endpoint you can use to create Jira tickets, either by p
 
 1. Sign in to [Semgrep AppSec Platform](https://semgrep.dev/login).
 2. In the navigation bar, click the product whose findings you want to see.
-3. Identify the finding associated with the Jira ticket, and open its findings details page.
+3. Identify the finding associated with the Jira ticket, and open its finding details page.
 4. Click **Fix**, and in the drop-down box that appears, click **Unlink <PL>TICKET ID</PL>**.
 
-![The findings details page with the option to unlink a Jira ticket displayed.](/img/unlink-jira.png#md-width)
-_**Figure**. The findings details page with the option to unlink a Jira ticket displayed._
+![The finding details page with the option to unlink a Jira ticket displayed.](/img/unlink-jira.png#md-width)
+_**Figure**. The finding details page with the option to unlink a Jira ticket displayed._
 
 ## Remove the Jira integration
 

docs/semgrep-assistant/customize.md

@@ -63,15 +63,13 @@ Memories are enabled by default for all organizations with Assistant enabled.
 To add a memory based on a suggested fix presented by Assistant:
 
 1. Identify the specific instance of **Assistant's suggested fix** that you want to modify. These can be found on the finding details page or in the PR or MR comment.
-2. Click **Customize fix** to open an input box, and enter your preferred remediation approaches and secure defaults for the project. Your suggestion can be as general as "Use AWS Secrets Manager to manage secrets."
-   ![Assistant’s suggested fix for a hardcoded secret in the user’s code](/img/memories-3.png#md-width)
+   ![Assistant’s suggested fix for a hardcoded secret in the user’s code](/img/memories-1.png#md-width)
    ***Figure***. Assistant’s suggested fix for a hardcoded secret in the user’s code.
-3. Click **Save and regenerate**.
+2. Click **Customize fix** to open an input box, and enter your preferred remediation approaches and secure defaults for the project. Your suggestion can be as general as "Use AWS Secrets Manager to manage secrets."
    ![User-provided custom instruction that Assistant uses to improve future guidance.](/img/memories-2.png#md-width)
    ***Figure***. User-provided custom instruction that Assistant uses to improve future guidance.
+3. Click **Save and regenerate**.
 4. Assistant regenerates the suggested fix to reflect the instructions you provided.
-   ![Regenerated Assistant fix using the user-provided instructions.](/img/memories-1.png#md-width)
-   ***Figure***. Regenerated Assistant fix using the user-provided instructions.
 
 Memories are scoped to remediation guidance on a per-project and per-rule basis. A saved memory only affects future guidance for findings triggered by the same rule in the same project.
 

docs/semgrep-assistant/overview.md

@@ -44,7 +44,7 @@ _**Figure.** PR comment displaying the rule message followed by a comment that c
 
 Semgrep also displays remediation information on Semgrep AppSec Platform's **Findings page** under **Your code & fix** in the [finding's details](/docs/semgrep-code/findings/#view-findings-details-about-a-specific-finding) page.
 
-![Findings detail with remediation advice](/img/assistant-guidance-ui.png#md-width)
+![Findings detail with remediation advice](/img/memories-1.png#md-width)
 _**Figure.** Findings detail page with the Your code & fix section displaying the suggested fix._
 
 #### Autofix
@@ -58,13 +58,11 @@ Autofixes are available in PR and MR comments, so developers can review and veri
 ![Semgrep Assistant generating a potential fix in a comment](/img/semgrep-assistant-autofix.png#md-width)
 _**Figure.** Semgrep Assistant generates a potential fix in a PR comment._
 
-Autofixes are also available on Semgrep AppSec Platform's **Findings page** under **Your code & fix** in the [finding's details](/docs/semgrep-code/findings/#view-findings-details-about-a-specific-finding).
+Autofixes are also available on Semgrep AppSec Platform's **Findings page** under **Assistant suggested fix** in the [finding's details](/docs/semgrep-code/findings/#view-findings-details-about-a-specific-finding).
 
 ![Semgrep Assistant showing a potential fix in Semgrep AppSec Platform](/img/assistant-autofix-ui.png#md-width)
 *Figure*. Semgrep Assistant showing a potential fix in Semgrep AppSec Platform.
 
-The finding's details include a link to the PR or MR with the autofix, so you can go directly to the PR or MR to commit the autofix.
-
 :::info
 If many new issues are found in a given scan, Assistant auto-triage and autofix may not run on every issue.
 :::

docs/semgrep-code/findings.md

@@ -123,32 +123,26 @@ You can identify findings categorized under **Security** by their badge.
 ![Screenshot of security badge](/img/findings-security-badge.png#md-width)
 :::
 
-### View findings details about a specific finding
+### View details about a specific finding
 
 To view in-depth information about a specific finding:
 
-1. Select the finding whose details you want to view details:
+1. Select the finding whose details you want to view:
     - If the default **Group by Rule** is enabled, click the <i class="fa-regular fa-window-restore"></i> **Details** icon on the card of the finding.
         ![Click View details if Group by Rule is enabled](/img/cloud-platform-findings-group-by-rule-view-details.png#md-width)
-    - If the **No grouping** view is enabled, click the **header hyperlink** on the card of the finding. In the example on the screenshot below, it is the **detected-generic-api-key**.
+    - If the **No grouping** view is enabled, click the **header hyperlink** on the card of the finding. In the example screenshot below, the link is labeled **detected-generic-api-key**.
         ![Click View details if No grouping is enabled](/img/cloud-platform-findings-no-grouping-view-details.png#md-width)
+
 #### Add notes to findings
 
 To **add notes** to the activity history of a finding:
 
 1. Select a finding where you want to view details or add notes, and then do one of the following actions:
     - If the default **Group by Rule** is enabled, click <i class="fa-regular fa-window-restore"></i> **Details** icon on the card of the finding.
         ![Click View details if Group by Rule is enabled](/img/cloud-platform-findings-group-by-rule-view-details.png#md-width)
-    - If **No grouping** view is enabled, click the **header hyperlink** on the card of the finding. In the example on the screenshot below, it is the **detected-generic-api-key**.
+    - If **No grouping** view is enabled, click the **header hyperlink** on the card of the finding. In the example screenshot below, the link is labeled **detected-generic-api-key**.
         ![Click View details if No grouping is enabled](/img/cloud-platform-findings-no-grouping-view-details.png#md-width)
-2. View, or add the notes in the **Activity** section. To add a new note, click plus **New note**.
-    ![Semgrep AppSec Platform finding details page](/img/cloud-platform-finding-details.png#md-width)
-### View branches that contain the finding
-
-To view all the branches that contain the finding, click the finding's **details page**. You can see all the branches on the **On <span className="placeholder">N</span> branches** pane.
-
-![Details page > On N branches](/img/details-on-n-branches.png#sm-width)
-_**Figure**. **Details page > On <span className="placeholder">N</span> branches** pane._
+2. View or add the notes in the **Activity** section. To add a new note, click **New note**.
 
 ## Dataflow traces
 

sidebars.js

@@ -88,7 +88,15 @@ module.exports = {
             items: [
                 'deployment/deployment-checklist',
                 'deployment/create-account-and-orgs',
-                'deployment/connect-scm',
+                {
+                    type: 'category',
+                    collapsible: true,
+                    label: 'Connect a source code manager',
+                    link: {type: 'doc', id: 'deployment/connect-scm'},
+                    items: [
+                      'semgrep-appsec-platform/scm-code-access'
+                    ]
+                },
                 /* 'semgrep-cloud-platform/scm', superseded by connect-scm */
                 'deployment/sso',
                 {
@@ -259,6 +267,15 @@ module.exports = {
             items: [
                 'semgrep-code/overview',
                 'semgrep-code/findings',
+                {
+                    type: 'category',
+                    collapsible: true,
+                    label: 'View findings',
+                    link: {type: 'doc', id: 'semgrep-code/findings',},
+                    items: [
+                      'semgrep-appsec-platform/details-page',
+                    ]
+                },
                 'semgrep-code/policies',
                 'semgrep-code/triage-remediation',
                 'semgrep-code/semgrep-pro-engine-intro',
@@ -403,8 +420,7 @@ module.exports = {
             ]
         },
         'cli-reference',
-        'semgrep-appsec-platform/json-and-sarif',
-        'semgrep-appsec-platform/scm-code-access'
+        'semgrep-appsec-platform/json-and-sarif'
       ]
     }
   ],

src/components/procedure/_integrate-slack.mdx

@@ -8,7 +8,7 @@ To view the detailed path of tainted data with dataflow traces:
 1. Select the finding you're interested in, then do one of the following actions:
    - If the default **Group by Rule** is enabled, click <i class="fa-regular fa-window-restore"></i> **View details** icon on the card of the finding.
      ![Click View details if Group by Rule is enabled](/img/cloud-platform-findings-group-by-rule-view-details.png#md-width)
-   - If **No grouping** view is enabled, click the **header hyperlink** on the card of the finding. In the example on the screenshot below, it is the **tainted-sql-string**.
+   - If **No grouping** view is enabled, click the **header hyperlink** on the card of the finding. In the example screenshot below, the link is titled **tainted-sql-string**.
      ![Click View details if No grouping is enabled](/img/cloud-platform-findings-no-grouping-view-details.png#md-width)
 1. In the <i class="fa-solid fa-droplet"></i> **Data flow** <i class="fa-regular fa-circle-info"></i> section, you can see the source, traces, and sink of the tainted data. The example below displays the path of tainted data across multiple files because Semgrep Pro Engine was enabled. Clicking on a specific line in the trace will highlight it in the context of the file, while clicking on the file name at the top of the right pane will take you directly to that file in your source code manager (GitHub, GitLab, etc.). If you don't have code access enabled, you'll still see the link to your source code manager.
    ![Data flow in Finding details page](/img/cloud-platform-findings-details-data-flow.png#md-width)