Skip to content

Commit 2af6bbf

Browse files
authored
Make parameters to subproject symbol analysis url request optional (#431)
We want the two fields to `subproject_symbol_analysis_url_request` to be optional rather than encoded as an ADT. - [x] I ran `make setup && make` to update the generated code after editing a `.atd` file (TODO: have a CI check) - [x] I made sure we're still backward compatible with old versions of the CLI. For example, the Semgrep backend need to still be able to *consume* data generated by Semgrep 1.50.0. See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades Note that the types related to the semgrep-core JSON output or the semgrep-core RPC do not need to be backward compatible! - [x] Any accompanying changes in `semgrep-proprietary` are approved and ready to merge once this PR is merged
1 parent 5184a33 commit 2af6bbf

File tree

6 files changed

+82
-92
lines changed

6 files changed

+82
-92
lines changed

semgrep_output_v1.atd

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3375,8 +3375,8 @@ type upload_subproject_symbol_analysis_params = {
33753375
type subproject_symbol_analysis_url_request
33763376
<doc text="Sent by the CLI to the POST /api/agent/scans/{scan_id}/subproject_symbols_upload_url/">
33773377
= {
3378-
manifest_path: fpath option;
3379-
lockfile_path: fpath option;
3378+
?manifest_path: fpath option;
3379+
?lockfile_path: fpath option;
33803380
}
33813381

33823382
(* ----------------------------- *)

semgrep_output_v1.jsonschema

Lines changed: 3 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

semgrep_output_v1.proto

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

semgrep_output_v1.py

Lines changed: 8 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

semgrep_output_v1.ts

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

semgrep_output_v1_j.ml

Lines changed: 60 additions & 48 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)