Commit 8a8abc7
authored
feat: add skipped_paths field to ci_scan_results (#427)
## Summary
Add optional `skipped_paths` field to the `ci_scan_results` type to
communicate which files were detected but couldn't be scanned due to
errors (timeout, OOM, stack overflow, etc.).
This allows the app to avoid marking findings in these files as "fixed"
when they weren't actually scanned.
## Changes
- Added `?skipped_paths` field to `ci_scan_results` in
`semgrep_output_v1.atd`
- Regenerated all derived files (Python, OCaml, JSON Schema, Proto, ...)
## Backwards Compatibility
- Field is optional (`?` prefix), so existing consumers will still work
- Field is omitted from JSON when None/empty
---
- [x] I ran `make setup && make` to update the generated code after
editing a `.atd` file (TODO: have a CI check)
- [x] I made sure we're still backward compatible with old versions of
the CLI.
For example, the Semgrep backend need to still be able to *consume* data
generated by Semgrep 1.50.0.
See
https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
Note that the types related to the semgrep-core JSON output or the
semgrep-core RPC do not need to be backward compatible!
- [x] Any accompanying changes in `semgrep-proprietary` are approved and
ready to merge once this PR is merged1 parent e5da967 commit 8a8abc7
9 files changed
+115
-20
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2031 | 2031 | | |
2032 | 2032 | | |
2033 | 2033 | | |
2034 | | - | |
| 2034 | + | |
| 2035 | + | |
| 2036 | + | |
2035 | 2037 | | |
| 2038 | + | |
2036 | 2039 | | |
2037 | 2040 | | |
2038 | 2041 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments