Commit dbdfe41
committed
feat(sca): add unresolved reason and errors to subproject stats (#356)
In https://github.com/semgrep/semgrep-proprietary/pull/2872, we updated
the SCA subproject logic to scan only changed subprojects in diff scans.
Subprojects that remained unchanged were intentionally left unresolved
with the reason UnresolvedSkipped.
Previously, we didn't include this information in our subproject stats,
leaving us without visibility into why a subproject was unresolved. This
PR introduces two optional fields, unresolved_reason and errors,
allowing us to capture more granular stats and better understand
subproject resolution failures.
- [x] I ran `make setup && make` to update the generated code after
editing a `.atd` file (TODO: have a CI check)
- [x] I made sure we're still backward compatible with old versions of
the CLI.
For example, the Semgrep backend need to still be able to *consume* data
generated by Semgrep 1.50.0.
See
https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
Note that the types related to the semgrep-core JSON output or the
semgrep-core RPC do not need to be backward compatible!1 parent 2750a92 commit dbdfe41
1 file changed
+4
-0
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments