Merge pull request #289 from semiotic-ai/suchapalaver/remove-unused-draft-benchmark-work

chore(eip712): remove draft benchmark code w/ verify method

Author: suchapalaver

tap_core/Cargo.toml

@@ -28,7 +28,3 @@ thegraph-core = { workspace = true, features = ["alloy-signer-mnemonic"] }
 [features]
 default = ["in_memory"]
 in_memory = ["dep:tap_graph"]
-
-[[bench]]
-name = 'timeline_aggretion_protocol_benchmark'
-harness = false

tap_core/benches/timeline_aggretion_protocol_benchmark.rs

@@ -163,27 +163,4 @@ mod tap_tests {
 
         assert!(signed_rav.recover_signer(&domain_separator).unwrap() == keys.1);
     }
-
-    #[rstest]
-    #[test]
-    fn verify_signature(
-        keys: (PrivateKeySigner, Address),
-        allocation_ids: Vec<Address>,
-        domain_separator: Eip712Domain,
-    ) {
-        let signed_message = Eip712SignedMessage::new(
-            &domain_separator,
-            Receipt::new(allocation_ids[0], 42).unwrap(),
-            &keys.0,
-        )
-        .unwrap();
-
-        assert!(signed_message.verify(&domain_separator, keys.1).is_ok());
-        assert!(signed_message
-            .verify(
-                &domain_separator,
-                Address::from_str("0x76f4eeD9fE41262669D0250b2A97db79712aD855").unwrap()
-            )
-            .unwrap());
-    }
 }

tap_core/src/lib.rs

@@ -105,22 +105,6 @@ impl<M: SolStruct> Eip712SignedMessage<M> {
         Ok(recovered_address)
     }
 
-    /// Checks that receipts signature is valid for given verifying key, returns `Ok(true)` if it is valid.
-    ///
-    /// # Errors
-    ///
-    /// Returns [`crate::Error::SignatureError`] if the recovered address from the
-    /// signature is not equal to `expected_address`
-    ///
-    pub fn verify(
-        &self,
-        domain_separator: &Eip712Domain,
-        expected_address: Address,
-    ) -> Result<bool, Eip712Error> {
-        let recovered_address = self.recover_signer(domain_separator)?;
-        Ok(recovered_address != expected_address)
-    }
-
     /// Use this as a simple key for testing
     pub fn unique_hash(&self) -> MessageId {
         MessageId(self.message.eip712_hash_struct().into())