refactor!: rename RAVRequest with RavRequest

Signed-off-by: Gustavo Inacio <[email protected]>

Author: gusinacio

tap_aggregator/src/aggregator.rs

@@ -44,7 +44,7 @@ pub fn check_and_aggregate_receipts(
     // Get the allocation id from the first receipt, return error if there are no receipts
     let allocation_id = match receipts.first() {
         Some(receipt) => receipt.message.allocation_id,
-        None => return Err(tap_core::Error::NoValidReceiptsForRAVRequest.into()),
+        None => return Err(tap_core::Error::NoValidReceiptsForRavRequest.into()),
     };
 
     // Check that the receipts all have the same allocation id

tap_core/src/error.rs

@@ -46,7 +46,7 @@ pub enum Error {
     AdapterError { source_error: anyhow::Error },
     /// Error when no valid receipts are found for a RAV request
     #[error("Failed to produce rav request, no valid receipts")]
-    NoValidReceiptsForRAVRequest,
+    NoValidReceiptsForRavRequest,
 
     /// Error when the previous RAV allocation id does not match the allocation id from the new receipt
     #[error("Previous RAV allocation id ({prev_id}) doesn't match the allocation id from the new receipt ({new_id}).")]

tap_core/src/manager/tap_manager.rs

@@ -7,7 +7,7 @@ use super::adapters::{
     RAVRead, RAVStore, ReceiptDelete, ReceiptRead, ReceiptStore, SignatureChecker,
 };
 use crate::{
-    rav::{RAVRequest, ReceiptAggregateVoucher, SignedRAV},
+    rav::{RavRequest, ReceiptAggregateVoucher, SignedRAV},
     receipt::{
         checks::{CheckBatch, CheckList, TimestampCheck, UniqueCheck},
         state::{Checked, Failed},
@@ -188,7 +188,7 @@ where
         ctx: &Context,
         timestamp_buffer_ns: u64,
         receipts_limit: Option<u64>,
-    ) -> Result<RAVRequest<SignedReceipt>, Error> {
+    ) -> Result<RavRequest<SignedReceipt>, Error> {
         let previous_rav = self.get_previous_rav().await?;
         let min_timestamp_ns = previous_rav
             .as_ref()
@@ -201,7 +201,7 @@ where
 
         let expected_rav = Self::generate_expected_rav(&valid_receipts, previous_rav.clone());
 
-        Ok(RAVRequest {
+        Ok(RavRequest {
             valid_receipts,
             previous_rav,
             invalid_receipts,
@@ -214,7 +214,7 @@ where
         previous_rav: Option<SignedRAV>,
     ) -> Result<ReceiptAggregateVoucher, Error> {
         if receipts.is_empty() {
-            return Err(Error::NoValidReceiptsForRAVRequest);
+            return Err(Error::NoValidReceiptsForRavRequest);
         }
         let allocation_id = receipts[0].signed_receipt().message.allocation_id;
         let receipts = receipts

tap_core/src/rav.rs

@@ -48,7 +48,7 @@ use crate::{receipt::Receipt, signed_message::EIP712SignedMessage, Error};
 
 /// EIP712 signed message for ReceiptAggregateVoucher
 pub type SignedRAV = EIP712SignedMessage<ReceiptAggregateVoucher>;
-pub use request::RAVRequest;
+pub use request::RavRequest;
 
 sol! {
     /// Holds information needed for promise of payment signed with ECDSA

tap_core/src/rav/request.rs

@@ -12,7 +12,7 @@ use crate::{
 
 /// Request to `tap_aggregator` to aggregate receipts into a Signed RAV.
 #[derive(Debug)]
-pub struct RAVRequest<Rcpt> {
+pub struct RavRequest<Rcpt> {
     /// List of checked and reserved receipts to aggregate
     pub valid_receipts: Vec<ReceiptWithState<Checked, Rcpt>>,
     /// Optional previous RAV to aggregate with