refactor!: rename RAVStore and RAVRead to RavStore and RavRead

Signed-off-by: Gustavo Inacio <[email protected]>

Author: gusinacio

tap_core/src/manager/adapters/rav.rs

@@ -13,7 +13,7 @@ use crate::signed_message::EIP712SignedMessage;
 /// For example code see [crate::manager::context::memory::RAVStorage]
 
 #[async_trait]
-pub trait RAVStore<T: SolStruct> {
+pub trait RavStore<T: SolStruct> {
     /// Defines the user-specified error type.
     ///
     /// This error type should implement the `Error` and `Debug` traits from
@@ -36,7 +36,7 @@ pub trait RAVStore<T: SolStruct> {
 /// For example code see [crate::manager::context::memory::RAVStorage]
 
 #[async_trait]
-pub trait RAVRead<T: SolStruct> {
+pub trait RavRead<T: SolStruct> {
     /// Defines the user-specified error type.
     ///
     /// This error type should implement the `Error` and `Debug` traits from

tap_core/src/manager/context/memory.rs

@@ -125,7 +125,7 @@ impl InMemoryContext {
 }
 
 #[async_trait]
-impl RAVStore<ReceiptAggregateVoucher> for InMemoryContext {
+impl RavStore<ReceiptAggregateVoucher> for InMemoryContext {
     type AdapterError = InMemoryError;
 
     async fn update_last_rav(&self, rav: SignedRAV) -> Result<(), Self::AdapterError> {
@@ -138,7 +138,7 @@ impl RAVStore<ReceiptAggregateVoucher> for InMemoryContext {
 }
 
 #[async_trait]
-impl RAVRead<ReceiptAggregateVoucher> for InMemoryContext {
+impl RavRead<ReceiptAggregateVoucher> for InMemoryContext {
     type AdapterError = InMemoryError;
 
     async fn last_rav(&self) -> Result<Option<SignedRAV>, Self::AdapterError> {

tap_core/src/manager/tap_manager.rs

@@ -6,7 +6,7 @@ use std::marker::PhantomData;
 use alloy::{dyn_abi::Eip712Domain, sol_types::SolStruct};
 
 use super::adapters::{
-    RAVRead, RAVStore, ReceiptDelete, ReceiptRead, ReceiptStore, SignatureChecker,
+    RavRead, RavStore, ReceiptDelete, ReceiptRead, ReceiptStore, SignatureChecker,
 };
 use crate::{
     rav::{Aggregate, RavRequest},
@@ -54,7 +54,7 @@ impl<E, Rcpt, Rav> Manager<E, Rcpt, Rav> {
 
 impl<E, Rcpt, Rav> Manager<E, Rcpt, Rav>
 where
-    E: RAVStore<Rav> + SignatureChecker,
+    E: RavStore<Rav> + SignatureChecker,
     Rav: SolStruct + PartialEq<Rav> + Sync + std::fmt::Debug,
 {
     /// Verify `signed_rav` matches all values on `expected_rav`, and that `signed_rav` has a valid signer.
@@ -92,7 +92,7 @@ where
 
 impl<E, Rcpt, Rav> Manager<E, Rcpt, Rav>
 where
-    E: RAVRead<Rav>,
+    E: RavRead<Rav>,
     Rav: SolStruct,
 {
     async fn get_previous_rav(&self) -> Result<Option<EIP712SignedMessage<Rav>>, Error> {
@@ -171,7 +171,7 @@ where
 
 impl<E, Rcpt, Rav> Manager<E, Rcpt, Rav>
 where
-    E: ReceiptRead<Rcpt> + RAVRead<Rav> + SignatureChecker,
+    E: ReceiptRead<Rcpt> + RavRead<Rav> + SignatureChecker,
     Rav: SolStruct + WithValueAndTimestamp + Clone + Aggregate<Rcpt>,
     Rcpt: WithUniqueId + WithValueAndTimestamp + Sync,
 {
@@ -219,7 +219,7 @@ where
 
 impl<E, Rcpt, Rav> Manager<E, Rcpt, Rav>
 where
-    E: ReceiptDelete + RAVRead<Rav>,
+    E: ReceiptDelete + RavRead<Rav>,
     Rav: SolStruct + WithValueAndTimestamp,
 {
     /// Removes obsolete receipts from storage. Obsolete receipts are receipts

tap_core/tests/rav_test.rs

@@ -16,7 +16,7 @@ use alloy::{
 use rstest::*;
 use tap_core::{
     manager::{
-        adapters::{RAVRead, RAVStore},
+        adapters::{RavRead, RavStore},
         context::memory::InMemoryContext,
     },
     rav::ReceiptAggregateVoucher,

tap_integration_tests/tests/indexer_mock.rs

@@ -18,7 +18,7 @@ use jsonrpsee_core::client::ClientT;
 use tap_aggregator::jsonrpsee_helpers;
 use tap_core::{
     manager::{
-        adapters::{RAVRead, RAVStore, ReceiptRead, ReceiptStore, SignatureChecker},
+        adapters::{RavRead, RavStore, ReceiptRead, ReceiptStore, SignatureChecker},
         Manager,
     },
     rav::{ReceiptAggregateVoucher, SignedRAV},
@@ -86,8 +86,8 @@ impl<E> RpcServer for RpcManager<E>
 where
     E: ReceiptStore<SignedReceipt>
         + ReceiptRead<SignedReceipt>
-        + RAVStore<ReceiptAggregateVoucher>
-        + RAVRead<ReceiptAggregateVoucher>
+        + RavStore<ReceiptAggregateVoucher>
+        + RavRead<ReceiptAggregateVoucher>
         + SignatureChecker
         + Send
         + Sync
@@ -153,8 +153,8 @@ pub async fn run_server<E>(
 where
     E: ReceiptStore<SignedReceipt>
         + ReceiptRead<SignedReceipt>
-        + RAVStore<ReceiptAggregateVoucher>
-        + RAVRead<ReceiptAggregateVoucher>
+        + RavStore<ReceiptAggregateVoucher>
+        + RavRead<ReceiptAggregateVoucher>
         + SignatureChecker
         + Clone
         + Send
@@ -191,8 +191,8 @@ async fn request_rav<E>(
 ) -> Result<()>
 where
     E: ReceiptRead<SignedReceipt>
-        + RAVRead<ReceiptAggregateVoucher>
-        + RAVStore<ReceiptAggregateVoucher>
+        + RavRead<ReceiptAggregateVoucher>
+        + RavStore<ReceiptAggregateVoucher>
         + SignatureChecker,
 {
     // Create the aggregate_receipts request params