refactor: rename escrow handler to signature checker

Signed-off-by: Gustavo Inacio <[email protected]>

Author: gusinacio

tap_core/src/manager/adapters/mod.rs

@@ -8,10 +8,10 @@
 //! allows for easy integration with various storage solutions and verification
 //! procedures, thereby making the library adaptable to a wide range of use cases.
 
-mod escrow;
+mod signature;
 mod rav;
 mod receipt;
 
-pub use escrow::EscrowHandler;
+pub use signature::SignatureChecker;
 pub use rav::*;
 pub use receipt::*;

tap_core/src/manager/adapters/escrow.rs renamed to tap_core/src/manager/adapters/signature.rs

@@ -13,7 +13,7 @@ use crate::{signed_message::EIP712SignedMessage, Error};
 /// For example code see [crate::manager::context::memory::EscrowStorage]
 
 #[async_trait]
-pub trait EscrowHandler: Send + Sync {
+pub trait SignatureChecker: Send + Sync {
     /// Defines the user-specified error type.
     ///
     /// This error type should implement the `Error` and `Debug` traits from

tap_core/src/manager/context/memory.rs

@@ -241,7 +241,7 @@ impl InMemoryContext {
 }
 
 #[async_trait]
-impl EscrowHandler for InMemoryContext {
+impl SignatureChecker for InMemoryContext {
     type AdapterError = InMemoryError;
 
     async fn verify_signer(&self, signer_address: Address) -> Result<bool, Self::AdapterError> {

tap_core/src/manager/tap_manager.rs

@@ -3,7 +3,7 @@
 
 use alloy::dyn_abi::Eip712Domain;
 
-use super::adapters::{EscrowHandler, RAVRead, RAVStore, ReceiptDelete, ReceiptRead, ReceiptStore};
+use super::adapters::{SignatureChecker, RAVRead, RAVStore, ReceiptDelete, ReceiptRead, ReceiptStore};
 use crate::{
     rav::{RAVRequest, ReceiptAggregateVoucher, SignedRAV},
     receipt::{
@@ -42,7 +42,7 @@ impl<E> Manager<E> {
 
 impl<E> Manager<E>
 where
-    E: RAVStore + EscrowHandler,
+    E: RAVStore + SignatureChecker,
 {
     /// Verify `signed_rav` matches all values on `expected_rav`, and that `signed_rav` has a valid signer.
     ///
@@ -95,7 +95,7 @@ where
 
 impl<E> Manager<E>
 where
-    E: ReceiptRead + EscrowHandler,
+    E: ReceiptRead + SignatureChecker,
 {
     async fn collect_receipts(
         &self,
@@ -156,7 +156,7 @@ where
 
 impl<E> Manager<E>
 where
-    E: ReceiptRead + RAVRead + EscrowHandler,
+    E: ReceiptRead + RAVRead + SignatureChecker,
 {
     /// Completes remaining checks on all receipts up to
     /// (current time - `timestamp_buffer_ns`). Returns them in two lists

tap_integration_tests/tests/indexer_mock.rs

@@ -17,7 +17,7 @@ use jsonrpsee::{
 use tap_aggregator::jsonrpsee_helpers;
 use tap_core::{
     manager::{
-        adapters::{EscrowHandler, RAVRead, RAVStore, ReceiptRead, ReceiptStore},
+        adapters::{SignatureChecker, RAVRead, RAVStore, ReceiptRead, ReceiptStore},
         Manager,
     },
     rav::SignedRAV,
@@ -83,7 +83,7 @@ where
 #[async_trait]
 impl<E> RpcServer for RpcManager<E>
 where
-    E: ReceiptStore + ReceiptRead + RAVStore + RAVRead + EscrowHandler + Send + Sync + 'static,
+    E: ReceiptStore + ReceiptRead + RAVStore + RAVRead + SignatureChecker + Send + Sync + 'static,
 {
     async fn request(
         &self,
@@ -147,7 +147,7 @@ where
         + ReceiptRead
         + RAVStore
         + RAVRead
-        + EscrowHandler
+        + SignatureChecker
         + Clone
         + Send
         + Sync
@@ -182,7 +182,7 @@ async fn request_rav<E>(
     threshold: usize,
 ) -> Result<()>
 where
-    E: ReceiptRead + RAVRead + RAVStore + EscrowHandler,
+    E: ReceiptRead + RAVRead + RAVStore + SignatureChecker,
 {
     // Create the aggregate_receipts request params
     let rav_request = manager