build: centralize dependency imports in workspace manifest #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suchapalaver
force-pushed
the
suchapalaver/dependency-maintenance
branch
from
ebaadfd to
3395fff
Compare
suchapalaver
requested review from
TypeLevelConsoli and
neithanmo
as code owners
Pull Request Test Coverage Report for Build 14540987718Details
💛 - Coveralls |
TypeLevelConsoli
previously approved these changes
Apr 17, 2025
TypeLevelConsoli
left a comment
TypeLevelConsoli
left a comment
There was a problem hiding this comment.
Great, thanks for organizing this!
Not a request for changes as it's mostly glitter, but while we're doing this, can we also sort the deps?
https://github.com/DevinR528/cargo-sort may help (I never used it, but it looks reasonably maintained)
suchapalaver
force-pushed
the
suchapalaver/dependency-maintenance
branch
2 times, most recently
from
f982c05 to
4284831
Compare
suchapalaver
force-pushed
the
suchapalaver/dependency-maintenance
branch
3 times, most recently
from
fea9e94 to
8d32937
Compare
Signed-off-by: Joseph Livesey <[email protected]>
Signed-off-by: Joseph Livesey <[email protected]>
Signed-off-by: Joseph Livesey <[email protected]>
suchapalaver
force-pushed
the
suchapalaver/dependency-maintenance
branch
from
8d32937 to
77e9588
Compare
neithanmo
approved these changes
Apr 21, 2025
Contributor
neithanmo
left a comment
neithanmo
left a comment
There was a problem hiding this comment.
This organize better the dependencies!
Amazing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the workspace manifest where plausible, updating to latest where it's simple.