From 1586b0f2f2b8d3ec146c58475442a8f9e0067a35 Mon Sep 17 00:00:00 2001 From: Joseph Livesey Date: Tue, 27 May 2025 11:47:44 -0400 Subject: [PATCH] fix(eip712-message): canonicalize to low-S before returning bytes Signed-off-by: Joseph Livesey --- tap_eip712_message/src/lib.rs | 4 +++- tap_receipt/src/lib.rs | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tap_eip712_message/src/lib.rs b/tap_eip712_message/src/lib.rs index e0899081..cca762bb 100644 --- a/tap_eip712_message/src/lib.rs +++ b/tap_eip712_message/src/lib.rs @@ -62,7 +62,9 @@ pub trait SignatureBytesExt { impl SignatureBytesExt for Signature { fn get_signature_bytes(&self) -> SignatureBytes { - SignatureBytes(self.as_bytes()) + // Canonicalize to low-S form before returning bytes + let canonical = self.normalized_s(); + SignatureBytes(canonical.as_bytes()) } } diff --git a/tap_receipt/src/lib.rs b/tap_receipt/src/lib.rs index f3f3e05c..4ba2e432 100644 --- a/tap_receipt/src/lib.rs +++ b/tap_receipt/src/lib.rs @@ -68,6 +68,6 @@ where type Output = SignatureBytes; fn unique_id(&self) -> Self::Output { - self.signature.normalized_s().get_signature_bytes() + self.signature.get_signature_bytes() } }