fix(aggregator): use split EIP712 domains for TAP v1 and v2 aggregator #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmigone
requested review from
TypeLevelConsoli,
neithanmo and
suchapalaver
as code owners
neithanmo
previously approved these changes
Sep 2, 2025
Signed-off-by: Natanael Mojica <[email protected]>
Signed-off-by: Natanael Mojica <[email protected]>
auto-merge was automatically disabled
September 2, 2025 15:19
Head branch was pushed to by a user without write access
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
tmigone
force-pushed
the
tmigone/aggregator-split-domain
branch
from
7354992 to
166e266
Compare
neithanmo
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes - TAP Aggregator:
clientfeature flag forjsonrpseein order to run tests,cargo buildwas running fine so not sure if it's a problem with my setup.TAP_DOMAIN_NAMEis no longer needed as it's automatically determined bytap_core::tap_eip712_domain()based on the TAP versionTAP_DOMAIN_VERSIONis no longer needed as this is1for both TAP versionsTAP_DOMAIN_VERIFYING_CONTRACT_V2to specify the TAP v2 contract.