add stop for CANBusNetwork

Author: Günther Jena

CHANGELOG.md

@@ -1,3 +1,8 @@
+# 0.4.8
+
+* adding .stop method to CANBusNetwork
+* remove .shutdown method from scheduler base class and add .stop to SyncScheduler
+
 # 0.4.7
 
 * adding .shutdown method to schedulers

src/durand/network.py

@@ -38,7 +38,7 @@ def __init__(self, can_bus: can.BusABC, loop=None):
         self.subscriptions: Dict[int, Callable[[int, bytes], None]] = {}
 
         listener = NodeListener(self)
-        can.Notifier(self._bus, (listener,), 1, self._loop)
+        self._notifier = can.Notifier(self._bus, (listener,), 1, self._loop)
 
     def add_subscription(self, cob_id: int, callback):
         with self.lock:
@@ -58,6 +58,9 @@ def _update_filters(self):
     def send(self, cob_id: int, msg: bytes):
         msg = can.Message(arbitration_id=cob_id, data=msg, is_extended_id=False)
         self._bus.send(msg)
+    
+    def stop(self):
+        self._notifier.stop()
 
 
 class NodeListener(can.Listener):

src/durand/scheduler.py

@@ -34,9 +34,6 @@ def cancel(self, entry: TEntry):
     def lock(self):
         """A global lock which can be used the assure thread safety"""
 
-    def shutdown(self):
-        """ Shutting down the scheduler """
-
 
 class AsyncScheduler(AbstractScheduler):
     def __init__(self, loop=None):
@@ -60,8 +57,6 @@ def cancel(self, entry: asyncio.TimerHandle):  # type: ignore[override]
     def lock(self):
         return self._lock
 
-    # nothing happens at shutdown, as no resources have to be freed
-
 
 class SyncScheduler(AbstractScheduler):
     def __init__(self, lock: threading.Lock = None):
@@ -96,7 +91,7 @@ def run(self):
     def lock(self):
         return self._lock
 
-    def shutdown(self):
+    def stop(self):
         self._wake_up.set()
         self._stop = True