Skip to content

Commit 08a8cee

Browse files
committed
Don't require simplecov in cucumber env.rb
MSP-11671 All features currently use aruba to run msfconsole in a separate process and it is that child process that needs to load simplecov. Changes average runtime for `rake cucumber:boot` from (n=10) 122.21 seconds to (n=13) 112.50 seconds (-7.50%). Raw data: https://docs.google.com/spreadsheets/d/1vCRi_38Go3Wfq670eDCXMTSSXL1blSbk6NQsgpOqfYw/edit?usp=sharing
1 parent 2c1203b commit 08a8cee

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

features/support/env.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
# Has to be the first file required so that all other files show coverage information
2-
require 'simplecov'
1+
# @note `require 'simplecov'` is not used here because all features currently use external `msfconsole` process, so only
2+
# that child process needs to load 'simplecov'.
33

44
# IMPORTANT: This file is generated by cucumber-rails - edit at your own peril.
55
# It is recommended to regenerate this file in the future when you upgrade to a

0 commit comments

Comments
 (0)