POST module duplicate search results

Running a POST module in meterpreter was causing duplicate search
results for the executed module.  For example, running
post/windows/gather/checkvm would produce duplicate results for that
module when executing “search checkvm” in msf.

Debugging revealed that the cmd_exec function in meterpreter’s ui
command_dispatcher core was creating the specified module, and then
promptly reloading it.  The reload function was causing the duplicate
module_detail record to be written to the msg postgres database
instance.  Further analysis revealed that the “original_mod” could be
used for running the post module, so the “reloaded_mod” was removed
and the “original_mod” used in it’s place to run the post module.

SeeRM rapid7#8754

Author: nstarke

lib/rex/post/meterpreter/ui/console/command_dispatcher/core.rb

@@ -542,17 +542,16 @@ def cmd_run(*args)
       # fall back to using the scripting interface.
       if (msf_loaded? and mod = client.framework.modules.create(script_name))
         original_mod = mod
-        reloaded_mod = client.framework.modules.reload_module(original_mod)
 
-        unless reloaded_mod
+        unless original_mod
           error = client.framework.modules.module_load_error_by_path[original_mod.file_path]
           print_error("Failed to reload module: #{error}")
 
           return
         end
 
         opts = (args + [ "SESSION=#{client.sid}" ]).join(',')
-        reloaded_mod.run_simple(
+        original_mod.run_simple(
           #'RunAsJob' => true,
           'LocalInput'  => shell.input,
           'LocalOutput' => shell.output,