Land rapid7#5617, record the success on which we stopped (fixes rapid7#5616)

Brent Cook · Brent Cook · commit 10a6945737d5 · 2015-06-26T18:27:49.000-05:00
diff --git a/lib/metasploit/framework/login_scanner/base.rb b/lib/metasploit/framework/login_scanner/base.rb
@@ -220,8 +220,8 @@ def scan!
 
               if result.success?
                 consecutive_error_count = 0
-                break if stop_on_success
                 successful_users << credential.public
+                break if stop_on_success
               else
                 if result.status == Metasploit::Model::Login::Status::UNABLE_TO_CONNECT
                   consecutive_error_count += 1
