Properly close hashlist

Author: wchen-r7

modules/auxiliary/analyze/jtr_aix.rb

@@ -38,58 +38,60 @@ def run
 			wordlist.close
 		end
 
-		hashlist = Rex::Quickfile.new("jtrtmp")
-
 		myloots = myworkspace.loots.find(:all, :conditions => ['ltype=?', 'aix.hashes'])
-		unless myloots.nil? or myloots.empty?
-			myloots.each do |myloot|
-				usf = ''
-				begin
-					File.open(myloot.path, "rb") do |f|
-						usf = f.read
-					end
-				rescue Exception => e
-					print_error("Unable to read #{myloot.path} \n #{e}")
-					next
-				end
-				usf.each_line do |row|
-					row.gsub!(/\n/, ":#{myloot.host.address}\n")
-					hashlist.write(row)
+		return if myloots.nil? or myloots.empty?
+
+		loot_data = ''
+
+		myloots.each do |myloot|
+			usf = ''
+			begin
+				File.open(myloot.path, "rb") do |f|
+					usf = f.read
 				end
+			rescue Exception => e
+				print_error("Unable to read #{myloot.path} \n #{e}")
+				next
+			end
+			usf.each_line do |row|
+				row.gsub!(/\n/, ":#{myloot.host.address}\n")
+				loot_data << row
 			end
-			hashlist.close
+		end
 
-			print_status("HashList: #{hashlist.path}")
+		hashlist = Rex::Quickfile.new("jtrtmp")
+		hashlist.write(row)
+		hashlist.close
 
-			print_status("Trying Format:des Wordlist: #{wordlist.path}")
-			john_crack(hashlist.path, :wordlist => wordlist.path, :rules => 'single', :format => 'des')
-			print_status("Trying Format:des Rule: All4...")
-			john_crack(hashlist.path, :incremental => "All4", :format => 'des')
-			print_status("Trying Format:des Rule: Digits5...")
-			john_crack(hashlist.path, :incremental => "Digits5", :format => 'des')
+		print_status("HashList: #{hashlist.path}")
 
-			cracked = john_show_passwords(hashlist.path)
+		print_status("Trying Format:des Wordlist: #{wordlist.path}")
+		john_crack(hashlist.path, :wordlist => wordlist.path, :rules => 'single', :format => 'des')
+		print_status("Trying Format:des Rule: All4...")
+		john_crack(hashlist.path, :incremental => "All4", :format => 'des')
+		print_status("Trying Format:des Rule: Digits5...")
+		john_crack(hashlist.path, :incremental => "Digits5", :format => 'des')
 
+		cracked = john_show_passwords(hashlist.path)
 
-			print_status("#{cracked[:cracked]} hashes were cracked!")
 
-			cracked[:users].each_pair do |k,v|
-				if v[0] == "NO PASSWORD"
-					passwd=""
-				else
-					passwd=v[0]
-				end
-				print_good("Host: #{v.last}  User: #{k} Pass: #{passwd}")
-				report_auth_info(
-					:host  => v.last,
-					:port => 22,
-					:sname => 'ssh',
-					:user => k,
-					:pass => passwd
-				)
+		print_status("#{cracked[:cracked]} hashes were cracked!")
+
+		cracked[:users].each_pair do |k,v|
+			if v[0] == "NO PASSWORD"
+				passwd=""
+			else
+				passwd=v[0]
 			end
+			print_good("Host: #{v.last}  User: #{k} Pass: #{passwd}")
+			report_auth_info(
+				:host  => v.last,
+				:port => 22,
+				:sname => 'ssh',
+				:user => k,
+				:pass => passwd
+			)
 		end
-
 	end
 
 end