Revert "Back to Create OpenSSL::BN from string"

jvazquez-r7 · jvazquez-r7 · commit 13ec578d1a1f · 2014-12-22T23:17:03.000-06:00
This reverts commit 635a54c.
diff --git a/lib/rex/proto/kerberos/model/ap_req.rb b/lib/rex/proto/kerberos/model/ap_req.rb
@@ -55,7 +55,7 @@ def encode
           #
           # @return [OpenSSL::ASN1::Integer]
           def encode_pvno
-            bn = OpenSSL::BN.new(pvno)
+            bn = OpenSSL::BN.new(pvno.to_s)
             int = OpenSSL::ASN1::Integer.new(bn)
 
             int
@@ -65,7 +65,7 @@ def encode_pvno
           #
           # @return [OpenSSL::ASN1::Integer]
           def encode_msg_type
-            bn = OpenSSL::BN.new(msg_type)
+            bn = OpenSSL::BN.new(msg_type.to_s)
             int = OpenSSL::ASN1::Integer.new(bn)
 
             int
diff --git a/lib/rex/proto/kerberos/model/authenticator.rb b/lib/rex/proto/kerberos/model/authenticator.rb
@@ -85,7 +85,7 @@ def encrypt(etype, key)
           #
           # @return [OpenSSL::ASN1::Integer]
           def encode_vno
-            bn = OpenSSL::BN.new(vno)
+            bn = OpenSSL::BN.new(vno.to_s)
             int = OpenSSL::ASN1::Integer.new(bn)
 
             int
@@ -116,7 +116,7 @@ def encode_checksum
           #
           # @return [OpenSSL::ASN1::Integer]
           def encode_cusec
-            bn = OpenSSL::BN.new(cusec)
+            bn = OpenSSL::BN.new(cusec.to_s)
             int = OpenSSL::ASN1::Integer.new(bn)
 
             int
diff --git a/lib/rex/proto/kerberos/model/authorization_data.rb b/lib/rex/proto/kerberos/model/authorization_data.rb
@@ -65,7 +65,7 @@ def encrypt(etype, key)
           #
           # @return [OpenSSL::ASN1::Integer]
           def encode_type(type)
-            bn = OpenSSL::BN.new(type)
+            bn = OpenSSL::BN.new(type.to_s)
             int = OpenSSL::ASN1::Integer.new(bn)
 
             int
diff --git a/lib/rex/proto/kerberos/model/checksum.rb b/lib/rex/proto/kerberos/model/checksum.rb
@@ -40,7 +40,7 @@ def encode
           #
           # @return [OpenSSL::ASN1::Integer]
           def encode_type
-            bn = OpenSSL::BN.new(type)
+            bn = OpenSSL::BN.new(type.to_s)
             int = OpenSSL::ASN1::Integer.new(bn)
 
             int
diff --git a/lib/rex/proto/kerberos/model/encrypted_data.rb b/lib/rex/proto/kerberos/model/encrypted_data.rb
@@ -85,7 +85,7 @@ def decrypt(key, msg_type)
           #
           # @return [OpenSSL::ASN1::Integer]
           def encode_etype
-            bn = OpenSSL::BN.new(etype)
+            bn = OpenSSL::BN.new(etype.to_s)
             int = OpenSSL::ASN1::Integer.new(bn)
 
             int
@@ -95,7 +95,7 @@ def encode_etype
           #
           # @raise [RuntimeError]
           def encode_kvno
-            bn = OpenSSL::BN.new(kvno)
+            bn = OpenSSL::BN.new(kvno.to_s)
             int = OpenSSL::ASN1::Integer.new(bn)
 
             int
diff --git a/lib/rex/proto/kerberos/model/encryption_key.rb b/lib/rex/proto/kerberos/model/encryption_key.rb
@@ -87,7 +87,7 @@ def decode_value(input)
           #
           # @return [OpenSSL::ASN1::Integer]
           def encode_type
-            bn = OpenSSL::BN.new(type)
+            bn = OpenSSL::BN.new(type.to_s)
             int = OpenSSL::ASN1::Integer.new(bn)
 
             int
diff --git a/lib/rex/proto/kerberos/model/kdc_request.rb b/lib/rex/proto/kerberos/model/kdc_request.rb
@@ -58,7 +58,7 @@ def encode
           #
           # @return [OpenSSL::ASN1::Integer]
           def encode_pvno
-            bn = OpenSSL::BN.new(pvno)
+            bn = OpenSSL::BN.new(pvno.to_s)
             int = OpenSSL::ASN1::Integer.new(bn)
 
             int
@@ -68,7 +68,7 @@ def encode_pvno
           #
           # @return [OpenSSL::ASN1::Integer]
           def encode_msg_type
-            bn = OpenSSL::BN.new(msg_type)
+            bn = OpenSSL::BN.new(msg_type.to_s)
             int = OpenSSL::ASN1::Integer.new(bn)
 
             int
diff --git a/lib/rex/proto/kerberos/model/kdc_request_body.rb b/lib/rex/proto/kerberos/model/kdc_request_body.rb
@@ -151,7 +151,7 @@ def encode_rtime
           #
           # @return [OpenSSL::ASN1::Integer]
           def encode_nonce
-            bn = OpenSSL::BN.new(nonce)
+            bn = OpenSSL::BN.new(nonce.to_s)
             int = OpenSSL::ASN1::Integer.new(bn)
 
             int
@@ -163,7 +163,7 @@ def encode_nonce
           def encode_etype
             encoded_types = []
             etype.each do |member|
-              bn = OpenSSL::BN.new(member)
+              bn = OpenSSL::BN.new(member.to_s)
               int = OpenSSL::ASN1::Integer.new(bn)
               encoded_types << int
             end
diff --git a/lib/rex/proto/kerberos/model/pre_auth_data.rb b/lib/rex/proto/kerberos/model/pre_auth_data.rb
@@ -50,7 +50,7 @@ def encode
           #
           # @return [OpenSSL::ASN1::Integer]
           def encode_type
-            int_bn = OpenSSL::BN.new(type)
+            int_bn = OpenSSL::BN.new(type.to_s)
             int = OpenSSL::ASN1::Integer.new(int_bn)
 
             int
diff --git a/lib/rex/proto/kerberos/model/pre_auth_enc_time_stamp.rb b/lib/rex/proto/kerberos/model/pre_auth_enc_time_stamp.rb
@@ -79,7 +79,7 @@ def encode_pa_time_stamp
           #
           # @return [OpenSSL::ASN1::Integer]
           def encode_pausec
-            int_bn = OpenSSL::BN.new(pausec)
+            int_bn = OpenSSL::BN.new(pausec.to_s)
             int = OpenSSL::ASN1::Integer.new(int_bn)
 
             int
diff --git a/lib/rex/proto/kerberos/model/principal_name.rb b/lib/rex/proto/kerberos/model/principal_name.rb
@@ -51,7 +51,7 @@ def encode
           #
           # @return [OpenSSL::ASN1::Integer]
           def encode_name_type
-            int_bn = OpenSSL::BN.new(name_type)
+            int_bn = OpenSSL::BN.new(name_type.to_s)
             int = OpenSSL::ASN1::Integer.new(int_bn)
 
             int
diff --git a/lib/rex/proto/kerberos/model/ticket.rb b/lib/rex/proto/kerberos/model/ticket.rb
@@ -57,7 +57,7 @@ def encode
           #
           # @return [OpenSSL::ASN1::Integer]
           def encode_tkt_vno
-            bn = OpenSSL::BN.new(tkt_vno)
+            bn = OpenSSL::BN.new(tkt_vno.to_s)
             int = OpenSSL::ASN1::Integer.new(bn)
 
             int

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ def encrypt(etype, key)`
`65`	`65`	`#`
`66`	`66`	`# @return [OpenSSL::ASN1::Integer]`
`67`	`67`	`def encode_type(type)`
`68`		`- bn = OpenSSL::BN.new(type)`
	`68`	`+ bn = OpenSSL::BN.new(type.to_s)`
`69`	`69`	`int = OpenSSL::ASN1::Integer.new(bn)`
`70`	`70`
`71`	`71`	`int`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ def encode`
`40`	`40`	`#`
`41`	`41`	`# @return [OpenSSL::ASN1::Integer]`
`42`	`42`	`def encode_type`
`43`		`- bn = OpenSSL::BN.new(type)`
	`43`	`+ bn = OpenSSL::BN.new(type.to_s)`
`44`	`44`	`int = OpenSSL::ASN1::Integer.new(bn)`
`45`	`45`
`46`	`46`	`int`
Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ def decode_value(input)`
`87`	`87`	`#`
`88`	`88`	`# @return [OpenSSL::ASN1::Integer]`
`89`	`89`	`def encode_type`
`90`		`- bn = OpenSSL::BN.new(type)`
	`90`	`+ bn = OpenSSL::BN.new(type.to_s)`
`91`	`91`	`int = OpenSSL::ASN1::Integer.new(bn)`
`92`	`92`
`93`	`93`	`int`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ def encode`
`50`	`50`	`#`
`51`	`51`	`# @return [OpenSSL::ASN1::Integer]`
`52`	`52`	`def encode_type`
`53`		`- int_bn = OpenSSL::BN.new(type)`
	`53`	`+ int_bn = OpenSSL::BN.new(type.to_s)`
`54`	`54`	`int = OpenSSL::ASN1::Integer.new(int_bn)`
`55`	`55`
`56`	`56`	`int`
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ def encode_pa_time_stamp`
`79`	`79`	`#`
`80`	`80`	`# @return [OpenSSL::ASN1::Integer]`
`81`	`81`	`def encode_pausec`
`82`		`- int_bn = OpenSSL::BN.new(pausec)`
	`82`	`+ int_bn = OpenSSL::BN.new(pausec.to_s)`
`83`	`83`	`int = OpenSSL::ASN1::Integer.new(int_bn)`
`84`	`84`
`85`	`85`	`int`