Skip to content

Commit 2bbba9c

Browse files
committed
Avoid some ActiveRecord validation errors.
Per discussion with @bcoles in [PR 8759](rapid7#8759 (comment)), setting a login data's last_attempted_at value while also setting the status to UNTRIED will cause a validation error when there's a running+connected MSF DB. This PR removes the handful of existing cases we're doing this (thx, @bcoles!).
1 parent 202c936 commit 2bbba9c

File tree

4 files changed

+0
-4
lines changed

4 files changed

+0
-4
lines changed

modules/auxiliary/admin/http/dlink_dir_645_password_extractor.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ def report_cred(opts)
4949
}.merge(service_data)
5050

5151
login_data = {
52-
last_attempted_at: DateTime.now,
5352
core: create_credential(credential_data),
5453
status: Metasploit::Model::Login::Status::UNTRIED,
5554
proof: opts[:proof]

modules/auxiliary/admin/http/dlink_dsl320b_password_extractor.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ def report_cred(opts)
4646
}.merge(service_data)
4747

4848
login_data = {
49-
last_attempted_at: DateTime.now,
5049
core: create_credential(credential_data),
5150
status: Metasploit::Model::Login::Status::UNTRIED,
5251
proof: opts[:proof]

modules/auxiliary/admin/http/nexpose_xxe_file_read.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ def report_cred(opts)
6161
}.merge(service_data)
6262

6363
login_data = {
64-
last_attempted_at: DateTime.now,
6564
core: create_credential(credential_data),
6665
status: Metasploit::Model::Login::Status::UNTRIED
6766
}.merge(service_data)

modules/auxiliary/gather/asterisk_creds.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ def report_cred(opts)
116116
}.merge service_data
117117

118118
login_data = {
119-
last_attempted_at: DateTime.now,
120119
core: create_credential(credential_data),
121120
status: Metasploit::Model::Login::Status::UNTRIED,
122121
proof: opts[:proof]

0 commit comments

Comments
 (0)