Skip to content

Commit 2d5fd5e

Browse files
committed
Use constant for WORDPRESS_VERSION_PATTERN
1 parent b061d24 commit 2d5fd5e

File tree

1 file changed

+11
-14
lines changed

1 file changed

+11
-14
lines changed

lib/msf/http/wordpress/version.rb

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,40 @@
11
# -*- coding: binary -*-
22

33
module Msf::HTTP::Wordpress::Version
4+
5+
# Used to check if the version is correct: must contain at least one dot
6+
WORDPRESS_VERSION_PATTERN = '([^\r\n"\']+\.[^\r\n"\']+)'
7+
48
# Extracts the Wordpress version information from various sources
59
#
610
# @return [String,nil] Wordpress version if found, nil otherwise
711
def wordpress_version
812
# detect version from generator
9-
version = wordpress_version_helper(normalize_uri(target_uri.path), /<meta name="generator" content="WordPress #{wordpress_version_pattern}" \/>/i)
13+
version = wordpress_version_helper(normalize_uri(target_uri.path), /<meta name="generator" content="WordPress #{WORDPRESS_VERSION_PATTERN}" \/>/i)
1014
return version if version
1115

1216
# detect version from readme
13-
version = wordpress_version_helper(wordpress_url_readme, /<br \/>\sversion #{wordpress_version_pattern}/i)
17+
version = wordpress_version_helper(wordpress_url_readme, /<br \/>\sversion #{WORDPRESS_VERSION_PATTERN}/i)
1418
return version if version
1519

1620
# detect version from rss
17-
version = wordpress_version_helper(wordpress_url_rss, /<generator>http:\/\/wordpress.org\/\?v=#{wordpress_version_pattern}<\/generator>/i)
21+
version = wordpress_version_helper(wordpress_url_rss, /<generator>http:\/\/wordpress.org\/\?v=#{WORDPRESS_VERSION_PATTERN}<\/generator>/i)
1822
return version if version
1923

2024
# detect version from rdf
21-
version = wordpress_version_helper(wordpress_url_rdf, /<admin:generatorAgent rdf:resource="http:\/\/wordpress.org\/\?v=#{wordpress_version_pattern}" \/>/i)
25+
version = wordpress_version_helper(wordpress_url_rdf, /<admin:generatorAgent rdf:resource="http:\/\/wordpress.org\/\?v=#{WORDPRESS_VERSION_PATTERN}" \/>/i)
2226
return version if version
2327

2428
# detect version from atom
25-
version = wordpress_version_helper(wordpress_url_atom, /<generator uri="http:\/\/wordpress.org\/" version="#{wordpress_version_pattern}">WordPress<\/generator>/i)
29+
version = wordpress_version_helper(wordpress_url_atom, /<generator uri="http:\/\/wordpress.org\/" version="#{WORDPRESS_VERSION_PATTERN}">WordPress<\/generator>/i)
2630
return version if version
2731

2832
# detect version from sitemap
29-
version = wordpress_version_helper(wordpress_url_sitemap, /generator="wordpress\/#{wordpress_version_pattern}"/i)
33+
version = wordpress_version_helper(wordpress_url_sitemap, /generator="wordpress\/#{WORDPRESS_VERSION_PATTERN}"/i)
3034
return version if version
3135

3236
# detect version from opml
33-
version = wordpress_version_helper(wordpress_url_opml, /generator="wordpress\/#{wordpress_version_pattern}"/i)
37+
version = wordpress_version_helper(wordpress_url_opml, /generator="wordpress\/#{WORDPRESS_VERSION_PATTERN}"/i)
3438
return version if version
3539

3640
nil
@@ -60,13 +64,6 @@ def check_theme_version_from_readme(theme_name, fixed_version, vuln_introduced_v
6064

6165
private
6266

63-
# Used to check if the version is correct: must contain at least one dot
64-
#
65-
# @return [ String ]
66-
def wordpress_version_pattern
67-
'([^\r\n"\']+\.[^\r\n"\']+)'
68-
end
69-
7067
def wordpress_version_helper(url, regex)
7168
res = send_request_cgi(
7269
'method' => 'GET',

0 commit comments

Comments
 (0)