Log Spec::Constants::Each error instead of flag.

MSP-11130

Instead of writing `1` to the file and then printing a verbose message
in the spec task action, log the verbose message and just print the log
in the spec task action, so other tools can just look at the log when
not using `rake spec`.

NOTE: Failing specs due to unnecessary
`Metasploit::Framework::Spec::Constants::Each.configure!`

Author: limhoff-r7

lib/metasploit/framework/spec/constants/each.rb

@@ -9,7 +9,7 @@ module Metasploit::Framework::Spec::Constants::Each
   # CONSTANTS
   #
 
-  LOG_PATHNAME = Pathname.new('log/metasploit/framework/spec/constants/each.remove')
+  LOG_PATHNAME = Pathname.new('log/metasploit/framework/spec/constants/each.log')
 
   #
   # Module Methods
@@ -72,7 +72,9 @@ def self.configure!
             end
           else
             LOG_PATHNAME.open('w') { |f|
-              f.write('1')
+              f.puts "No leaks were cleaned by `Metasploit::Framework::Spec::Constants::Each.configured!`.  Remove " \
+                     "it from `spec/spec_helper.rb` so it does not interfere with contexts that persist loaded " \
+                     "modules for entire context and clean up modules in `after(:all)` and then `rm log/remove-cleaner`"
             }
           end
         end
@@ -96,9 +98,11 @@ def self.configured?
   def self.define_task
     Rake::Task.define_task(:spec) do
       if LOG_PATHNAME.exist?
-        $stderr.puts "No leaks were cleaned by `#{self}.configured!`.  Remove it from `spec/spec_helper.rb` so it " \
-                     "does not interfere with contexts that persist loaded modules for entire context and clean up " \
-                     "modules in `after(:all)` and then `rm log/remove-cleaner`"
+        LOG_PATHNAME.open { |f|
+          f.each_line do |line|
+            $stderr.write line
+          end
+        }
 
         exit(1)
       end

spec/spec_helper.rb

@@ -56,4 +56,5 @@
   config.use_transactional_fixtures = true
 end
 
+Metasploit::Framework::Spec::Constants::Each.configure!
 Metasploit::Framework::Spec::Constants::Suite.configure!