Land rapid7#3380, datastore msftidy errors set to INFO

[SeeRM rapid7#8498]

Author: wvu

tools/msftidy.rb

@@ -11,6 +11,7 @@
 require 'time'
 
 CHECK_OLD_RUBIES = !!ENV['MSF_CHECK_OLD_RUBIES']
+SUPRESS_INFO_MESSAGES = !!ENV['MSF_SUPPRESS_INFO_MESSAGES']
 
 if CHECK_OLD_RUBIES
   require 'rvm'
@@ -91,6 +92,7 @@ def fixed(txt, line=0)
   # Display an info message. Info messages do not alter the exit status.
   #
   def info(txt, line=0)
+    return if SUPRESS_INFO_MESSAGES
     line_msg = (line>0) ? ":#{line}" : ''
     puts "#{@full_filepath}#{line_msg} - [#{'INFO'.cyan}] #{cleanup_text(txt)}"
   end
@@ -471,9 +473,12 @@ def check_lines
         error("Writes to stdout", idx)
       end
 
-      # do not change datastore in code
+      # You should not change datastore in code. For reasons. See
+      # RM#8498 for discussion, starting at comment #16:
+      #
+      # https://dev.metasploit.com/redmine/issues/8498#note-16
       if ln =~ /(?<!\.)datastore\[["'][^"']+["']\]\s*=(?![=~>])/
-        error("datastore is modified in code: #{ln}", idx)
+        info("datastore is modified in code: #{ln}", idx)
       end
 
       # do not read Set-Cookie header (ignore commented lines)