Land rapid7#6415, update rspec3 conventions

Author: Brent Cook

spec/lib/active_record/connection_adapters/abstract_adapter/connection_pool_spec.rb

@@ -19,13 +19,13 @@ def database_configurations_pathname
 
   # Not all specs require a database connection, and railties aren't being
   # used, so have to manually establish connection.
-  before(:each) do
+  before(:example) do
     ActiveRecord::Base.configurations = database_configurations
     spec = ActiveRecord::Base.configurations[Rails.env]
     ActiveRecord::Base.establish_connection(spec)
   end
 
-  after(:each) do
+  after(:example) do
     ActiveRecord::Base.clear_all_connections!
   end
 
@@ -39,7 +39,7 @@ def database_configurations_pathname
       Thread.current
     end
 
-    before(:each) do
+    before(:example) do
       ActiveRecord::Base.connection_pool.connection
     end
 
@@ -92,7 +92,7 @@ def reserved_connection_count
         connection_pool.connection
       end
 
-      after(:each) do
+      after(:example) do
         connection_pool.checkin connection
       end
 

spec/lib/metasploit/framework/credential_spec.rb

@@ -33,7 +33,7 @@
     end
 
     context 'when not paired' do
-      before(:each) do
+      before(:example) do
         cred_detail.paired = false
       end
 
@@ -53,7 +53,7 @@
     end
 
     context 'when paired' do
-      before(:each) do
+      before(:example) do
         cred_detail.paired = true
       end
 

spec/lib/metasploit/framework/database_spec.rb

@@ -95,7 +95,7 @@
       described_class.configurations_pathnames
     }
 
-    before(:each) do
+    before(:example) do
       allow(described_class).to receive(:environment_configurations_pathname).and_return(
                                     environment_configurations_pathname
                                 )
@@ -119,7 +119,7 @@
         # Callbacks
         #
 
-        before(:each) do
+        before(:example) do
           allow(described_class).to receive(:user_configurations_pathname).and_return(
                                         user_configurations_pathname
                                     )
@@ -143,7 +143,7 @@
             # Callbacks
             #
 
-            before(:each) do
+            before(:example) do
               allow(described_class).to receive(:project_configurations_pathname).and_return(
                                             project_configurations_pathname
                                         )
@@ -224,7 +224,7 @@
             # Callbacks
             #
 
-            before(:each) do
+            before(:example) do
               allow(described_class).to receive(:project_configurations_pathname).and_return(
                                             project_configurations_pathname
                                         )
@@ -306,7 +306,7 @@
           # Callbacks
           #
 
-          before(:each) do
+          before(:example) do
             allow(described_class).to receive(:project_configurations_pathname).and_return(
                                           project_configurations_pathname
                                       )
@@ -346,7 +346,7 @@
       # Callbacks
       #
 
-      before(:each) do
+      before(:example) do
         allow(described_class).to receive(:user_configurations_pathname).and_return(
                                       user_configurations_pathname
                                   )
@@ -370,7 +370,7 @@
           # Callbacks
           #
 
-          before(:each) do
+          before(:example) do
             allow(described_class).to receive(:project_configurations_pathname).and_return(
                                           project_configurations_pathname
                                       )
@@ -451,7 +451,7 @@
           # Callbacks
           #
 
-          before(:each) do
+          before(:example) do
             allow(described_class).to receive(:project_configurations_pathname).and_return(
                                           project_configurations_pathname
                                       )
@@ -524,7 +524,7 @@
         # Callbacks
         #
 
-        before(:each) do
+        before(:example) do
           allow(described_class).to receive(:project_configurations_pathname).and_return(
                                         project_configurations_pathname
                                     )
@@ -584,7 +584,7 @@
       described_class.environment_configurations_pathname
     }
 
-    around(:each) do |example|
+    around(:example) do |example|
       env_before = ENV.to_hash
 
       begin
@@ -595,7 +595,7 @@
     end
 
     context 'with MSF_DATABASE_CONFIG' do
-      before(:each) do
+      before(:example) do
         ENV['MSF_DATABASE_CONFIG'] = msf_database_config
       end
 
@@ -619,7 +619,7 @@
     end
 
     context 'without MSF_DATABASE_CONFIG' do
-      before(:each) do
+      before(:example) do
         ENV.delete('MSF_DATABASE_CONFIG')
       end
 
@@ -655,15 +655,15 @@
     # Callbacks
     #
 
-    around(:each) do |example|
+    around(:example) do |example|
       begin
         example.run
       ensure
         FileUtils.remove_entry_secure config_root
       end
     end
 
-    before(:each) do
+    before(:example) do
       allow(Msf::Config).to receive(:get_config_root).and_return(config_root)
     end
 

spec/lib/metasploit/framework/jtr/cracker_spec.rb

@@ -21,7 +21,7 @@
 
 
     context 'when the user supplied a john_path' do
-      before(:each) do
+      before(:example) do
         cracker.john_path = john_path
       end
 
@@ -54,7 +54,7 @@
   end
 
   describe '#crack_command' do
-    before(:each) do
+    before(:example) do
       expect(cracker).to receive(:binary_path).and_return john_path
       expect(cracker).to receive(:john_session_id).and_return session_id
     end
@@ -123,7 +123,7 @@
   end
 
   describe '#show_command' do
-    before(:each) do
+    before(:example) do
       expect(cracker).to receive(:binary_path).and_return john_path
     end
 
@@ -159,7 +159,7 @@
   describe 'validations' do
     context 'failures' do
       context 'file_path validators' do
-        before(:each) do
+        before(:example) do
           expect(File).to receive(:file?).and_return false
         end
 
@@ -189,7 +189,7 @@
       end
 
       context 'executable_path validators' do
-        before(:each) do
+        before(:example) do
           expect(File).to receive(:executable?).and_return false
         end
 
@@ -203,7 +203,7 @@
 
     context 'successes' do
       context 'file_path validators' do
-        before(:each) do
+        before(:example) do
           expect(File).to receive(:file?).and_return true
         end
 
@@ -233,7 +233,7 @@
       end
 
       context 'executable_path validators' do
-        before(:each) do
+        before(:example) do
           expect(File).to receive(:executable?).and_return true
         end
 

spec/lib/metasploit/framework/login_scanner/chef_webui_spec.rb

@@ -83,7 +83,7 @@
       'New password for the User'
     end
 
-    before :each do
+    before :example do
       allow_any_instance_of(Rex::Proto::Http::Client).to receive(:send_recv) do |cli, req|
         if req.opts['uri'] && req.opts['uri'].include?('/users/login_exec') &&
             req.opts['data'] &&

spec/lib/metasploit/framework/login_scanner/ftp_spec.rb

@@ -92,7 +92,7 @@
   end
 
   context '#attempt_login' do
-    before(:each) do
+    before(:example) do
       ftp_scanner.host = '127.0.0.1'
       ftp_scanner.port = 21
       ftp_scanner.connection_timeout = 30

spec/lib/metasploit/framework/login_scanner/glassfish_spec.rb

@@ -118,7 +118,7 @@
       '<title>Deploy Enterprise Applications/Modules</title>'
     end
 
-    before :each do
+    before :example do
       allow_any_instance_of(Rex::Proto::Http::Client).to receive(:send_recv) do |cli, req|
         if req.opts['uri'] && req.opts['uri'].include?('j_security_check') &&
             req.opts['data'] &&
@@ -158,7 +158,7 @@
       '<title>Deploy Enterprise Applications/Modules</title>'
     end
 
-    before :each do
+    before :example do
       allow_any_instance_of(Rex::Proto::Http::Client).to receive(:send_recv) do |cli, req|
         if req.opts['uri'] && req.opts['uri'].include?('j_security_check') &&
             req.opts['data'] &&

spec/lib/metasploit/framework/login_scanner/http_spec.rb

@@ -14,7 +14,7 @@
 
   let(:response) { Rex::Proto::Http::Response.new(200, 'OK') }
 
-  before(:each) do
+  before(:example) do
     allow_any_instance_of(Rex::Proto::Http::Client).to receive(:request_cgi).with(any_args)
     allow_any_instance_of(Rex::Proto::Http::Client).to receive(:send_recv).with(any_args).and_return(response)
     allow_any_instance_of(Rex::Proto::Http::Client).to receive(:set_config).with(any_args)

spec/lib/metasploit/framework/login_scanner/ipboard_spec.rb

@@ -54,7 +54,7 @@
 
     context "when invalid IPBoard application" do
       let(:not_found_warning) { 'Server nonce not present, potentially not an IP Board install or bad URI.' }
-      before :each do
+      before :example do
         allow_any_instance_of(Rex::Proto::Http::Client).to receive(:send_recv) do |cli, req|
           Rex::Proto::Http::Response.new(200)
         end
@@ -70,7 +70,7 @@
     end
 
     context "when valid IPBoard application" do
-      before :each do
+      before :example do
         allow_any_instance_of(Rex::Proto::Http::Client).to receive(:send_recv) do |cli, req|
 
           if req.opts['uri'] && req.opts['uri'].include?('index.php') &&

spec/lib/metasploit/framework/login_scanner/manageengine_desktop_central_spec.rb

@@ -38,7 +38,7 @@
       Rex::Proto::Http::Response.new(200, 'OK')
     end
 
-    before(:each) do
+    before(:example) do
       allow_any_instance_of(Rex::Proto::Http::Client).to receive(:request_cgi).with(any_args)
       allow_any_instance_of(Rex::Proto::Http::Client).to receive(:send_recv).with(any_args).and_return(response)
       allow_any_instance_of(Rex::Proto::Http::Client).to receive(:set_config).with(any_args)