Fixup open sm

Author: Meatballs1

lib/msf/core/exploit/dcerpc_services.rb

@@ -16,24 +16,28 @@ module Exploit::Remote::DCERPC_SERVICES
   # @param rhost [String] the target host.
   # @param access [Fixnum] the access flags requested.
   #
-  # @return [String] the handle to the service control manager.
+  # @return [String] the handle to the service control manager or nil if
+  #   the call is not successful.
   def dce_openscmanagerw(dcerpc, rhost, access = 0xF003F)
     scm_handle = nil
     scm_status = nil
     stubdata =
       NDR.uwstring("\\\\#{rhost}") +
       NDR.long(0) +
       NDR.long(access)
-    response = dcerpc.call(0x0f, stubdata)
-    if dcerpc.last_response and dcerpc.last_response.stub_data
-      scm_handle = dcerpc.last_response.stub_data[0,20]
-      scm_status = dcerpc.last_response.stub_data[20,4]
+    begin
+      response = dcerpc.call(0x0f, stubdata)
+      if response
+        scm_status = response[20,4].unpack('V').first
+        if scm_status == 0
+          scm_handle = response[0,20]
+        end
+      end
+    rescue Rex::Proto::DCERPC::Exceptions::Fault => e
+      print_error("#{peer} - Error getting scm handle: #{e}")
     end
 
-    if scm_status.to_i != 0
-      scm_handle = nil
-    end
-    return scm_handle
+    scm_handle
   end