Finish POC cleanup

Author: clee-r7

lib/metasploit/framework/data_service.rb

@@ -34,6 +34,9 @@ def active
     raise 'DataLService#active is not implemented';
   end
 
+  #
+  # Hold metadata about a data service
+  #
   class Metadata
     attr_reader :id
     attr_reader :name
@@ -45,14 +48,15 @@ def initialize (id, name, active)
       self.active = active
     end
 
+    #######
     private
+    #######
+
     attr_writer  :id
     attr_writer :name
     attr_writer :active
 
   end
-
 end
-
 end
 end

lib/msf/ui/console/command_dispatcher/core.rb

@@ -20,7 +20,6 @@
 require 'msf/ui/console/command_dispatcher/resource'
 require 'msf/ui/console/command_dispatcher/modules'
 require 'msf/util/document_generator'
-require 'metasploit/framework/data_service/remote/msf_red/msf_red_service'
 
 module Msf
 module Ui
@@ -108,7 +107,6 @@ def commands
       "?"          => "Help menu",
       "banner"     => "Display an awesome metasploit banner",
       "cd"         => "Change the current working directory",
-      "msf_red_connect" => "Connect to MSF Platform",
       "connect"    => "Communicate with a host",
       "color"      => "Toggle color",
       "exit"       => "Exit the console",
@@ -263,20 +261,6 @@ def cmd_banner(*args)
 
   end
 
-  def cmd_msf_red_connect(*args)
-    while (arg = args.shift)
-      case arg
-        when '-u'
-          username = args.shift
-        when '-p'
-          password = args.shift
-      end
-    end
-
-    msf_red_service = MSFRedService.new()
-    msf_red_service.launch(username, password)
-  end
-
   def cmd_connect_help
     print_line "Usage: connect [options] <host> <port>"
     print_line

lib/msf/ui/console/command_dispatcher/db.rb

@@ -85,7 +85,11 @@ def active?
           end
 
           def cmd_set_data_service(service_id)
-            framework.db.set_data_service(service_id)
+            begin
+              framework.db.set_data_service(service_id)
+            rescue Exception => e
+              print_error "Unable to set data service: #{e.message}"
+            end
           end
 
           def cmd_list_data_services()