Add specs for module_flavors

Author: jvazquez-r7

lib/msf/core/exploit/cmdstager.rb

@@ -116,7 +116,7 @@ def generate_cmdstager(opts = {}, pl = nil)
     self.stager_instance = create_stager
     cmd_list = stager_instance.generate(opts_with_decoder(opts))
 
-    if (cmd_list.nil? or cmd_list.length < 1)
+    if (cmd_list.nil? || cmd_list.length < 1)
       print_error("The command stager could not be generated")
       raise ArgumentError
     end

spec/lib/msf/core/exploit/cmdstager_spec.rb

@@ -147,6 +147,92 @@ def create_exploit(info ={})
     end
   end
 
+  describe "#module_flavors" do
+
+    context "when the module hasn't CmdStagerFlavor info" do
+
+      context "neither the target" do
+
+        subject do
+          create_exploit
+        end
+
+        it "returns empty array" do
+          expect(subject.module_flavors).to eq([])
+        end
+      end
+
+      context "the target has CmdStagerFlavor info" do
+
+        subject do
+          create_exploit({
+            'DefaultTarget' => 0,
+            'Targets' =>
+              [
+                ['Windows',
+                  {
+                    'CmdStagerFlavor' => 'vbs'
+                  }
+                ]
+              ]
+          })
+        end
+
+        let(:expected_flavor) do
+          ['vbs']
+        end
+
+        it "returns an array with the target flavor" do
+          expect(subject.module_flavors).to eq(expected_flavor)
+        end
+      end
+    end
+
+    context "when the module has CmdStagerFlavor info" do
+
+      context "but the target hasn't CmdStagerFlavor info" do
+
+        subject do
+          create_exploit('CmdStagerFlavor' => 'vbs')
+        end
+
+        let(:expected_flavor) do
+          ['vbs']
+        end
+
+        it "returns an array with the module flavor" do
+          expect(subject.module_flavors).to eq(expected_flavor)
+        end
+      end
+
+      context "and the target has CmdStagerFlavor info" do
+
+        subject do
+          create_exploit({
+            'CmdStagerFlavor' => 'vbs',
+            'DefaultTarget'   => 0,
+            'Targets' =>
+              [
+                ['Windows TFTP',
+                  {
+                    'CmdStagerFlavor' => 'tftp'
+                  }
+                ]
+              ]
+          })
+        end
+
+        let(:expected_flavor) do
+          ['vbs', 'tftp']
+        end
+
+        it "returns an array with all the flavors available to the module" do
+          expect(subject.module_flavors).to eq(expected_flavor)
+        end
+      end
+    end
+  end
+
   describe "#target_flavor" do
 
     context "when the module hasn't CmdStagerFlavor info" do