Move to .empty? over length

Author: Meatballs1

modules/auxiliary/server/capture/smb.rb

@@ -527,8 +527,8 @@ def smb_get_hash(smb, arg = {}, esn=true)
 			end
 
 			print_status(capturelogmessage)
-			lm_text = (lm_hash + lm_cli_challenge.to_s).length > 0 ? lm_hash + lm_cli_challenge.to_s : "00" * 24
-			nt_text = (nt_hash + nt_cli_challenge.to_s).length > 0 ? nt_hash + nt_cli_challenge.to_s :  "00" * 24
+			lm_text = (lm_hash + lm_cli_challenge.to_s).empty? ? "00" * 24 : lm_hash + lm_cli_challenge.to_s
+			nt_text = (nt_hash + nt_cli_challenge.to_s).empty? ? "00" * 24 : nt_hash + nt_cli_challenge.to_s
 			pass = "#{smb[:domain]}:#{lm_text}:#{nt_text}:#{datastore['CHALLENGE'].to_s}" 
 
 			# DB reporting
@@ -575,8 +575,8 @@ def smb_get_hash(smb, arg = {}, esn=true)
 							smb[:username],
 							smb[:domain] ? smb[:domain] : "NULL",
 							@challenge.unpack("H*")[0],
-							lm_hash ? lm_hash : "0" * 48,
-							nt_hash ? nt_hash : "0" * 48
+							lm_hash.empty? ? "0" * 48 : lm_hash, 
+							nt_hash.empty? ? "0" * 48 : nt_hash
 						].join(":").gsub(/\n/, "\\n")
 					)
 					fd.close
@@ -592,8 +592,8 @@ def smb_get_hash(smb, arg = {}, esn=true)
 						[
 							smb[:username],"",
 							smb[:domain] ? smb[:domain] : "NULL",
-							lm_hash.length > 0 ? lm_hash : "0" * 48,
-							nt_hash.length > 0 ? nt_hash : "0" * 48,
+							lm_hash.empty? ? "0" * 48 : lm_hash,
+							nt_hash.empty? ? "0" * 48 : nt_hash,
 							@challenge.unpack("H*")[0]
 						].join(":").gsub(/\n/, "\\n")
 					)
@@ -606,8 +606,8 @@ def smb_get_hash(smb, arg = {}, esn=true)
 							smb[:username],"",
 							smb[:domain] ? smb[:domain] : "NULL",
 							@challenge.unpack("H*")[0],
-							lm_hash.length > 0 ? lm_hash : "0" * 32,
-							lm_cli_challenge ? lm_cli_challenge : "0" * 16
+							lm_hash.empty? ? "0" * 32 : lm_hash,
+							lm_cli_challenge.empty? ? "0" * 16 : lm_cli_challenge
 						].join(":").gsub(/\n/, "\\n")
 					)
 					fd.close
@@ -618,8 +618,8 @@ def smb_get_hash(smb, arg = {}, esn=true)
 							smb[:username],"",
 							smb[:domain] ? smb[:domain] : "NULL",
 							@challenge.unpack("H*")[0],
-							nt_hash.length > 0 ? nt_hash : "0" * 32,
-							nt_cli_challenge ? nt_cli_challenge : "0" * 160
+							nt_hash.empty? ? "0" * 32 : nt_hash,
+							nt_cli_challenge ? "0" * 160 : nt_cli_challenge
 						].join(":").gsub(/\n/, "\\n")
 					)
 					fd.close