Skip to content

Commit 4703a6f

Browse files
committed
Unbreak OptInt hex syntax
* Fix spec for no-longer-pending tests * Fix regex in OptInt#valid? to allow hex syntax again [See rapid7#1293][See rapid7#1296]
1 parent 5fc0085 commit 4703a6f

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

lib/msf/core/option_container.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ def normalize(value)
445445
def valid?(value)
446446
return false if empty_required_value?(value)
447447

448-
if value and not value.to_s.match(/^\d+$/)
448+
if value and not value.to_s.match(/^(?:0x)?\d+$/)
449449
return false
450450
end
451451

spec/lib/msf/core/options/opt_int_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
{ :pending => "Redmine #7540", :value => "-1", :normalized => -1 }
1212
]
1313
invalid_values = [
14-
{ :pending => "Redmine #7539", :value => "yer mom", },
15-
{ :pending => "Redmine #7539", :value => "0.1", },
14+
{ :value => "yer mom", },
15+
{ :value => "0.1", },
1616
]
1717

1818
it_behaves_like "an option", valid_values, invalid_values

spec/lib/msf/core/options/opt_port_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44

55
describe Msf::OptPort do
66
valid_values = [
7-
{ :pending => "Redmine #7535", :value => "0", :normalized => 0 },
8-
{ :pending => "Redmine #7535", :value => "65536",:normalized => 65536 },
9-
{ :pending => "Redmine #7535", :value => "80", :normalized => 80 },
7+
{ :value => "0", :normalized => 0 },
8+
{ :value => "65535",:normalized => 65535 },
9+
{ :value => "80", :normalized => 80 },
1010
]
1111
invalid_values = [
1212
{ :value => "yer mom", },

0 commit comments

Comments
 (0)