Skip to content

Commit 49f00ac

Browse files
committed
Fix nil deref when dnsdomain is empty
1 parent 867ab2f commit 49f00ac

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

modules/auxiliary/scanner/smb/psexec_loggedin_users.rb

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,10 @@ def check_hku_entry(key, ip, smbshare, cmd, text, bat)
164164
print_good("#{peer} - #{user}")
165165
report_user(user.chomp)
166166
else
167-
if username = query_session(smbshare, ip, cmd, text, bat)
168-
user = dnsdomain.split(" ")[2].split(".")[0].to_s + "\\" + username.to_s
167+
username = query_session(smbshare, ip, cmd, text, bat)
168+
if username
169+
hostname = (dnsdomain.split(" ")[2] || "").split(".")[0] || "."
170+
user = "#{hostname}\\#{username}"
169171
print_good("#{peer} - #{user}")
170172
report_user(user.chomp)
171173
else
@@ -175,7 +177,7 @@ def check_hku_entry(key, ip, smbshare, cmd, text, bat)
175177
else
176178
print_status("#{peer} - Could not determine logged in users")
177179
end
178-
rescue StandardError => check_error
180+
rescue Rex::Proto::SMB::Exceptions::Error => check_error
179181
print_error("#{peer} - Error checking reg key. #{check_error.class}. #{check_error}")
180182
return check_error
181183
end

0 commit comments

Comments
 (0)