Don't lie about stop_on_success

Tod Beardsley · Tod Beardsley · commit 4eaf64afef25 · 2014-12-11T12:37:13.000-06:00
This absolutely needs to be honored too, though. See rapid7#4365.
diff --git a/lib/metasploit/framework/login_scanner/base.rb b/lib/metasploit/framework/login_scanner/base.rb
@@ -173,7 +173,7 @@ def each_credential
           # {#cred_details}, by calling {#attempt_login} once for each.
           #
           # If a successful login is found for a user, no more attempts
-          # will be made for that user, assuming stop_on_success is false.
+          # will be made for that user.
           #
           # @yieldparam result [Result] The {Result} object for each attempt
           # @yieldreturn [void]

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ def each_credential`
`173`	`173`	`# {#cred_details}, by calling {#attempt_login} once for each.`
`174`	`174`	`#`
`175`	`175`	`# If a successful login is found for a user, no more attempts`
`176`		`- # will be made for that user, assuming stop_on_success is false.`
	`176`	`+ # will be made for that user.`
`177`	`177`	`#`
`178`	`178`	`# @yieldparam result [Result] The {Result} object for each attempt`
`179`	`179`	`# @yieldreturn [void]`