Land rapid7#4473 - Log backtraces by default

Author: wchen-r7

lib/msf/base/simple/auxiliary.rb

@@ -151,17 +151,19 @@ def self.job_run_proc(ctx)
     rescue ::Exception => e
       mod.error = e
       mod.print_error("Auxiliary failed: #{e.class} #{e}")
-      if(e.class.to_s != 'Msf::OptionValidateError')
+      elog("Auxiliary failed: #{e.class} #{e}", 'core', LEV_0)
+
+      if e.kind_of?(Msf::OptionValidateError)
+        dlog("Call stack:\n#{$@.join("\n")}", 'core', LEV_3)
+      else
         mod.print_error("Call stack:")
         e.backtrace.each do |line|
           break if line =~ /lib.msf.base.simple.auxiliary.rb/
           mod.print_error("  #{line}")
         end
+        elog("Call stack:\n#{$@.join("\n")}", 'core', LEV_0)
       end
 
-      elog("Auxiliary failed: #{e.class} #{e}", 'core', LEV_0)
-      dlog("Call stack:\n#{$@.join("\n")}", 'core', LEV_3)
-
       mod.cleanup
 
       return
@@ -182,4 +184,3 @@ def self.job_cleanup_proc(ctx)
 
 end
 end
-

lib/msf/base/simple/exploit.rb

@@ -147,7 +147,17 @@ def self.exploit_simple(oexploit, opts, &block)
       exploit.error = e
       exploit.print_error("Exploit failed: #{e}")
       elog("Exploit failed (#{exploit.refname}): #{e}", 'core', LEV_0)
-      dlog("Call stack:\n#{e.backtrace.join("\n")}", 'core', LEV_3)
+
+      if e.kind_of?(Msf::OptionValidateError)
+        dlog("Call stack:\n#{e.backtrace.join("\n")}", 'core', LEV_3)
+      else
+        mod.print_error("Call stack:")
+        e.backtrace.each do |line|
+          break if line =~ /lib.msf.base.simple.exploit.rb/
+          mod.print_error("  #{line}")
+        end
+        elog("Call stack:\n#{e.backtrace.join("\n")}", 'core', LEV_0)
+      end
     end
 
     return driver.session if driver
@@ -199,4 +209,3 @@ def check_simple(opts)
 
 end
 end
-

lib/msf/base/simple/post.rb

@@ -121,17 +121,19 @@ def self.job_run_proc(ctx)
     rescue ::Exception => e
       mod.error = e
       mod.print_error("Post failed: #{e.class} #{e}")
-      if(e.class.to_s != 'Msf::OptionValidateError')
+      elog("Post failed: #{e.class} #{e}", 'core', LEV_0)
+
+      if e.kind_of?(Msf::OptionValidateError)
+        dlog("Call stack:\n#{$@.join("\n")}", 'core', LEV_3)
+      else
         mod.print_error("Call stack:")
         e.backtrace.each do |line|
           break if line =~ /lib.msf.base.simple.post.rb/
           mod.print_error("  #{line}")
         end
+        elog("Call stack:\n#{$@.join("\n")}", 'core', LEV_0)
       end
 
-      elog("Post failed: #{e.class} #{e}", 'core', LEV_0)
-      dlog("Call stack:\n#{$@.join("\n")}", 'core', LEV_3)
-
       mod.cleanup
 
       return
@@ -154,4 +156,3 @@ def self.job_cleanup_proc(ctx)
 
 end
 end
-

lib/msf/core/exploit_driver.rb

@@ -271,14 +271,20 @@ def job_run_proc(ctx)
           exploit.fail_reason = Msf::Exploit::Failure::Unknown
         end
 
+        elog("Exploit failed (#{exploit.refname}): #{msg}", 'core', LEV_0)
+
         if exploit.fail_reason == Msf::Exploit::Failure::Unknown
           exploit.print_error("Exploit failed: #{msg}")
+          exploit.print_error("Call stack:")
+          e.backtrace.each do |line|
+            break if line =~ /lib.msf.base.core.exploit_driver.rb/
+            exploit.print_error("  #{line}")
+          end
+          elog("Call stack:\n#{e.backtrace.join("\n")}", 'core', LEV_0)
         else
           exploit.print_error("Exploit failed [#{exploit.fail_reason}]: #{msg}")
+          dlog("Call stack:\n#{e.backtrace.join("\n")}", 'core', LEV_3)
         end
-
-        elog("Exploit failed (#{exploit.refname}): #{msg}", 'core', LEV_0)
-        dlog("Call stack:\n#{e.backtrace.join("\n")}", 'core', LEV_3)
       end
 
       # Record the error to various places
@@ -329,4 +335,3 @@ def job_cleanup_proc(ctx)
 end
 
 end
-

lib/msf/ui/console/command_dispatcher/auxiliary.rb

@@ -120,12 +120,17 @@ def cmd_run(*args)
       print_error("Auxiliary interrupted by the console user")
     rescue ::Exception => e
       print_error("Auxiliary failed: #{e.class} #{e}")
-      if(e.class.to_s != 'Msf::OptionValidateError')
+      elog("Auxiliary failed: #{e.class} #{e}", 'core', LEV_0)
+
+      if e.kind_of?(Msf::OptionValidateError)
+        dlog("Call stack:\n#{e.backtrace.join("\n")}", 'core', LEV_3)
+      else
         print_error("Call stack:")
         e.backtrace.each do |line|
           break if line =~ /lib.msf.base.simple/
           print_error("  #{line}")
         end
+        elog("Call stack:\n#{e.backtrace.join("\n")}", 'core', LEV_0)
       end
 
       return false
@@ -152,4 +157,3 @@ def cmd_run_help
 end
 
 end end end end
-

lib/msf/ui/console/command_dispatcher/exploit.rb

@@ -121,12 +121,18 @@ def cmd_exploit(*args)
       raise $!
     rescue ::Exception => e
       print_error("Exploit exception (#{mod.refname}): #{e.class} #{e}")
-      if(e.class.to_s != 'Msf::OptionValidateError')
+
+      elog("Exploit exception (#{mod.refname}): #{e.class} #{e}", 'core', LEV_0)
+
+      if e.kind_of?(Msf::OptionValidateError)
+        dlog("Call stack:\n#{e.backtrace.join("\n")}", 'core', LEV_3)
+      else
         print_error("Call stack:")
         e.backtrace.each do |line|
           break if line =~ /lib.msf.base.simple/
           print_error("  #{line}")
         end
+        elog("Call stack:\n#{e.backtrace.join("\n")}", 'core', LEV_0)
       end
     end
 

lib/msf/ui/console/command_dispatcher/post.rb

@@ -122,12 +122,18 @@ def cmd_run(*args)
       print_error("Post interrupted by the console user")
     rescue ::Exception => e
       print_error("Post failed: #{e.class} #{e}")
-      if (e.class.to_s != 'Msf::OptionValidateError')
+
+      elog("Post failed: #{e.class} #{e}", 'core', LEV_0)
+
+      if e.kind_of?(Msf::OptionValidateError)
+        dlog("Call stack:\n#{e.backtrace.join("\n")}", 'core', LEV_3)
+      else
         print_error("Call stack:")
         e.backtrace.each do |line|
           break if line =~ /lib.msf.base.simple/
           print_error("  #{line}")
         end
+        elog("Call stack:\n#{e.backtrace.join("\n")}", 'core', LEV_0)
       end
 
       return false
@@ -154,4 +160,3 @@ def cmd_run_help
 end
 
 end end end end
-